From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A10F23F0A95 for ; Thu, 28 May 2026 13:10:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779973837; cv=none; b=YFmjVUJMQDnYvs3ggHZzVrcTfeZ6tNjnEeCSkbIAT60emjzqIRypQLeVL2Lj15LfBYnTczaqFcMWQp3Qt7BDFqHKIpoFRflhTAsbNdC5GUw67ayEpRwI5TtN5V3gDRhPktvzswQQUXpYEIs2YZa+lkTlbKHrxv2WVR5WyluyFIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779973837; c=relaxed/simple; bh=AcQI9F5cNSAOJ4RuYIGxht7djck6FA6kD9qOXmTuBkY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ctnoRmY6krM2OFnrx/7HB/zaIkDvEmNFyexYuUVxCZ4mdN+I3f2NYPeN6Fahz27Jy7+d0L4Cvt8mEMV3+/Qx11BIvMsawL9EAdfxw0CTlHXRgi8Z3FcRW0jFFgs/6i70FOAX+gRWtEpCqcYJV8NDCe61CoWuRZID7uPc2CfTwlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=VXRlG6vG; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=tJXvzeH0; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=iLSmSmbL; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=d0wkwg+M; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="VXRlG6vG"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="tJXvzeH0"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="iLSmSmbL"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="d0wkwg+M" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AD0346AEC1; Thu, 28 May 2026 13:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1779973834; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DYsgTfitRx2+A8KQdfOVtLqdlnKF3ZDkpUaEBRP03tc=; b=VXRlG6vGqbLmtVqOrg4SIicKfDrJbZamK9J1n5yWEiocUaEr3SaeGfWnrhlCGRZxaxKErb ZE5mdLoCUl0b1FOwh/rAJFMBRTvfT7Eg7y3+Uixitfg2IG1I3iiCmcTN1Yvhbu7v7PCO9E Acm+j/GiuCYoros9gv/7DXPJSprcKaE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1779973834; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DYsgTfitRx2+A8KQdfOVtLqdlnKF3ZDkpUaEBRP03tc=; b=tJXvzeH08huZl2PzjB9Va5+sZDLWxktefcjoYoPjevxNsfkcfC8nkssFEtKb+gBwfa/+4r D2ELLxQJiTV5XCCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iLSmSmbL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=d0wkwg+M DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1779973832; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DYsgTfitRx2+A8KQdfOVtLqdlnKF3ZDkpUaEBRP03tc=; b=iLSmSmbL72SuKRlOay/XJ5YapGrhuolOQvglqok8Ovf2M4EsFxffm4iFT10m/Qe1GeBLNF N6XH7gkhE8gNpNJ5YDGqSHnIn+8l8KbDtQtzd6+/+XItZH3Mxh92zgbexQFrMqcYb3SF2K PMVL2aUn78In+CMVuilqsJjxpZMwVrw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1779973832; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DYsgTfitRx2+A8KQdfOVtLqdlnKF3ZDkpUaEBRP03tc=; b=d0wkwg+MB4l+EfLuXZg8tRhDRU/h4lKW4wICQuzFRr5JoWohpXgL5gFr+XjIe9MEf5DnmA a9TQEBXMcM7NPXCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 66C375ADD5; Thu, 28 May 2026 13:10:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 7fP4Fsg+GGoWLAAAD6G6ig (envelope-from ); Thu, 28 May 2026 13:10:32 +0000 Date: Thu, 28 May 2026 15:09:52 +0200 From: Petr Vorel To: linux-kernel@vger.kernel.org Cc: Joe Perches , Simon Glass , Dwaipayan Ray , Lukas Bulwahn , Andy Whitcroft Subject: Re: [PATCH 1/1] checkpatch: Skip CamelCase cache for --no-tree without root Message-ID: <20260528130952.GA261301@pevik> Reply-To: Petr Vorel References: <20260519161436.79801-1-pvorel@suse.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260519161436.79801-1-pvorel@suse.cz> X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: AD0346AEC1 X-Rspamd-Action: no action X-Spamd-Result: default: False [-2.21 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email,suse.cz:dkim,suse.cz:replyto,checkpatch.pl:url,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[perches.com,chromium.org,gmail.com,canonical.com]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; TAGGED_RCPT(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; REPLYTO_EQ_FROM(0.00)[] X-Spam-Flag: NO X-Spam-Score: -2.21 Hi all, gently ping for a review. Kind regards, Petr > Running outside tree (--no-tree) without git root (--root DIR) is not > doable because we have no include/ directory which could be cached. But > 3445686af721 expected that we are always in Linux tree (w/a git). > But --no-tree does not require --root. Therefore skip whole caching in > that case. > This fixes perl and find errors when running checkpatch.pl *with* > --no-tree --strict and *without* --root: > No structs that should be const will be found - file 'scripts/const_structs.checkpatch': No such file or directory > Use of uninitialized value $root in concatenation (.) or string at scripts/checkpatch.pl line 1213. > find: ‘/include’: No such file or directory > Fixes: 3445686af721 ("checkpatch: ignore existing CamelCase uses from include/...") > Signed-off-by: Petr Vorel > --- > NOTE: I found that running checkpatch.pl on projects which vendored > checkpatch.pl (e.g. LTP or u-boot). > scripts/checkpatch.pl | 2 ++ > 1 file changed, 2 insertions(+) > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 0d18771f1b01..939d2b9ecebd 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1208,6 +1208,8 @@ sub seed_camelcase_includes { > my $git_last_include_commit = `${git_command} log --no-merges --pretty=format:"%h%n" -1 -- include`; > chomp $git_last_include_commit; > $camelcase_cache = ".checkpatch-camelcase.git.$git_last_include_commit"; > + } elsif (not defined $root) { > + return; > } else { > my $last_mod_date = 0; > $files = `find $root/include -name "*.h"`;