Re: [PATCH v2 1/6] dt-bindings: leds: Document TI LM3533 LED controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The property `ti,resistor-ohm` does not use the standard DT schema unit suffix (`-ohms`), and its description contains a typo ('resister').
--

commit 3710ffb632b560bb2fb8a924f794c4e747f0362b
Author: Svyatoslav Ryhel <clamor95@gmail.com>

dt-bindings: leds: Document TI LM3533 LED controller

This commit documents the LM3533, a complete power source for backlight, keypad,
and indicator LEDs in smartphone handsets. The high-voltage inductive boost
converter provides power for two series LED strings for the display backlight
and keypad functions.

> diff --git a/Documentation/devicetree/bindings/leds/ti,lm3533.yaml b/Documentation/devicetree/bindings/leds/ti,lm3533.yaml
> new file mode 100644
> index 0000000000000..6e12e12be08e5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/ti,lm3533.yaml
> @@ -0,0 +1,170 @@
[ ... ]
> +  light-sensor:
> +    type: object
> +    additionalProperties: false
> +
> +    properties:
> +      compatible:
> +        const: ti,lm3533-als
> +
> +      interrupts:
> +        maxItems: 1
> +
> +      ti,resistor-ohm:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        description:
> +          Internal configuration resister value when light sensor is in

[Severity: Low]
This isn't a bug, but should this property use the standard dt-schema unit
suffix -ohms instead of -ohm? Standardizing the unit suffix allows
dt-schema to automatically infer the property type without needing an
explicit reference.

Additionally, is there a typo in the description where it says resister
instead of resistor?

> +          Analog Sensor mode and PWM mode is disabled. The expectation is
> +          the input is a current from the external analog light sensor and
> +          this is used to convert it to a voltage within the target range.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260528135123.103745-1-clamor95@gmail.com?part=1