Re: [PATCH v7 2/2] arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The Type-C SBU endpoint in the `pmic-glink` connector node is incorrectly assigned to `port@1` instead of `port@2`.
--

commit 9a9b64540450daa489edb83d1eb2b8d095f07b3b
Author: Stanislav Zaikin <zstaseg@gmail.com>

arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS

This commit adds device tree support for the Xiaomi 12 Lite 5G (taoyao),
a handset released in 2022. It enables features like display, touchscreen,
UFS, pinctrl, regulators, remoteprocs, and USB device mode.

> diff --git a/arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts b/arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts
> new file mode 100644
> index 0000000000000..ae38484cdaa0e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts

[ ... ]

> +	pmic-glink {
> +		compatible = "qcom,sm7325-pmic-glink",
> +			     "qcom,qcm6490-pmic-glink",
> +			     "qcom,pmic-glink";
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		orientation-gpios = <&tlmm 140 GPIO_ACTIVE_HIGH>;
> +
> +		connector@0 {
> +			compatible = "usb-c-connector";
> +			reg = <0>;
> +			power-role = "dual";
> +			data-role = "dual";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +
> +					pmic_glink_hs_in: endpoint {
> +						remote-endpoint = <&usb_1_dwc3_hs>;
> +					};
> +				};
> +
> +				port@1 {
> +					reg = <1>;
> +
> +					pmic_glink_sbu: endpoint {
> +						remote-endpoint = <&fsa4480_sbu_mux>;
> +					};
> +				};

[Severity: Low]
Does this incorrectly assign the Type-C SBU endpoint to port@1 instead of
port@2?

According to the standard usb-connector.yaml device tree bindings, port@0
is reserved for High Speed (HS) data lines, port@1 for Super Speed (SS) data
lines, and port@2 for Sideband Use (SBU) lines.

Assigning the SBU endpoint to port@1 violates the device tree schema, even if
Super Speed lines are not implemented on the device, and could potentially
confuse USB Type-C drivers that rely on standard port indices for SBU routing
and Alternate Modes.

> +			};
> +		};
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260528152011.376711-1-zstaseg@gmail.com?part=2