Re: [PATCH v2] KVM: selftests: hyperv_tlb_flush: use swap() to swap PTEs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding the `swap()` macro to `kselftest.h` introduces a macro redefinition warning in the mm selftests.
--

commit 677f4e84e8344f4b974940d4980c2813e71714b6
Author: Piotr Zarycki <piotr.zarycki@gmail.com>

KVM: selftests: hyperv_tlb_flush: use swap() to swap PTEs

This commit replaces the open-coded variable swapping in the hyperv_tlb_flush
selftest by introducing a swap() macro in the shared kselftest.h header.

> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
> index 60838b61a2da5..7f53751523d89 100644
> --- a/tools/testing/selftests/kselftest.h
> +++ b/tools/testing/selftests/kselftest.h
> @@ -64,6 +64,10 @@
>  #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
>  #endif
>  
> +#ifndef swap
> +#define swap(a, b)  do { typeof(a) __tmp = (a); (a) = (b); (b) = __tmp; } while (0)
> +#endif

[Severity: Low]
Does adding this swap() macro to the global kselftest.h header cause a macro
redefinition warning elsewhere in the selftests?

The tools/testing/selftests/mm/uffd-stress.c test includes kselftest.h (via
uffd-common.h) and unconditionally defines its own swap(a, b) macro using
__auto_type. Because this patch adds swap() to the shared kselftest.h header,
compiling uffd-stress.c will now trigger a compiler warning for macro
redefinition.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260528154003.3594107-1-piotr.zarycki@gmail.com?part=1