All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: phucduc.bui@gmail.com
Cc: Mark Brown <broonie@kernel.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	driver-core@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: reject volatile update_bits() in cache-only mode
Date: Thu, 28 May 2026 07:42:22 +0200	[thread overview]
Message-ID: <2026052841-task-surgical-1342@gregkh> (raw)
In-Reply-To: <20260528053204.46783-1-phucduc.bui@gmail.com>

On Thu, May 28, 2026 at 12:32:04PM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> Prevent _regmap_update_bits() from accessing hardware when the register
> map is in cache-only mode.
> 
> Unlike regmap_raw_read() and _regmap_read(), the volatile
> _regmap_update_bits() fast path bypasses the cache_only check. This can
> result in unexpected hardware accesses while the device is suspended.
> 
> Return -EBUSY to ensure behavior is consistent with other cache-only
> access paths.
> 
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
> 
> Compile-tested only.

So this isn't a real bug that you have found and tested this fix
resolves?  How was this "found"?

Please submit stuff that actually is verified to resolve a real issue.

thanks,

greg k-h

  reply	other threads:[~2026-05-28  5:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28  5:32 [PATCH] regmap: reject volatile update_bits() in cache-only mode phucduc.bui
2026-05-28  5:42 ` Greg Kroah-Hartman [this message]
2026-05-28  6:55   ` Bui Duc Phuc
2026-05-28 14:16 ` Mark Brown
2026-05-29 23:16   ` Bui Duc Phuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026052841-task-surgical-1342@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=broonie@kernel.org \
    --cc=dakr@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phucduc.bui@gmail.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.