From: Conor Dooley <conor@kernel.org>
To: "Stefan Dösinger" <stefandoesinger@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Brian Masney <bmasney@redhat.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC v3 2/5] dt-bindings: clk: zte: Add zx297520v3 LSP clock and reset bindings.
Date: Fri, 29 May 2026 17:49:27 +0100 [thread overview]
Message-ID: <20260529-hypocrisy-clump-abf596df704d@spud> (raw)
In-Reply-To: <20260529-zx29clk-v3-2-c7fe54ea388f@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1568 bytes --]
On Fri, May 29, 2026 at 12:52:59AM +0300, Stefan Dösinger wrote:
> +properties:
> + compatible:
> + const: zte,zx297520v3-lspclk
> +
> + clocks:
> + items:
> + - description: Main PLL divided by 5 output from topclk (124.8 MHz)
> + - description: Main PLL divided by 4 output from topclk (156 MHz)
> + - description: Main PLL divided by 6 output from topclk (104 MHz)
> + - description: Main PLL divided by 8 output from topclk (78 MHz)
> + - description: Main PLL divided by 12 output from topclk (52 MHz)
> + - description: Main oscillator output from topclk (26 MHz)
> + - description: Timer oscillator output from topclk (32 KHz)
> + - description: LSP pclk output from topclk (26 MHz)
> + - description: TDM wclk mux output from topclk
> + - description: DPLL divided by 4 output from topclk (122.88 MHz)
> +
> + clock-names:
> + items:
> + - const: mpll_d5
> + - const: mpll_d4
> + - const: mpll_d6
> + - const: mpll_d8
> + - const: mpll_d12
> + - const: osc26m
> + - const: osc32k
> + - const: pclk
> + - const: tdm_wclk
> + - const: dpll_d4
> +
> + "#clock-cells":
> + const: 1
> +
> + "#reset-cells":
> + const: 1
> +
> + reg:
> + items:
> + - description: IO memory region of the LSP controller
Just make this "maxItems: 1".
Also, sort reg after compatible please.
Same comments apply here about the example and using _END defines.
pw-bot: changes-requested
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-05-29 16:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 21:52 [PATCH RFC v3 0/5] ZTE zx297520v3 clock bindings and driver Stefan Dösinger
2026-05-28 21:52 ` [PATCH RFC v3 1/5] dt-bindings: clk: zte: Add zx297520v3 top clock and reset bindings Stefan Dösinger
2026-05-28 22:02 ` sashiko-bot
2026-05-29 16:48 ` Conor Dooley
2026-06-02 19:09 ` Stefan Dösinger
2026-06-02 23:14 ` Conor Dooley
2026-05-28 21:52 ` [PATCH RFC v3 2/5] dt-bindings: clk: zte: Add zx297520v3 LSP " Stefan Dösinger
2026-05-29 16:49 ` Conor Dooley [this message]
2026-05-28 21:53 ` [PATCH RFC v3 3/5] clk: zte: Introduce a driver for zx297520v3 top clocks and resets Stefan Dösinger
2026-05-28 22:41 ` sashiko-bot
2026-06-03 9:14 ` Philipp Zabel
2026-06-03 20:49 ` Stefan Dösinger
2026-06-04 13:44 ` Philipp Zabel
2026-05-28 21:53 ` [PATCH RFC v3 4/5] clk: zte: Introduce a driver for zx297520v3 LSP " Stefan Dösinger
2026-05-28 23:08 ` sashiko-bot
2026-05-28 21:53 ` [PATCH RFC v3 5/5] ARM: dts: zte: Declare a zx297520v3 clock device nodes Stefan Dösinger
2026-05-28 23:17 ` sashiko-bot
2026-06-03 8:50 ` [PATCH RFC v3 0/5] ZTE zx297520v3 clock bindings and driver Philipp Zabel
2026-06-03 20:49 ` Stefan Dösinger
2026-06-04 15:23 ` Philipp Zabel
2026-06-09 16:42 ` Stefan Dösinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529-hypocrisy-clump-abf596df704d@spud \
--to=conor@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=stefandoesinger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.