From: Bin Guo <guobin@linux.alibaba.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, kwolf@redhat.com
Subject: [PATCH] util/qemu-coroutine: skip global pool lock when pool is empty
Date: Fri, 29 May 2026 09:54:23 +0800 [thread overview]
Message-ID: <20260529015423.49688-1-guobin@linux.alibaba.com> (raw)
coroutine_pool_refill_local() acquires global_pool_lock on every
call even when the global pool is empty (global_pool_size == 0).
Under high I/O concurrency many threads simultaneously attempt to
refill from an empty global pool, causing unnecessary mutex
contention.
Add a fast-path check: read global_pool_size with qatomic_read()
before acquiring the mutex. If zero, the global pool is empty and
we return immediately. This is a racy read but correctness is
preserved: the only consequence of a stale read is a missed refill
opportunity, which will be retried on the next coroutine allocation.
Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
---
util/qemu-coroutine.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/util/qemu-coroutine.c b/util/qemu-coroutine.c
index d17135f585..0f8c3a23eb 100644
--- a/util/qemu-coroutine.c
+++ b/util/qemu-coroutine.c
@@ -138,6 +138,15 @@ static void coroutine_pool_refill_local(void)
CoroutinePool *local_pool = get_ptr_local_pool();
CoroutinePoolBatch *batch = NULL;
+ /*
+ * Fast path: skip the lock when the global pool is obviously empty.
+ * The read is racy but harmless -- worst case we miss a concurrent
+ * put and retry on the next allocation.
+ */
+ if (qatomic_read(&global_pool_size) == 0) {
+ return;
+ }
+
WITH_QEMU_LOCK_GUARD(&global_pool_lock) {
batch = QSLIST_FIRST(&global_pool);
--
2.50.1 (Apple Git-155)
next reply other threads:[~2026-05-29 1:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 1:54 Bin Guo [this message]
2026-05-29 8:34 ` [PATCH] util/qemu-coroutine: skip global pool lock when pool is empty Paolo Bonzini
2026-05-29 13:39 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529015423.49688-1-guobin@linux.alibaba.com \
--to=guobin@linux.alibaba.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.