From: kernel test robot <lkp@intel.com>
To: "Ethan Nelson-Moore" <enelsonmoore@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev, Jakub Kicinski <kuba@kernel.org>
Subject: [linux-next:master 6876/9137] drivers/net/arcnet/com20020-pci.c:225:52: warning: 'snprintf' output may be truncated before the last format character
Date: Fri, 29 May 2026 04:39:40 +0800 [thread overview]
Message-ID: <202605290432.Pyzd4kuW-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: f7af91adc230aa99e23330ecf85bc9badd9780ad
commit: eb8ffe14a554808eb68cf050ba5343dbbe15bb54 [6876/9137] net: arcnet: com20020-pci: avoid -Wformat-truncation warning
config: alpha-randconfig-r072-20260529 (https://download.01.org/0day-ci/archive/20260529/202605290432.Pyzd4kuW-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 8.5.0
smatch: v0.5.0-9185-gbcc58b9c
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260529/202605290432.Pyzd4kuW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605290432.Pyzd4kuW-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/arcnet/com20020-pci.c: In function 'com20020pci_probe':
>> drivers/net/arcnet/com20020-pci.c:225:52: warning: 'snprintf' output may be truncated before the last format character [-Wformat-truncation=]
snprintf(dev->name, sizeof(dev->name), "arc%d-%d", dev->dev_id, i);
^
drivers/net/arcnet/com20020-pci.c:225:4: note: 'snprintf' output between 7 and 17 bytes into a destination of size 16
snprintf(dev->name, sizeof(dev->name), "arc%d-%d", dev->dev_id, i);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/snprintf +225 drivers/net/arcnet/com20020-pci.c
c51da42a6346c0c Michal Grzeschik 2014-09-29 121
d6d7d3ed56e3bfe Joe Perches 2015-05-05 122 static int com20020pci_probe(struct pci_dev *pdev,
d6d7d3ed56e3bfe Joe Perches 2015-05-05 123 const struct pci_device_id *id)
^1da177e4c3f415 Linus Torvalds 2005-04-16 124 {
8c14f9c70327a6f Michal Grzeschik 2014-09-29 125 struct com20020_pci_card_info *ci;
5ef216c1f84825c Michal Grzeschik 2014-09-18 126 struct com20020_pci_channel_map *mm;
^1da177e4c3f415 Linus Torvalds 2005-04-16 127 struct net_device *dev;
^1da177e4c3f415 Linus Torvalds 2005-04-16 128 struct arcnet_local *lp;
c51da42a6346c0c Michal Grzeschik 2014-09-29 129 struct com20020_priv *priv;
eb8ffe14a554808 Ethan Nelson-Moore 2026-05-20 130 int ioaddr, ret;
eb8ffe14a554808 Ethan Nelson-Moore 2026-05-20 131 u8 i;
c51da42a6346c0c Michal Grzeschik 2014-09-29 132 struct resource *r;
^1da177e4c3f415 Linus Torvalds 2005-04-16 133
6577b9a551aedb8 Tong Zhang 2021-03-14 134 ret = 0;
6577b9a551aedb8 Tong Zhang 2021-03-14 135
^1da177e4c3f415 Linus Torvalds 2005-04-16 136 if (pci_enable_device(pdev))
^1da177e4c3f415 Linus Torvalds 2005-04-16 137 return -EIO;
c51da42a6346c0c Michal Grzeschik 2014-09-29 138
c51da42a6346c0c Michal Grzeschik 2014-09-29 139 priv = devm_kzalloc(&pdev->dev, sizeof(struct com20020_priv),
c51da42a6346c0c Michal Grzeschik 2014-09-29 140 GFP_KERNEL);
e8a308affcd79d9 Kiran Padwal 2015-02-05 141 if (!priv)
e8a308affcd79d9 Kiran Padwal 2015-02-05 142 return -ENOMEM;
e8a308affcd79d9 Kiran Padwal 2015-02-05 143
c51da42a6346c0c Michal Grzeschik 2014-09-29 144 ci = (struct com20020_pci_card_info *)id->driver_data;
bd6f1fd5d33dfe5 Zheyu Ma 2022-03-02 145 if (!ci)
c7d9be66b71af49 Ethan Nelson-Moore 2026-02-12 146 ci = &card_info_2p5mbit;
bd6f1fd5d33dfe5 Zheyu Ma 2022-03-02 147
c51da42a6346c0c Michal Grzeschik 2014-09-29 148 priv->ci = ci;
5ef216c1f84825c Michal Grzeschik 2014-09-18 149 mm = &ci->misc_map;
c51da42a6346c0c Michal Grzeschik 2014-09-29 150
6577b9a551aedb8 Tong Zhang 2021-03-14 151 pci_set_drvdata(pdev, priv);
6577b9a551aedb8 Tong Zhang 2021-03-14 152
c51da42a6346c0c Michal Grzeschik 2014-09-29 153 INIT_LIST_HEAD(&priv->list_dev);
c51da42a6346c0c Michal Grzeschik 2014-09-29 154
5ef216c1f84825c Michal Grzeschik 2014-09-18 155 if (mm->size) {
5ef216c1f84825c Michal Grzeschik 2014-09-18 156 ioaddr = pci_resource_start(pdev, mm->bar) + mm->offset;
5ef216c1f84825c Michal Grzeschik 2014-09-18 157 r = devm_request_region(&pdev->dev, ioaddr, mm->size,
5ef216c1f84825c Michal Grzeschik 2014-09-18 158 "com20020-pci");
5ef216c1f84825c Michal Grzeschik 2014-09-18 159 if (!r) {
5ef216c1f84825c Michal Grzeschik 2014-09-18 160 pr_err("IO region %xh-%xh already allocated.\n",
5ef216c1f84825c Michal Grzeschik 2014-09-18 161 ioaddr, ioaddr + mm->size - 1);
5ef216c1f84825c Michal Grzeschik 2014-09-18 162 return -EBUSY;
5ef216c1f84825c Michal Grzeschik 2014-09-18 163 }
5ef216c1f84825c Michal Grzeschik 2014-09-18 164 priv->misc = ioaddr;
5ef216c1f84825c Michal Grzeschik 2014-09-18 165 }
5ef216c1f84825c Michal Grzeschik 2014-09-18 166
c51da42a6346c0c Michal Grzeschik 2014-09-29 167 for (i = 0; i < ci->devcount; i++) {
c51da42a6346c0c Michal Grzeschik 2014-09-29 168 struct com20020_pci_channel_map *cm = &ci->chan_map_tbl[i];
c51da42a6346c0c Michal Grzeschik 2014-09-29 169 struct com20020_dev *card;
cb108619f2fc778 Michal Grzeschik 2017-06-28 170 int dev_id_mask = 0xf;
c51da42a6346c0c Michal Grzeschik 2014-09-29 171
^1da177e4c3f415 Linus Torvalds 2005-04-16 172 dev = alloc_arcdev(device);
c51da42a6346c0c Michal Grzeschik 2014-09-29 173 if (!dev) {
c51da42a6346c0c Michal Grzeschik 2014-09-29 174 ret = -ENOMEM;
6577b9a551aedb8 Tong Zhang 2021-03-14 175 break;
c51da42a6346c0c Michal Grzeschik 2014-09-29 176 }
ae8ede6a0cdcf3b Michal Grzeschik 2015-03-20 177 dev->dev_port = i;
a1799af4d7deefc Stephen Hemminger 2009-01-09 178
a1799af4d7deefc Stephen Hemminger 2009-01-09 179 dev->netdev_ops = &com20020_netdev_ops;
a1799af4d7deefc Stephen Hemminger 2009-01-09 180
454d7c9b14e20fd Wang Chen 2008-11-12 181 lp = netdev_priv(dev);
^1da177e4c3f415 Linus Torvalds 2005-04-16 182
a34c0932c3b2f28 Joe Perches 2015-05-05 183 arc_printk(D_NORMAL, dev, "%s Controls\n", ci->name);
c51da42a6346c0c Michal Grzeschik 2014-09-29 184 ioaddr = pci_resource_start(pdev, cm->bar) + cm->offset;
c51da42a6346c0c Michal Grzeschik 2014-09-29 185
c51da42a6346c0c Michal Grzeschik 2014-09-29 186 r = devm_request_region(&pdev->dev, ioaddr, cm->size,
c51da42a6346c0c Michal Grzeschik 2014-09-29 187 "com20020-pci");
c51da42a6346c0c Michal Grzeschik 2014-09-29 188 if (!r) {
05a24b234b9dda3 Joe Perches 2015-05-05 189 pr_err("IO region %xh-%xh already allocated\n",
c51da42a6346c0c Michal Grzeschik 2014-09-29 190 ioaddr, ioaddr + cm->size - 1);
c51da42a6346c0c Michal Grzeschik 2014-09-29 191 ret = -EBUSY;
6577b9a551aedb8 Tong Zhang 2021-03-14 192 goto err_free_arcdev;
^1da177e4c3f415 Linus Torvalds 2005-04-16 193 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 194
c51da42a6346c0c Michal Grzeschik 2014-09-29 195 /* Dummy access after Reset
c51da42a6346c0c Michal Grzeschik 2014-09-29 196 * ARCNET controller needs
c51da42a6346c0c Michal Grzeschik 2014-09-29 197 * this access to detect bustype
c51da42a6346c0c Michal Grzeschik 2014-09-29 198 */
e859db8ac490832 Ethan Nelson-Moore 2026-05-20 199 outb(0x00, ioaddr + COM20020_REG_W_COMMAND);
e859db8ac490832 Ethan Nelson-Moore 2026-05-20 200 inb(ioaddr + COM20020_REG_R_DIAGSTAT);
^1da177e4c3f415 Linus Torvalds 2005-04-16 201
2a0ea04c83ab82c Michal Grzeschik 2017-06-28 202 SET_NETDEV_DEV(dev, &pdev->dev);
^1da177e4c3f415 Linus Torvalds 2005-04-16 203 dev->base_addr = ioaddr;
13b5ffa0e282f3d Jakub Kicinski 2021-10-12 204 arcnet_set_addr(dev, node);
ede07a1fc7d70ad Michal Grzeschik 2017-06-28 205 dev->sysfs_groups[0] = &com20020_state_group;
c51da42a6346c0c Michal Grzeschik 2014-09-29 206 dev->irq = pdev->irq;
^1da177e4c3f415 Linus Torvalds 2005-04-16 207 lp->card_name = "PCI COM20020";
8c14f9c70327a6f Michal Grzeschik 2014-09-29 208 lp->card_flags = ci->flags;
^1da177e4c3f415 Linus Torvalds 2005-04-16 209 lp->backplane = backplane;
^1da177e4c3f415 Linus Torvalds 2005-04-16 210 lp->clockp = clockp & 7;
^1da177e4c3f415 Linus Torvalds 2005-04-16 211 lp->clockm = clockm & 3;
^1da177e4c3f415 Linus Torvalds 2005-04-16 212 lp->timeout = timeout;
^1da177e4c3f415 Linus Torvalds 2005-04-16 213 lp->hw.owner = THIS_MODULE;
^1da177e4c3f415 Linus Torvalds 2005-04-16 214
52ab12e4f99437a Michal Grzeschik 2017-06-28 215 lp->backplane = (inb(priv->misc) >> (2 + i)) & 0x1;
52ab12e4f99437a Michal Grzeschik 2017-06-28 216
a356ab1c3d46513 Michal Grzeschik 2017-06-28 217 if (!strncmp(ci->name, "EAE PLX-PCI FB2", 15))
a356ab1c3d46513 Michal Grzeschik 2017-06-28 218 lp->backplane = 1;
a356ab1c3d46513 Michal Grzeschik 2017-06-28 219
6b17a597fc2f13a Thomas Reichinger 2023-11-30 220 if (ci->flags & ARC_HAS_ROTARY) {
5ef216c1f84825c Michal Grzeschik 2014-09-18 221 /* Get the dev_id from the PLX rotary coder */
5ef216c1f84825c Michal Grzeschik 2014-09-18 222 if (!strncmp(ci->name, "EAE PLX-PCI MA1", 15))
cb108619f2fc778 Michal Grzeschik 2017-06-28 223 dev_id_mask = 0x3;
cb108619f2fc778 Michal Grzeschik 2017-06-28 224 dev->dev_id = (inb(priv->misc + ci->rotary) >> 4) & dev_id_mask;
5ef216c1f84825c Michal Grzeschik 2014-09-18 @225 snprintf(dev->name, sizeof(dev->name), "arc%d-%d", dev->dev_id, i);
6b17a597fc2f13a Thomas Reichinger 2023-11-30 226 }
5ef216c1f84825c Michal Grzeschik 2014-09-18 227
e859db8ac490832 Ethan Nelson-Moore 2026-05-20 228 if (inb(ioaddr + COM20020_REG_R_STATUS) == 0xFF) {
c51da42a6346c0c Michal Grzeschik 2014-09-29 229 pr_err("IO address %Xh is empty!\n", ioaddr);
c51da42a6346c0c Michal Grzeschik 2014-09-29 230 ret = -EIO;
6577b9a551aedb8 Tong Zhang 2021-03-14 231 goto err_free_arcdev;
^1da177e4c3f415 Linus Torvalds 2005-04-16 232 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 233 if (com20020_check(dev)) {
c51da42a6346c0c Michal Grzeschik 2014-09-29 234 ret = -EIO;
6577b9a551aedb8 Tong Zhang 2021-03-14 235 goto err_free_arcdev;
^1da177e4c3f415 Linus Torvalds 2005-04-16 236 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 237
6b17a597fc2f13a Thomas Reichinger 2023-11-30 238 ret = com20020_found(dev, IRQF_SHARED);
6b17a597fc2f13a Thomas Reichinger 2023-11-30 239 if (ret)
6b17a597fc2f13a Thomas Reichinger 2023-11-30 240 goto err_free_arcdev;
6b17a597fc2f13a Thomas Reichinger 2023-11-30 241
c51da42a6346c0c Michal Grzeschik 2014-09-29 242 card = devm_kzalloc(&pdev->dev, sizeof(struct com20020_dev),
c51da42a6346c0c Michal Grzeschik 2014-09-29 243 GFP_KERNEL);
01c3521f794ce94 Christophe Jaillet 2017-07-07 244 if (!card) {
01c3521f794ce94 Christophe Jaillet 2017-07-07 245 ret = -ENOMEM;
6577b9a551aedb8 Tong Zhang 2021-03-14 246 goto err_free_arcdev;
01c3521f794ce94 Christophe Jaillet 2017-07-07 247 }
c51da42a6346c0c Michal Grzeschik 2014-09-29 248
c51da42a6346c0c Michal Grzeschik 2014-09-29 249 card->index = i;
c51da42a6346c0c Michal Grzeschik 2014-09-29 250 card->pci_priv = priv;
6b17a597fc2f13a Thomas Reichinger 2023-11-30 251
6b17a597fc2f13a Thomas Reichinger 2023-11-30 252 if (ci->flags & ARC_HAS_LED) {
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 253 card->tx_led.brightness_set = led_tx_set;
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 254 card->tx_led.default_trigger = devm_kasprintf(&pdev->dev,
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 255 GFP_KERNEL, "arc%d-%d-tx",
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 256 dev->dev_id, i);
fda8c491db2a90f Henry Martin 2025-04-02 257 if (!card->tx_led.default_trigger) {
fda8c491db2a90f Henry Martin 2025-04-02 258 ret = -ENOMEM;
fda8c491db2a90f Henry Martin 2025-04-02 259 goto err_free_arcdev;
fda8c491db2a90f Henry Martin 2025-04-02 260 }
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 261 card->tx_led.name = devm_kasprintf(&pdev->dev, GFP_KERNEL,
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 262 "pci:green:tx:%d-%d",
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 263 dev->dev_id, i);
fda8c491db2a90f Henry Martin 2025-04-02 264 if (!card->tx_led.name) {
fda8c491db2a90f Henry Martin 2025-04-02 265 ret = -ENOMEM;
fda8c491db2a90f Henry Martin 2025-04-02 266 goto err_free_arcdev;
fda8c491db2a90f Henry Martin 2025-04-02 267 }
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 268 card->tx_led.dev = &dev->dev;
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 269 card->recon_led.brightness_set = led_recon_set;
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 270 card->recon_led.default_trigger = devm_kasprintf(&pdev->dev,
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 271 GFP_KERNEL, "arc%d-%d-recon",
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 272 dev->dev_id, i);
fda8c491db2a90f Henry Martin 2025-04-02 273 if (!card->recon_led.default_trigger) {
fda8c491db2a90f Henry Martin 2025-04-02 274 ret = -ENOMEM;
fda8c491db2a90f Henry Martin 2025-04-02 275 goto err_free_arcdev;
fda8c491db2a90f Henry Martin 2025-04-02 276 }
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 277 card->recon_led.name = devm_kasprintf(&pdev->dev, GFP_KERNEL,
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 278 "pci:red:recon:%d-%d",
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 279 dev->dev_id, i);
fda8c491db2a90f Henry Martin 2025-04-02 280 if (!card->recon_led.name) {
fda8c491db2a90f Henry Martin 2025-04-02 281 ret = -ENOMEM;
fda8c491db2a90f Henry Martin 2025-04-02 282 goto err_free_arcdev;
fda8c491db2a90f Henry Martin 2025-04-02 283 }
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 284 card->recon_led.dev = &dev->dev;
c51da42a6346c0c Michal Grzeschik 2014-09-29 285
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 286 ret = devm_led_classdev_register(&pdev->dev, &card->tx_led);
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 287 if (ret)
6577b9a551aedb8 Tong Zhang 2021-03-14 288 goto err_free_arcdev;
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 289
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 290 ret = devm_led_classdev_register(&pdev->dev, &card->recon_led);
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 291 if (ret)
6577b9a551aedb8 Tong Zhang 2021-03-14 292 goto err_free_arcdev;
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 293
c51da42a6346c0c Michal Grzeschik 2014-09-29 294 dev_set_drvdata(&dev->dev, card);
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 295 devm_arcnet_led_init(dev, dev->dev_id, i);
6b17a597fc2f13a Thomas Reichinger 2023-11-30 296 }
8890624a4e8c2c7 Michal Grzeschik 2014-09-18 297
6b17a597fc2f13a Thomas Reichinger 2023-11-30 298 card->dev = dev;
c51da42a6346c0c Michal Grzeschik 2014-09-29 299 list_add(&card->list, &priv->list_dev);
6577b9a551aedb8 Tong Zhang 2021-03-14 300 continue;
^1da177e4c3f415 Linus Torvalds 2005-04-16 301
6577b9a551aedb8 Tong Zhang 2021-03-14 302 err_free_arcdev:
6577b9a551aedb8 Tong Zhang 2021-03-14 303 free_arcdev(dev);
6577b9a551aedb8 Tong Zhang 2021-03-14 304 break;
6577b9a551aedb8 Tong Zhang 2021-03-14 305 }
6577b9a551aedb8 Tong Zhang 2021-03-14 306 if (ret)
c51da42a6346c0c Michal Grzeschik 2014-09-29 307 com20020pci_remove(pdev);
c51da42a6346c0c Michal Grzeschik 2014-09-29 308 return ret;
^1da177e4c3f415 Linus Torvalds 2005-04-16 309 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 310
:::::: The code at line 225 was first introduced by commit
:::::: 5ef216c1f84825c6942fdd6c24d12a08ac2df135 arcnet: com20020-pci: add rotary index support
:::::: TO: Michael Grzeschik <m.grzeschik@pengutronix.de>
:::::: CC: Michael Grzeschik <m.grzeschik@pengutronix.de>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-05-28 20:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202605290432.Pyzd4kuW-lkp@intel.com \
--to=lkp@intel.com \
--cc=enelsonmoore@gmail.com \
--cc=kuba@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.