From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93FA43DFC60 for ; Fri, 29 May 2026 12:06:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780056391; cv=none; b=RDtHKZ5A8TuL3z6QBBvB0DIarUjyKm5FksSvX+HMyJmnJX3G11Vpo/8bVgRGr5IXN9ish3YBKNOkI7nMI3qODEPJGNhekY/qNOHaRaN5SQtnUcIR2Uxt4S2EmBNbJqNXxfdu/qJ5dWJzDeaAhwnFqD4ye44d1HNMUtpYdDGWb1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780056391; c=relaxed/simple; bh=z5MeuZGbZL70SAzX/1/HK1UFdcBmRR3cc/7Ci8mb7kE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HXwmgg1j7HQxoO+ppgo4hQ9fGBPeN880CskhV9asNN3T1c9RqsCcaqau07pV7HC5HE4uOS0cTGsKpPc13PE0/03I3wkvMs9qKG55lR+FCTjltWUBBMu147+v20BSxp3ASzcPauDVz4VlR0lxox9/sh130dE80nwtzeHp+LGxsuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=obBB0m/Z; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="obBB0m/Z" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4891e5b9c1fso120285545e9.2 for ; Fri, 29 May 2026 05:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780056385; x=1780661185; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=72jz4VASspyNfZwaO2ZoEBYiy1qSN0s6Nl9KPx8bbj4=; b=obBB0m/Z9HZc740gz7xyTJSQzsxSmS562TVBLCy7ZSn5+tB0q7VMz4GSsiNOsWcE+O 8ORhMj2/dDrhETgHaq6PGJ2s0Tc/4nDF9KkKrKYh2806QofWIUlj0ubozz3TrKG6akh5 CuhVyZp8sbcPIjpZXrDA/O5qiICmnABtMUrxMhoqPyf9jzeayflGsSvyNnL4cfLX6TJb c/5+O3FWD6/8xs2xV0rc52GGc8T15vf9weZvp3a2pURo/eYrgPFbvGHfNVd1nAJfhHHZ fiEOijBqwMX5ZW+7767flG6hhye7GLIpBWv76/iTIqF6uqYRRlTeRl2SIU75j5DxW2KR bGEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780056385; x=1780661185; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=72jz4VASspyNfZwaO2ZoEBYiy1qSN0s6Nl9KPx8bbj4=; b=OqcpSQrXOFufvHAS50zmkJAjRuc+4yTmDummys1fhSbYyl1LZQG9lkoS1l6YvH7M8K 03S0Su3EV6APn8wH96lq0WvT9rj96QJu4r1T6Dyl42RUDbKCpyXgeQC839wTMU/V0bKB sZm+HEtB8MYcnDiqX9TuxPMRzjXQWMUAmXv0OqxCmuicGkYw/1Zh/lRx9pMcwOw3INUw q1xo4lhI+HMNZktFwmbAIRdPt0zo8/QtQy1ejQvdlApzUa9YRLP0uprYC4K9NA5R0hhw 41efqAtRv9/eP4wkOB/rMnEA6sdWdXW0V9ya7f7ag0FrKTvY3PQHuC/RNXG8LotgJEFl pW+g== X-Forwarded-Encrypted: i=1; AFNElJ8oRl08khuwlbiqstC2VahONhktOKiiv7N5A3pvRzjmg1DzDUJVR0FeAW6ssCN4l6DfshflGQnxVWA=@vger.kernel.org X-Gm-Message-State: AOJu0YxOh2cKQtyvbsq+KnS4ovL0E2dHq5SqegJdo+hZqsOiM27oDysG SxB0pu7HuTrw+l8JdiUkI7NfayyIm9rIDf0xJFOchWvNugiJ5xEq28jL X-Gm-Gg: Acq92OHmfPS/bjuxFX4GjrTObKEt05CKwo+55UbVxaGWlxPrQYCQB8FaebH4Sq1L4Am QbuzmR1bIu0W/91Y3Yq8WO8d6Vwqq+OhV0gLxcJjWxZGz9ghot8fjk7vcGC53y8A/c4HivN4fTp CqFVVTd6ZET2w4s6YdfSR96BstUqa7dyu0rjGFPi8tLgp3idOqAXm9i623sVEp08PZ65cxvwnkX IZiR0LX+otITyJ6alT92YuFqYjfB4jRHGFTJVLDNTk2VmEjQzpDTYqsCrzZ0H/Y1w6YuIwSY6B8 9zqVPsRb80zbOIHPg0ewNBooGjBkhiCWcTCXgvlyO3NGiOlfbS9SehVrzmTQTwsbvIbRrVkDR4i BTqcW+y04ncvzjMVXJc0c8ANlpP4kb4XnJBl8FU4xmyAlIRvX3fA1dnqUMDvmzcum72J0SoV52x E1oTxk1s2BOjArKrlS5+aniZvFkolr0Tv4GOesWdXJnRz3hih19v8QIjlRUt+IojR7aQbJnz0= X-Received: by 2002:a05:600c:1f93:b0:48f:e230:8cad with SMTP id 5b1f17b1804b1-4909ca8958dmr45994995e9.33.1780056385169; Fri, 29 May 2026 05:06:25 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909cab7b00sm40374125e9.14.2026.05.29.05.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 05:06:24 -0700 (PDT) Date: Fri, 29 May 2026 13:06:19 +0100 From: David Laight To: Robin Murphy Cc: Yury Norov , Andrew Morton , Rasmus Villemoes , Russell King , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Thomas Gleixner , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Danilo Krummrich , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Heiko Stuebner , Lorenzo Pieralisi , Xu Yilun , Tom Rix , Moritz Fischer , Yicong Yang , Jonathan Cameron , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Bjorn Helgaas , Shuai Xue , Will Deacon , Jiucheng Xu , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jing Zhang , Xu Yang , Linu Cherian , Gowthami Thiagarajan , Ji Sheng Teoh , Khuong Dinh , Daniel Lezcano , Zhang Rui , Lukasz Luba , Yury Norov , Kees Cook , Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , Aboorva Devarajan , "Ritesh Harjani (IBM)" , Ilkka Koskinen , Besar Wicaksono , Ma Ke , Chengwen Feng , linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-perf-users@vger.kernel.org, linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-fpga@vger.kernel.org, linux-rdma@vger.kernel.org, nvdimm@lists.linux.dev, linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-cxl@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 13/16] perf: Use sysfs_emit() for cpumask show callbacks Message-ID: <20260529130619.12f24264@pumpkin> In-Reply-To: <7e980b99-1e4e-408b-8ebd-4d28116e7ad5@arm.com> References: <20260528183625.870813-1-ynorov@nvidia.com> <20260528183625.870813-14-ynorov@nvidia.com> <7e980b99-1e4e-408b-8ebd-4d28116e7ad5@arm.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 29 May 2026 12:05:08 +0100 Robin Murphy wrote: > On 2026-05-28 7:36 pm, Yury Norov wrote: > > These callbacks are sysfs show paths. > > > > Use sysfs_emit() and cpumask_pr_args() to emit the masks. > > > > This prepares for removing cpumap_print_to_pagebuf(). > > TBH, looking at this diff I think it only shows the value of having a > helper to abstract the boilerplate... > > I'm not sure I agree with the argument of removing something entirely > just because it may occasionally be misused, but could we at least have > something like: > > #define sysfs_emit_cpumask(buf, mask) \ > sysfs_emit((buf), "%*pbl\n", cpumask_pr_args(mask)) > > to save the mess in all the many places where the current > cpumap_print_to_pagebuf() usage _is_ entirely appropriate? That has the advantage of letting you change how it is done (again) without having to find all the callers. -- David > > Thansk, > Robin. > > > Signed-off-by: Yury Norov > > --- > > drivers/perf/alibaba_uncore_drw_pmu.c | 2 +- > > drivers/perf/amlogic/meson_ddr_pmu_core.c | 2 +- > > drivers/perf/arm-cci.c | 2 +- > > drivers/perf/arm-ccn.c | 2 +- > > drivers/perf/arm-cmn.c | 2 +- > > drivers/perf/arm-ni.c | 2 +- > > drivers/perf/arm_cspmu/arm_cspmu.c | 2 +- > > drivers/perf/arm_dmc620_pmu.c | 4 ++-- > > drivers/perf/arm_dsu_pmu.c | 2 +- > > drivers/perf/arm_pmu.c | 2 +- > > drivers/perf/arm_smmuv3_pmu.c | 2 +- > > drivers/perf/arm_spe_pmu.c | 2 +- > > drivers/perf/cxl_pmu.c | 2 +- > > drivers/perf/dwc_pcie_pmu.c | 2 +- > > drivers/perf/fsl_imx8_ddr_perf.c | 2 +- > > drivers/perf/fsl_imx9_ddr_perf.c | 2 +- > > drivers/perf/fujitsu_uncore_pmu.c | 2 +- > > drivers/perf/hisilicon/hisi_pcie_pmu.c | 2 +- > > drivers/perf/hisilicon/hisi_uncore_pmu.c | 2 +- > > drivers/perf/marvell_cn10k_ddr_pmu.c | 2 +- > > drivers/perf/marvell_cn10k_tad_pmu.c | 2 +- > > drivers/perf/marvell_pem_pmu.c | 2 +- > > drivers/perf/nvidia_t410_c2c_pmu.c | 2 +- > > drivers/perf/nvidia_t410_cmem_latency_pmu.c | 2 +- > > drivers/perf/qcom_l2_pmu.c | 2 +- > > drivers/perf/qcom_l3_pmu.c | 2 +- > > drivers/perf/starfive_starlink_pmu.c | 2 +- > > drivers/perf/thunderx2_pmu.c | 2 +- > > drivers/perf/xgene_pmu.c | 2 +- > > kernel/events/core.c | 2 +- > > 30 files changed, 31 insertions(+), 31 deletions(-) > > > > diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c > > index ac49d3b2dad6..74786a5dd6a2 100644 > > --- a/drivers/perf/alibaba_uncore_drw_pmu.c > > +++ b/drivers/perf/alibaba_uncore_drw_pmu.c > > @@ -221,7 +221,7 @@ static ssize_t ali_drw_pmu_cpumask_show(struct device *dev, > > { > > struct ali_drw_pmu *drw_pmu = to_ali_drw_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(drw_pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(drw_pmu->cpu))); > > } > > > > static struct device_attribute ali_drw_pmu_cpumask_attr = > > diff --git a/drivers/perf/amlogic/meson_ddr_pmu_core.c b/drivers/perf/amlogic/meson_ddr_pmu_core.c > > index c1e755c356a3..f614aa3434a5 100644 > > --- a/drivers/perf/amlogic/meson_ddr_pmu_core.c > > +++ b/drivers/perf/amlogic/meson_ddr_pmu_core.c > > @@ -191,7 +191,7 @@ static ssize_t meson_ddr_perf_cpumask_show(struct device *dev, > > { > > struct ddr_pmu *pmu = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu))); > > } > > > > static struct device_attribute meson_ddr_perf_cpumask_attr = > > diff --git a/drivers/perf/arm-cci.c b/drivers/perf/arm-cci.c > > index 1cc3214d6b6d..f0ef0a679e74 100644 > > --- a/drivers/perf/arm-cci.c > > +++ b/drivers/perf/arm-cci.c > > @@ -1351,7 +1351,7 @@ static ssize_t pmu_cpumask_attr_show(struct device *dev, > > struct pmu *pmu = dev_get_drvdata(dev); > > struct cci_pmu *cci_pmu = to_cci_pmu(pmu); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(cci_pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(cci_pmu->cpu))); > > } > > > > static struct device_attribute pmu_cpumask_attr = > > diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c > > index 8af3563fdf60..d5dcb4280434 100644 > > --- a/drivers/perf/arm-ccn.c > > +++ b/drivers/perf/arm-ccn.c > > @@ -538,7 +538,7 @@ static ssize_t arm_ccn_pmu_cpumask_show(struct device *dev, > > { > > struct arm_ccn *ccn = pmu_to_arm_ccn(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(ccn->dt.cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(ccn->dt.cpu))); > > } > > > > static struct device_attribute arm_ccn_pmu_cpumask_attr = > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > > index f5305c8fdca4..2187ba763b72 100644 > > --- a/drivers/perf/arm-cmn.c > > +++ b/drivers/perf/arm-cmn.c > > @@ -1326,7 +1326,7 @@ static ssize_t arm_cmn_cpumask_show(struct device *dev, > > { > > struct arm_cmn *cmn = to_cmn(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(cmn->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(cmn->cpu))); > > } > > > > static struct device_attribute arm_cmn_cpumask_attr = > > diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c > > index 66858c65215d..03a1c6bf9223 100644 > > --- a/drivers/perf/arm-ni.c > > +++ b/drivers/perf/arm-ni.c > > @@ -239,7 +239,7 @@ static ssize_t arm_ni_cpumask_show(struct device *dev, > > { > > struct arm_ni *ni = cd_to_ni(pmu_to_cd(dev_get_drvdata(dev))); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(ni->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(ni->cpu))); > > } > > > > static struct device_attribute arm_ni_cpumask_attr = > > diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c > > index 80fb314d5135..e6292021f653 100644 > > --- a/drivers/perf/arm_cspmu/arm_cspmu.c > > +++ b/drivers/perf/arm_cspmu/arm_cspmu.c > > @@ -305,7 +305,7 @@ static ssize_t arm_cspmu_cpumask_show(struct device *dev, > > default: > > return 0; > > } > > - return cpumap_print_to_pagebuf(true, buf, cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask)); > > } > > > > static struct attribute *arm_cspmu_cpumask_attrs[] = { > > diff --git a/drivers/perf/arm_dmc620_pmu.c b/drivers/perf/arm_dmc620_pmu.c > > index 4f6b196160f8..467147a05eec 100644 > > --- a/drivers/perf/arm_dmc620_pmu.c > > +++ b/drivers/perf/arm_dmc620_pmu.c > > @@ -237,8 +237,8 @@ static ssize_t dmc620_pmu_cpumask_show(struct device *dev, > > { > > struct dmc620_pmu *dmc620_pmu = to_dmc620_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, > > - cpumask_of(dmc620_pmu->irq->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", > > + cpumask_pr_args(cpumask_of(dmc620_pmu->irq->cpu))); > > } > > > > static struct device_attribute dmc620_pmu_cpumask_attr = > > diff --git a/drivers/perf/arm_dsu_pmu.c b/drivers/perf/arm_dsu_pmu.c > > index 32b0dd7c693b..bcbd19e075a5 100644 > > --- a/drivers/perf/arm_dsu_pmu.c > > +++ b/drivers/perf/arm_dsu_pmu.c > > @@ -157,7 +157,7 @@ static ssize_t dsu_pmu_cpumask_show(struct device *dev, > > default: > > return 0; > > } > > - return cpumap_print_to_pagebuf(true, buf, cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask)); > > } > > > > static struct attribute *dsu_pmu_format_attrs[] = { > > diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c > > index 939bcbd433aa..51ab6cc52ca0 100644 > > --- a/drivers/perf/arm_pmu.c > > +++ b/drivers/perf/arm_pmu.c > > @@ -570,7 +570,7 @@ static ssize_t cpus_show(struct device *dev, > > struct device_attribute *attr, char *buf) > > { > > struct arm_pmu *armpmu = to_arm_pmu(dev_get_drvdata(dev)); > > - return cpumap_print_to_pagebuf(true, buf, &armpmu->supported_cpus); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&armpmu->supported_cpus)); > > } > > > > static DEVICE_ATTR_RO(cpus); > > diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c > > index 621f02a7f43b..8ce34e6bb82b 100644 > > --- a/drivers/perf/arm_smmuv3_pmu.c > > +++ b/drivers/perf/arm_smmuv3_pmu.c > > @@ -537,7 +537,7 @@ static ssize_t smmu_pmu_cpumask_show(struct device *dev, > > { > > struct smmu_pmu *smmu_pmu = to_smmu_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(smmu_pmu->on_cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(smmu_pmu->on_cpu))); > > } > > > > static struct device_attribute smmu_pmu_cpumask_attr = > > diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c > > index dbd0da111639..9f786fd48cdd 100644 > > --- a/drivers/perf/arm_spe_pmu.c > > +++ b/drivers/perf/arm_spe_pmu.c > > @@ -343,7 +343,7 @@ static ssize_t cpumask_show(struct device *dev, > > { > > struct arm_spe_pmu *spe_pmu = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, &spe_pmu->supported_cpus); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&spe_pmu->supported_cpus)); > > } > > static DEVICE_ATTR_RO(cpumask); > > > > diff --git a/drivers/perf/cxl_pmu.c b/drivers/perf/cxl_pmu.c > > index 68a54d97d2a8..0735eb33f5f3 100644 > > --- a/drivers/perf/cxl_pmu.c > > +++ b/drivers/perf/cxl_pmu.c > > @@ -493,7 +493,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, > > { > > struct cxl_pmu_info *info = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(info->on_cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(info->on_cpu))); > > } > > static DEVICE_ATTR_RO(cpumask); > > > > diff --git a/drivers/perf/dwc_pcie_pmu.c b/drivers/perf/dwc_pcie_pmu.c > > index 5385401fa9cf..291e776d6f6a 100644 > > --- a/drivers/perf/dwc_pcie_pmu.c > > +++ b/drivers/perf/dwc_pcie_pmu.c > > @@ -117,7 +117,7 @@ static ssize_t cpumask_show(struct device *dev, > > { > > struct dwc_pcie_pmu *pcie_pmu = to_dwc_pcie_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pcie_pmu->on_cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pcie_pmu->on_cpu))); > > } > > static DEVICE_ATTR_RO(cpumask); > > > > diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c > > index bcdf5575d71c..3760ebe02674 100644 > > --- a/drivers/perf/fsl_imx8_ddr_perf.c > > +++ b/drivers/perf/fsl_imx8_ddr_perf.c > > @@ -237,7 +237,7 @@ static ssize_t ddr_perf_cpumask_show(struct device *dev, > > { > > struct ddr_pmu *pmu = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu))); > > } > > > > static struct device_attribute ddr_perf_cpumask_attr = > > diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c > > index 7050b48c0467..6fee5eb5087a 100644 > > --- a/drivers/perf/fsl_imx9_ddr_perf.c > > +++ b/drivers/perf/fsl_imx9_ddr_perf.c > > @@ -159,7 +159,7 @@ static ssize_t ddr_perf_cpumask_show(struct device *dev, > > { > > struct ddr_pmu *pmu = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu))); > > } > > > > static struct device_attribute ddr_perf_cpumask_attr = > > diff --git a/drivers/perf/fujitsu_uncore_pmu.c b/drivers/perf/fujitsu_uncore_pmu.c > > index c3c6f56474ad..a07877632d53 100644 > > --- a/drivers/perf/fujitsu_uncore_pmu.c > > +++ b/drivers/perf/fujitsu_uncore_pmu.c > > @@ -374,7 +374,7 @@ static ssize_t cpumask_show(struct device *dev, > > { > > struct uncore_pmu *uncorepmu = to_uncore_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(uncorepmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(uncorepmu->cpu))); > > } > > static DEVICE_ATTR_RO(cpumask); > > > > diff --git a/drivers/perf/hisilicon/hisi_pcie_pmu.c b/drivers/perf/hisilicon/hisi_pcie_pmu.c > > index c5394d007b61..0f55d871c67e 100644 > > --- a/drivers/perf/hisilicon/hisi_pcie_pmu.c > > +++ b/drivers/perf/hisilicon/hisi_pcie_pmu.c > > @@ -121,7 +121,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, c > > { > > struct hisi_pcie_pmu *pcie_pmu = to_pcie_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pcie_pmu->on_cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pcie_pmu->on_cpu))); > > } > > static DEVICE_ATTR_RO(cpumask); > > > > diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pmu.c > > index de71dcf11653..0ff2fdf4b3e2 100644 > > --- a/drivers/perf/hisilicon/hisi_uncore_pmu.c > > +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.c > > @@ -56,7 +56,7 @@ static ssize_t hisi_associated_cpus_sysfs_show(struct device *dev, > > { > > struct hisi_pmu *hisi_pmu = to_hisi_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, &hisi_pmu->associated_cpus); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&hisi_pmu->associated_cpus)); > > } > > static DEVICE_ATTR(associated_cpus, 0444, hisi_associated_cpus_sysfs_show, NULL); > > > > diff --git a/drivers/perf/marvell_cn10k_ddr_pmu.c b/drivers/perf/marvell_cn10k_ddr_pmu.c > > index 72ac17efd846..8681e8715cb3 100644 > > --- a/drivers/perf/marvell_cn10k_ddr_pmu.c > > +++ b/drivers/perf/marvell_cn10k_ddr_pmu.c > > @@ -364,7 +364,7 @@ static ssize_t cn10k_ddr_perf_cpumask_show(struct device *dev, > > { > > struct cn10k_ddr_pmu *pmu = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu))); > > } > > > > static struct device_attribute cn10k_ddr_perf_cpumask_attr = > > diff --git a/drivers/perf/marvell_cn10k_tad_pmu.c b/drivers/perf/marvell_cn10k_tad_pmu.c > > index 51ccb0befa05..54909d0031b7 100644 > > --- a/drivers/perf/marvell_cn10k_tad_pmu.c > > +++ b/drivers/perf/marvell_cn10k_tad_pmu.c > > @@ -258,7 +258,7 @@ static ssize_t tad_pmu_cpumask_show(struct device *dev, > > { > > struct tad_pmu *tad_pmu = to_tad_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(tad_pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(tad_pmu->cpu))); > > } > > > > static DEVICE_ATTR(cpumask, 0444, tad_pmu_cpumask_show, NULL); > > diff --git a/drivers/perf/marvell_pem_pmu.c b/drivers/perf/marvell_pem_pmu.c > > index 29fbcd1848e4..cf1d8cdb1318 100644 > > --- a/drivers/perf/marvell_pem_pmu.c > > +++ b/drivers/perf/marvell_pem_pmu.c > > @@ -164,7 +164,7 @@ static ssize_t pem_perf_cpumask_show(struct device *dev, > > { > > struct pem_pmu *pmu = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu))); > > } > > > > static struct device_attribute pem_perf_cpumask_attr = > > diff --git a/drivers/perf/nvidia_t410_c2c_pmu.c b/drivers/perf/nvidia_t410_c2c_pmu.c > > index 411987153ff3..bff875f4f625 100644 > > --- a/drivers/perf/nvidia_t410_c2c_pmu.c > > +++ b/drivers/perf/nvidia_t410_c2c_pmu.c > > @@ -658,7 +658,7 @@ static ssize_t nv_c2c_pmu_cpumask_show(struct device *dev, > > default: > > return 0; > > } > > - return cpumap_print_to_pagebuf(true, buf, cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask)); > > } > > > > #define NV_C2C_PMU_CPUMASK_ATTR(_name, _config) \ > > diff --git a/drivers/perf/nvidia_t410_cmem_latency_pmu.c b/drivers/perf/nvidia_t410_cmem_latency_pmu.c > > index acb8f5571522..6c8e41598ec1 100644 > > --- a/drivers/perf/nvidia_t410_cmem_latency_pmu.c > > +++ b/drivers/perf/nvidia_t410_cmem_latency_pmu.c > > @@ -501,7 +501,7 @@ static ssize_t cmem_lat_pmu_cpumask_show(struct device *dev, > > default: > > return 0; > > } > > - return cpumap_print_to_pagebuf(true, buf, cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask)); > > } > > > > #define NV_PMU_CPUMASK_ATTR(_name, _config) \ > > diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c > > index ea8c85729937..c0c522b10b72 100644 > > --- a/drivers/perf/qcom_l2_pmu.c > > +++ b/drivers/perf/qcom_l2_pmu.c > > @@ -638,7 +638,7 @@ static ssize_t l2_cache_pmu_cpumask_show(struct device *dev, > > { > > struct l2cache_pmu *l2cache_pmu = to_l2cache_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, &l2cache_pmu->cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&l2cache_pmu->cpumask)); > > } > > > > static struct device_attribute l2_cache_pmu_cpumask_attr = > > diff --git a/drivers/perf/qcom_l3_pmu.c b/drivers/perf/qcom_l3_pmu.c > > index 66e6cabd6fff..c8d259dd1f80 100644 > > --- a/drivers/perf/qcom_l3_pmu.c > > +++ b/drivers/perf/qcom_l3_pmu.c > > @@ -663,7 +663,7 @@ static ssize_t cpumask_show(struct device *dev, > > { > > struct l3cache_pmu *l3pmu = to_l3cache_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, &l3pmu->cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&l3pmu->cpumask)); > > } > > > > static DEVICE_ATTR_RO(cpumask); > > diff --git a/drivers/perf/starfive_starlink_pmu.c b/drivers/perf/starfive_starlink_pmu.c > > index 964897c2baa9..222a0a34e211 100644 > > --- a/drivers/perf/starfive_starlink_pmu.c > > +++ b/drivers/perf/starfive_starlink_pmu.c > > @@ -131,7 +131,7 @@ cpumask_show(struct device *dev, struct device_attribute *attr, char *buf) > > { > > struct starlink_pmu *starlink_pmu = to_starlink_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, &starlink_pmu->cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&starlink_pmu->cpumask)); > > } > > > > static DEVICE_ATTR_RO(cpumask); > > diff --git a/drivers/perf/thunderx2_pmu.c b/drivers/perf/thunderx2_pmu.c > > index 6ed4707bd6bb..a69c02d2d874 100644 > > --- a/drivers/perf/thunderx2_pmu.c > > +++ b/drivers/perf/thunderx2_pmu.c > > @@ -254,7 +254,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, > > struct tx2_uncore_pmu *tx2_pmu; > > > > tx2_pmu = pmu_to_tx2_pmu(dev_get_drvdata(dev)); > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(tx2_pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(tx2_pmu->cpu))); > > } > > static DEVICE_ATTR_RO(cpumask); > > > > diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c > > index 33b5497bdc06..e9e4871db08d 100644 > > --- a/drivers/perf/xgene_pmu.c > > +++ b/drivers/perf/xgene_pmu.c > > @@ -595,7 +595,7 @@ static ssize_t cpumask_show(struct device *dev, > > { > > struct xgene_pmu_dev *pmu_dev = to_pmu_dev(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, &pmu_dev->parent->cpu); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&pmu_dev->parent->cpu)); > > } > > > > static DEVICE_ATTR_RO(cpumask); > > diff --git a/kernel/events/core.c b/kernel/events/core.c > > index 7935d5663944..61689d348abd 100644 > > --- a/kernel/events/core.c > > +++ b/kernel/events/core.c > > @@ -12657,7 +12657,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, > > struct cpumask *mask = perf_scope_cpumask(pmu->scope); > > > > if (mask) > > - return cpumap_print_to_pagebuf(true, buf, mask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(mask)); > > return 0; > > } > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C223ECD6E43 for ; Fri, 29 May 2026 12:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1krPW7aOU83ZVaaWlcpGLxWksVAhuk/9p49zC3uFBAE=; b=RhjucOSLSta+DV d5YvcGic/Ym2uXJUe2te5mMs+x7Krn6Ft6ylq/VH5dB9mlMc12lhri2yrrHYpDUNzTZSGEr5Wg8g7 b186GUd73XlrXp93aGE+XTy1pGjPUB5T5iOrksKY+CgJAMiyzWhzO7qTpZGG3jF0EyqdA2gtob4vn sIGV+TBrcOKHd1+RbJHK2Bd6ZFQ9eqaAXsd+GEKsVcFB4U1WyWJqyvJxdwdALc2vHQMVSF/WRN6nc qhTij9a/rlG+Brd0Nu6K0dquzyHd1qUgumVp/XG+UEOWN/GevMg6hgryhCCYnAyGiRgO9Tf3TWvl3 xl+2JnOU7EO47UFps8UA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wSvyw-00000007Kkm-3RJM; Fri, 29 May 2026 12:06:30 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wSvyt-00000007KjL-484r for linux-amlogic@lists.infradead.org; Fri, 29 May 2026 12:06:29 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-48a563e4ef7so98192275e9.0 for ; Fri, 29 May 2026 05:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780056386; x=1780661186; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=72jz4VASspyNfZwaO2ZoEBYiy1qSN0s6Nl9KPx8bbj4=; b=ZnokqwvJIqIYuxNd0QC8U4WnoreIkalu3nyeZ14fp7BxbynouJL4v030F9g2fE6TPx kFY1yYAAQ1tmuqTaDFaPkbnIHx5UVL4+2ZAeQbi8PrWAbNQXP498RoGoBH5jNJQJwwu4 k6ZNlZ+6bs6jNENSchWnnH6gtNF94CWkxBXXGiRkFwLE73qayhSW0VxNPktmQqt19ugO k27UoK5sZlZxo0HHSmIMWh3uWNiu7M2FQipvBBomkUW4VKfmAKi3YSBHXV6kRjz5O+Ug a0NES4Xe0ncTg6zgAkPlrrfE9nwVPum66bHrfrvJFNPbb2UQySthAH48Y8ugdnfWafKZ WoaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780056386; x=1780661186; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=72jz4VASspyNfZwaO2ZoEBYiy1qSN0s6Nl9KPx8bbj4=; b=TKq2dYyJQsiudI3woCZINjkhFVcNER0QWNM+YLXZ8Oo11BD29koQ/fzUzrbN0KOuHX BBiIC9Qg/O8ivC2p7Y78ekG3qSzPvAro41LrPVOohpQT8Nqn279KWRm1by6m+PqZHVXU nlvGoy47r/kxsRkYR90HB0Cldw8lnjvI0LPtwt3AHYXh8hYfpnRuRFSKabV6JIAsycQs yXFE2qn9l9JhZI7HG0OxWm4DTcw0NOSvd51ppCqq0UMzFqKPBzttsqJsKkFnq+j632PP hueOuqkMsak/JZUvU3eql+VZAHPHZmDRWKz15vsumED529YnQ+SCskgdlGEzeNOVShuG BUQg== X-Forwarded-Encrypted: i=1; AFNElJ8s59pvt+qRnW/0HhUpFwU10OPhF0HpA+HtMqk9pe+0W+V+95PEglkC2DlPXeMRsRIjdCIAUbczbny2UpIv@lists.infradead.org X-Gm-Message-State: AOJu0Yydu2UYB/ly9CmwdEJ2hXLiFloMF+Q3cjF8XPxxtTQurP5rfbGe tf4D3fWeE1c+A2IjaxV4qBiHEqV/1BAJF5HgD3hGXzRQdCv9lt4x2C1n X-Gm-Gg: Acq92OE0cLGkK6gnGHqoNxfScP0sGggVGwov3oyK0tB00J/b2kbe1YXu4BOaFdBAL1o OWJxSTktJzk6g7NggDA7o8rkUZeGtmuNe/I3M581VRrcxhbhOjCVPY6TUoiXdin9O0fXNGGbMJc eiZrwccGeMomXBAVtSnHnRjFlK6iH4QPkE/eng16iuc9xWWDwk6l6/ujdYcRfU7zi8UTaeHINeu WoWNpi5ao7fBichzCX3wScB9ee/KsBMt4ZPtIoJ2R1ynHPomhYrctOqCgLIZKOzo4c5mqKA/gL4 W32q+bTH0Yf08GkLCrggNppFuOu1O9YoC/L3DAWU4lC3tteVSNC40tVKcpeBl6YBAGvH/hOOiaT DlusL2vJkDp2Vk7NXIK0zEoDtvdovCMTkupLDkK+MbfCfwI8mHdBn7GGWdEY9k+p7oM/HdZ+Kf1 f7cYX+GO4BlNbtc3Aj5BYwlCS+Z/VXqjLQaRge8UO9ayd1P8fCOJ1W5XSkIMYrbJTeOJEVZkA= X-Received: by 2002:a05:600c:1f93:b0:48f:e230:8cad with SMTP id 5b1f17b1804b1-4909ca8958dmr45994995e9.33.1780056385169; Fri, 29 May 2026 05:06:25 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909cab7b00sm40374125e9.14.2026.05.29.05.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 05:06:24 -0700 (PDT) Date: Fri, 29 May 2026 13:06:19 +0100 From: David Laight To: Robin Murphy Cc: Yury Norov , Andrew Morton , Rasmus Villemoes , Russell King , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Thomas Gleixner , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Danilo Krummrich , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Heiko Stuebner , Lorenzo Pieralisi , Xu Yilun , Tom Rix , Moritz Fischer , Yicong Yang , Jonathan Cameron , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Bjorn Helgaas , Shuai Xue , Will Deacon , Jiucheng Xu , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jing Zhang , Xu Yang , Linu Cherian , Gowthami Thiagarajan , Ji Sheng Teoh , Khuong Dinh , Daniel Lezcano , Zhang Rui , Lukasz Luba , Yury Norov , Kees Cook , Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , Aboorva Devarajan , "Ritesh Harjani (IBM)" , Ilkka Koskinen , Besar Wicaksono , Ma Ke , Chengwen Feng , linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-perf-users@vger.kernel.org, linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-fpga@vger.kernel.org, linux-rdma@vger.kernel.org, nvdimm@lists.linux.dev, linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-cxl@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 13/16] perf: Use sysfs_emit() for cpumask show callbacks Message-ID: <20260529130619.12f24264@pumpkin> In-Reply-To: <7e980b99-1e4e-408b-8ebd-4d28116e7ad5@arm.com> References: <20260528183625.870813-1-ynorov@nvidia.com> <20260528183625.870813-14-ynorov@nvidia.com> <7e980b99-1e4e-408b-8ebd-4d28116e7ad5@arm.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260529_050628_205028_B9F2F03F X-CRM114-Status: GOOD ( 25.74 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri, 29 May 2026 12:05:08 +0100 Robin Murphy wrote: > On 2026-05-28 7:36 pm, Yury Norov wrote: > > These callbacks are sysfs show paths. > > > > Use sysfs_emit() and cpumask_pr_args() to emit the masks. > > > > This prepares for removing cpumap_print_to_pagebuf(). > > TBH, looking at this diff I think it only shows the value of having a > helper to abstract the boilerplate... > > I'm not sure I agree with the argument of removing something entirely > just because it may occasionally be misused, but could we at least have > something like: > > #define sysfs_emit_cpumask(buf, mask) \ > sysfs_emit((buf), "%*pbl\n", cpumask_pr_args(mask)) > > to save the mess in all the many places where the current > cpumap_print_to_pagebuf() usage _is_ entirely appropriate? That has the advantage of letting you change how it is done (again) without having to find all the callers. -- David > > Thansk, > Robin. > > > Signed-off-by: Yury Norov > > --- > > drivers/perf/alibaba_uncore_drw_pmu.c | 2 +- > > drivers/perf/amlogic/meson_ddr_pmu_core.c | 2 +- > > drivers/perf/arm-cci.c | 2 +- > > drivers/perf/arm-ccn.c | 2 +- > > drivers/perf/arm-cmn.c | 2 +- > > drivers/perf/arm-ni.c | 2 +- > > drivers/perf/arm_cspmu/arm_cspmu.c | 2 +- > > drivers/perf/arm_dmc620_pmu.c | 4 ++-- > > drivers/perf/arm_dsu_pmu.c | 2 +- > > drivers/perf/arm_pmu.c | 2 +- > > drivers/perf/arm_smmuv3_pmu.c | 2 +- > > drivers/perf/arm_spe_pmu.c | 2 +- > > drivers/perf/cxl_pmu.c | 2 +- > > drivers/perf/dwc_pcie_pmu.c | 2 +- > > drivers/perf/fsl_imx8_ddr_perf.c | 2 +- > > drivers/perf/fsl_imx9_ddr_perf.c | 2 +- > > drivers/perf/fujitsu_uncore_pmu.c | 2 +- > > drivers/perf/hisilicon/hisi_pcie_pmu.c | 2 +- > > drivers/perf/hisilicon/hisi_uncore_pmu.c | 2 +- > > drivers/perf/marvell_cn10k_ddr_pmu.c | 2 +- > > drivers/perf/marvell_cn10k_tad_pmu.c | 2 +- > > drivers/perf/marvell_pem_pmu.c | 2 +- > > drivers/perf/nvidia_t410_c2c_pmu.c | 2 +- > > drivers/perf/nvidia_t410_cmem_latency_pmu.c | 2 +- > > drivers/perf/qcom_l2_pmu.c | 2 +- > > drivers/perf/qcom_l3_pmu.c | 2 +- > > drivers/perf/starfive_starlink_pmu.c | 2 +- > > drivers/perf/thunderx2_pmu.c | 2 +- > > drivers/perf/xgene_pmu.c | 2 +- > > kernel/events/core.c | 2 +- > > 30 files changed, 31 insertions(+), 31 deletions(-) > > > > diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c > > index ac49d3b2dad6..74786a5dd6a2 100644 > > --- a/drivers/perf/alibaba_uncore_drw_pmu.c > > +++ b/drivers/perf/alibaba_uncore_drw_pmu.c > > @@ -221,7 +221,7 @@ static ssize_t ali_drw_pmu_cpumask_show(struct device *dev, > > { > > struct ali_drw_pmu *drw_pmu = to_ali_drw_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(drw_pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(drw_pmu->cpu))); > > } > > > > static struct device_attribute ali_drw_pmu_cpumask_attr = > > diff --git a/drivers/perf/amlogic/meson_ddr_pmu_core.c b/drivers/perf/amlogic/meson_ddr_pmu_core.c > > index c1e755c356a3..f614aa3434a5 100644 > > --- a/drivers/perf/amlogic/meson_ddr_pmu_core.c > > +++ b/drivers/perf/amlogic/meson_ddr_pmu_core.c > > @@ -191,7 +191,7 @@ static ssize_t meson_ddr_perf_cpumask_show(struct device *dev, > > { > > struct ddr_pmu *pmu = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu))); > > } > > > > static struct device_attribute meson_ddr_perf_cpumask_attr = > > diff --git a/drivers/perf/arm-cci.c b/drivers/perf/arm-cci.c > > index 1cc3214d6b6d..f0ef0a679e74 100644 > > --- a/drivers/perf/arm-cci.c > > +++ b/drivers/perf/arm-cci.c > > @@ -1351,7 +1351,7 @@ static ssize_t pmu_cpumask_attr_show(struct device *dev, > > struct pmu *pmu = dev_get_drvdata(dev); > > struct cci_pmu *cci_pmu = to_cci_pmu(pmu); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(cci_pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(cci_pmu->cpu))); > > } > > > > static struct device_attribute pmu_cpumask_attr = > > diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c > > index 8af3563fdf60..d5dcb4280434 100644 > > --- a/drivers/perf/arm-ccn.c > > +++ b/drivers/perf/arm-ccn.c > > @@ -538,7 +538,7 @@ static ssize_t arm_ccn_pmu_cpumask_show(struct device *dev, > > { > > struct arm_ccn *ccn = pmu_to_arm_ccn(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(ccn->dt.cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(ccn->dt.cpu))); > > } > > > > static struct device_attribute arm_ccn_pmu_cpumask_attr = > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > > index f5305c8fdca4..2187ba763b72 100644 > > --- a/drivers/perf/arm-cmn.c > > +++ b/drivers/perf/arm-cmn.c > > @@ -1326,7 +1326,7 @@ static ssize_t arm_cmn_cpumask_show(struct device *dev, > > { > > struct arm_cmn *cmn = to_cmn(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(cmn->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(cmn->cpu))); > > } > > > > static struct device_attribute arm_cmn_cpumask_attr = > > diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c > > index 66858c65215d..03a1c6bf9223 100644 > > --- a/drivers/perf/arm-ni.c > > +++ b/drivers/perf/arm-ni.c > > @@ -239,7 +239,7 @@ static ssize_t arm_ni_cpumask_show(struct device *dev, > > { > > struct arm_ni *ni = cd_to_ni(pmu_to_cd(dev_get_drvdata(dev))); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(ni->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(ni->cpu))); > > } > > > > static struct device_attribute arm_ni_cpumask_attr = > > diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c > > index 80fb314d5135..e6292021f653 100644 > > --- a/drivers/perf/arm_cspmu/arm_cspmu.c > > +++ b/drivers/perf/arm_cspmu/arm_cspmu.c > > @@ -305,7 +305,7 @@ static ssize_t arm_cspmu_cpumask_show(struct device *dev, > > default: > > return 0; > > } > > - return cpumap_print_to_pagebuf(true, buf, cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask)); > > } > > > > static struct attribute *arm_cspmu_cpumask_attrs[] = { > > diff --git a/drivers/perf/arm_dmc620_pmu.c b/drivers/perf/arm_dmc620_pmu.c > > index 4f6b196160f8..467147a05eec 100644 > > --- a/drivers/perf/arm_dmc620_pmu.c > > +++ b/drivers/perf/arm_dmc620_pmu.c > > @@ -237,8 +237,8 @@ static ssize_t dmc620_pmu_cpumask_show(struct device *dev, > > { > > struct dmc620_pmu *dmc620_pmu = to_dmc620_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, > > - cpumask_of(dmc620_pmu->irq->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", > > + cpumask_pr_args(cpumask_of(dmc620_pmu->irq->cpu))); > > } > > > > static struct device_attribute dmc620_pmu_cpumask_attr = > > diff --git a/drivers/perf/arm_dsu_pmu.c b/drivers/perf/arm_dsu_pmu.c > > index 32b0dd7c693b..bcbd19e075a5 100644 > > --- a/drivers/perf/arm_dsu_pmu.c > > +++ b/drivers/perf/arm_dsu_pmu.c > > @@ -157,7 +157,7 @@ static ssize_t dsu_pmu_cpumask_show(struct device *dev, > > default: > > return 0; > > } > > - return cpumap_print_to_pagebuf(true, buf, cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask)); > > } > > > > static struct attribute *dsu_pmu_format_attrs[] = { > > diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c > > index 939bcbd433aa..51ab6cc52ca0 100644 > > --- a/drivers/perf/arm_pmu.c > > +++ b/drivers/perf/arm_pmu.c > > @@ -570,7 +570,7 @@ static ssize_t cpus_show(struct device *dev, > > struct device_attribute *attr, char *buf) > > { > > struct arm_pmu *armpmu = to_arm_pmu(dev_get_drvdata(dev)); > > - return cpumap_print_to_pagebuf(true, buf, &armpmu->supported_cpus); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&armpmu->supported_cpus)); > > } > > > > static DEVICE_ATTR_RO(cpus); > > diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c > > index 621f02a7f43b..8ce34e6bb82b 100644 > > --- a/drivers/perf/arm_smmuv3_pmu.c > > +++ b/drivers/perf/arm_smmuv3_pmu.c > > @@ -537,7 +537,7 @@ static ssize_t smmu_pmu_cpumask_show(struct device *dev, > > { > > struct smmu_pmu *smmu_pmu = to_smmu_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(smmu_pmu->on_cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(smmu_pmu->on_cpu))); > > } > > > > static struct device_attribute smmu_pmu_cpumask_attr = > > diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c > > index dbd0da111639..9f786fd48cdd 100644 > > --- a/drivers/perf/arm_spe_pmu.c > > +++ b/drivers/perf/arm_spe_pmu.c > > @@ -343,7 +343,7 @@ static ssize_t cpumask_show(struct device *dev, > > { > > struct arm_spe_pmu *spe_pmu = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, &spe_pmu->supported_cpus); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&spe_pmu->supported_cpus)); > > } > > static DEVICE_ATTR_RO(cpumask); > > > > diff --git a/drivers/perf/cxl_pmu.c b/drivers/perf/cxl_pmu.c > > index 68a54d97d2a8..0735eb33f5f3 100644 > > --- a/drivers/perf/cxl_pmu.c > > +++ b/drivers/perf/cxl_pmu.c > > @@ -493,7 +493,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, > > { > > struct cxl_pmu_info *info = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(info->on_cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(info->on_cpu))); > > } > > static DEVICE_ATTR_RO(cpumask); > > > > diff --git a/drivers/perf/dwc_pcie_pmu.c b/drivers/perf/dwc_pcie_pmu.c > > index 5385401fa9cf..291e776d6f6a 100644 > > --- a/drivers/perf/dwc_pcie_pmu.c > > +++ b/drivers/perf/dwc_pcie_pmu.c > > @@ -117,7 +117,7 @@ static ssize_t cpumask_show(struct device *dev, > > { > > struct dwc_pcie_pmu *pcie_pmu = to_dwc_pcie_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pcie_pmu->on_cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pcie_pmu->on_cpu))); > > } > > static DEVICE_ATTR_RO(cpumask); > > > > diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c > > index bcdf5575d71c..3760ebe02674 100644 > > --- a/drivers/perf/fsl_imx8_ddr_perf.c > > +++ b/drivers/perf/fsl_imx8_ddr_perf.c > > @@ -237,7 +237,7 @@ static ssize_t ddr_perf_cpumask_show(struct device *dev, > > { > > struct ddr_pmu *pmu = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu))); > > } > > > > static struct device_attribute ddr_perf_cpumask_attr = > > diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c > > index 7050b48c0467..6fee5eb5087a 100644 > > --- a/drivers/perf/fsl_imx9_ddr_perf.c > > +++ b/drivers/perf/fsl_imx9_ddr_perf.c > > @@ -159,7 +159,7 @@ static ssize_t ddr_perf_cpumask_show(struct device *dev, > > { > > struct ddr_pmu *pmu = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu))); > > } > > > > static struct device_attribute ddr_perf_cpumask_attr = > > diff --git a/drivers/perf/fujitsu_uncore_pmu.c b/drivers/perf/fujitsu_uncore_pmu.c > > index c3c6f56474ad..a07877632d53 100644 > > --- a/drivers/perf/fujitsu_uncore_pmu.c > > +++ b/drivers/perf/fujitsu_uncore_pmu.c > > @@ -374,7 +374,7 @@ static ssize_t cpumask_show(struct device *dev, > > { > > struct uncore_pmu *uncorepmu = to_uncore_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(uncorepmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(uncorepmu->cpu))); > > } > > static DEVICE_ATTR_RO(cpumask); > > > > diff --git a/drivers/perf/hisilicon/hisi_pcie_pmu.c b/drivers/perf/hisilicon/hisi_pcie_pmu.c > > index c5394d007b61..0f55d871c67e 100644 > > --- a/drivers/perf/hisilicon/hisi_pcie_pmu.c > > +++ b/drivers/perf/hisilicon/hisi_pcie_pmu.c > > @@ -121,7 +121,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, c > > { > > struct hisi_pcie_pmu *pcie_pmu = to_pcie_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pcie_pmu->on_cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pcie_pmu->on_cpu))); > > } > > static DEVICE_ATTR_RO(cpumask); > > > > diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pmu.c > > index de71dcf11653..0ff2fdf4b3e2 100644 > > --- a/drivers/perf/hisilicon/hisi_uncore_pmu.c > > +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.c > > @@ -56,7 +56,7 @@ static ssize_t hisi_associated_cpus_sysfs_show(struct device *dev, > > { > > struct hisi_pmu *hisi_pmu = to_hisi_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, &hisi_pmu->associated_cpus); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&hisi_pmu->associated_cpus)); > > } > > static DEVICE_ATTR(associated_cpus, 0444, hisi_associated_cpus_sysfs_show, NULL); > > > > diff --git a/drivers/perf/marvell_cn10k_ddr_pmu.c b/drivers/perf/marvell_cn10k_ddr_pmu.c > > index 72ac17efd846..8681e8715cb3 100644 > > --- a/drivers/perf/marvell_cn10k_ddr_pmu.c > > +++ b/drivers/perf/marvell_cn10k_ddr_pmu.c > > @@ -364,7 +364,7 @@ static ssize_t cn10k_ddr_perf_cpumask_show(struct device *dev, > > { > > struct cn10k_ddr_pmu *pmu = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu))); > > } > > > > static struct device_attribute cn10k_ddr_perf_cpumask_attr = > > diff --git a/drivers/perf/marvell_cn10k_tad_pmu.c b/drivers/perf/marvell_cn10k_tad_pmu.c > > index 51ccb0befa05..54909d0031b7 100644 > > --- a/drivers/perf/marvell_cn10k_tad_pmu.c > > +++ b/drivers/perf/marvell_cn10k_tad_pmu.c > > @@ -258,7 +258,7 @@ static ssize_t tad_pmu_cpumask_show(struct device *dev, > > { > > struct tad_pmu *tad_pmu = to_tad_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(tad_pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(tad_pmu->cpu))); > > } > > > > static DEVICE_ATTR(cpumask, 0444, tad_pmu_cpumask_show, NULL); > > diff --git a/drivers/perf/marvell_pem_pmu.c b/drivers/perf/marvell_pem_pmu.c > > index 29fbcd1848e4..cf1d8cdb1318 100644 > > --- a/drivers/perf/marvell_pem_pmu.c > > +++ b/drivers/perf/marvell_pem_pmu.c > > @@ -164,7 +164,7 @@ static ssize_t pem_perf_cpumask_show(struct device *dev, > > { > > struct pem_pmu *pmu = dev_get_drvdata(dev); > > > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(pmu->cpu))); > > } > > > > static struct device_attribute pem_perf_cpumask_attr = > > diff --git a/drivers/perf/nvidia_t410_c2c_pmu.c b/drivers/perf/nvidia_t410_c2c_pmu.c > > index 411987153ff3..bff875f4f625 100644 > > --- a/drivers/perf/nvidia_t410_c2c_pmu.c > > +++ b/drivers/perf/nvidia_t410_c2c_pmu.c > > @@ -658,7 +658,7 @@ static ssize_t nv_c2c_pmu_cpumask_show(struct device *dev, > > default: > > return 0; > > } > > - return cpumap_print_to_pagebuf(true, buf, cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask)); > > } > > > > #define NV_C2C_PMU_CPUMASK_ATTR(_name, _config) \ > > diff --git a/drivers/perf/nvidia_t410_cmem_latency_pmu.c b/drivers/perf/nvidia_t410_cmem_latency_pmu.c > > index acb8f5571522..6c8e41598ec1 100644 > > --- a/drivers/perf/nvidia_t410_cmem_latency_pmu.c > > +++ b/drivers/perf/nvidia_t410_cmem_latency_pmu.c > > @@ -501,7 +501,7 @@ static ssize_t cmem_lat_pmu_cpumask_show(struct device *dev, > > default: > > return 0; > > } > > - return cpumap_print_to_pagebuf(true, buf, cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask)); > > } > > > > #define NV_PMU_CPUMASK_ATTR(_name, _config) \ > > diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c > > index ea8c85729937..c0c522b10b72 100644 > > --- a/drivers/perf/qcom_l2_pmu.c > > +++ b/drivers/perf/qcom_l2_pmu.c > > @@ -638,7 +638,7 @@ static ssize_t l2_cache_pmu_cpumask_show(struct device *dev, > > { > > struct l2cache_pmu *l2cache_pmu = to_l2cache_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, &l2cache_pmu->cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&l2cache_pmu->cpumask)); > > } > > > > static struct device_attribute l2_cache_pmu_cpumask_attr = > > diff --git a/drivers/perf/qcom_l3_pmu.c b/drivers/perf/qcom_l3_pmu.c > > index 66e6cabd6fff..c8d259dd1f80 100644 > > --- a/drivers/perf/qcom_l3_pmu.c > > +++ b/drivers/perf/qcom_l3_pmu.c > > @@ -663,7 +663,7 @@ static ssize_t cpumask_show(struct device *dev, > > { > > struct l3cache_pmu *l3pmu = to_l3cache_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, &l3pmu->cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&l3pmu->cpumask)); > > } > > > > static DEVICE_ATTR_RO(cpumask); > > diff --git a/drivers/perf/starfive_starlink_pmu.c b/drivers/perf/starfive_starlink_pmu.c > > index 964897c2baa9..222a0a34e211 100644 > > --- a/drivers/perf/starfive_starlink_pmu.c > > +++ b/drivers/perf/starfive_starlink_pmu.c > > @@ -131,7 +131,7 @@ cpumask_show(struct device *dev, struct device_attribute *attr, char *buf) > > { > > struct starlink_pmu *starlink_pmu = to_starlink_pmu(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, &starlink_pmu->cpumask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&starlink_pmu->cpumask)); > > } > > > > static DEVICE_ATTR_RO(cpumask); > > diff --git a/drivers/perf/thunderx2_pmu.c b/drivers/perf/thunderx2_pmu.c > > index 6ed4707bd6bb..a69c02d2d874 100644 > > --- a/drivers/perf/thunderx2_pmu.c > > +++ b/drivers/perf/thunderx2_pmu.c > > @@ -254,7 +254,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, > > struct tx2_uncore_pmu *tx2_pmu; > > > > tx2_pmu = pmu_to_tx2_pmu(dev_get_drvdata(dev)); > > - return cpumap_print_to_pagebuf(true, buf, cpumask_of(tx2_pmu->cpu)); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(cpumask_of(tx2_pmu->cpu))); > > } > > static DEVICE_ATTR_RO(cpumask); > > > > diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c > > index 33b5497bdc06..e9e4871db08d 100644 > > --- a/drivers/perf/xgene_pmu.c > > +++ b/drivers/perf/xgene_pmu.c > > @@ -595,7 +595,7 @@ static ssize_t cpumask_show(struct device *dev, > > { > > struct xgene_pmu_dev *pmu_dev = to_pmu_dev(dev_get_drvdata(dev)); > > > > - return cpumap_print_to_pagebuf(true, buf, &pmu_dev->parent->cpu); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&pmu_dev->parent->cpu)); > > } > > > > static DEVICE_ATTR_RO(cpumask); > > diff --git a/kernel/events/core.c b/kernel/events/core.c > > index 7935d5663944..61689d348abd 100644 > > --- a/kernel/events/core.c > > +++ b/kernel/events/core.c > > @@ -12657,7 +12657,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, > > struct cpumask *mask = perf_scope_cpumask(pmu->scope); > > > > if (mask) > > - return cpumap_print_to_pagebuf(true, buf, mask); > > + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(mask)); > > return 0; > > } > > > > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic