Re: [PATCH v2 2/2] arm64: dts: qcom: kaanapali: add reboot-mode support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The newly added `reboot-mode` child nodes under `&psci` lack a `compatible` property, preventing the intended driver from probing.
- [Low] Adding a `reboot-mode` child node to the `psci` node causes a DT schema validation failure.
--

commit 079cf5018c165ba61e6369f973cc92a5ec2da280
Author: Xin Liu <xin.liu@oss.qualcomm.com>

arm64: dts: qcom: kaanapali: add reboot-mode support

This commit adds PSCI SYSTEM_RESET2 reboot-modes for the kaanapali-mtp
and kaanapali-qrd boards. It defines the bootloader and edl modes for
use by the psci-reboot-mode driver.

> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
[ ... ]
> @@ -1321,3 +1321,10 @@ &ufs_mem_phy {
>  
>  	status = "okay";
>  };
> +
> +&psci {
> +	reboot-mode {

[Severity: Low]
Will this new child node cause a device tree schema validation failure?

The core PSCI schema (Documentation/devicetree/bindings/arm/psci.yaml)
enforces additionalProperties: false at the top level and does not currently
document or allow a reboot-mode child node.

The binding schema may need to be updated to explicitly allow the
reboot-mode node to avoid errors during dtbs_check.

[Severity: Medium]
Does this node need a compatible string to successfully probe the driver?

Standard device tree matching via of_platform_populate() requires a
compatible property to bind a device node to a platform driver.

Without a compatible property (such as compatible = "qcom,psci-reboot-mode";),
the driver core will likely ignore these nodes, leaving the bootloader and edl
reboot functionality inoperative.

> +		mode-bootloader = <0x80010001 0x2>;
> +		mode-edl = <0x80000000 0x1>;
> +	};
> +};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-psci_sys_reset-dt-changes-for-pakala-v2-0-1964ebf1924c@oss.qualcomm.com?part=2