From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78DD8CD6E49 for ; Fri, 29 May 2026 16:02:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D05061121BB; Fri, 29 May 2026 16:02:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=dolcini.it header.i=@dolcini.it header.b="MfjVvoT2"; dkim-atps=neutral Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8CD11121BB for ; Fri, 29 May 2026 16:02:37 +0000 (UTC) Received: from francesco-nb (93-33-39-96.ip42.fastwebnet.it [93.33.39.96]) by mail11.truemail.it (Postfix) with ESMTPA id 0DE4A1FCFB; Fri, 29 May 2026 18:02:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1780070555; bh=vev3uWK3nb5vm7RDNrdb/+RhFlWVQB2NrTqyd6V5BOk=; h=From:To:Subject; b=MfjVvoT2mqcofwmK1RIh/yf5VUeSVxZwEqfG6FEDSpVQEJH6XUcjw5qWnnCsVyNgi FApejYKeYSsZe0yRZwh5++hxKGfYEWj5yqhLDsU0GvGV1BrZzT+MPq+enviTJ3V2i6 VIM5Ds3YDLzDvDcpvXO2GSjQSxji8T+ELdX+sZqJ6CXYESDrz+i0vLt7ZdRDWR5GuF uYfuzatGvRxQ3+qnmG+Snx2sxlu0OI7BLXxUC/HTs+NYqQ2d68u6hAsVh6f6wPPSYh pHoslPekcopkkYkbyljmX05CADm/jC7ET/RCVgPi1QatzDc9b8uXG2RV5elXUyTVSp 8dl1h14bStsIw== Date: Fri, 29 May 2026 18:02:27 +0200 From: Francesco Dolcini To: Nishanth Menon Cc: Vitor Soares , Laurent Pinchart , Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vignesh Raghavendra , Tero Kristo , Lad Prabhakar , Thierry Reding , Vitor Soares , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 06/11] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 7" DSI Message-ID: <20260529160227.GA6917@francesco-nb> References: <20260522161105.277519-13-ivitro@gmail.com> <20260522161105.277519-19-ivitro@gmail.com> <20260529155345.z6ht5adzhwafdvx5@voting> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260529155345.z6ht5adzhwafdvx5@voting> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, May 29, 2026 at 10:53:45AM -0500, Nishanth Menon wrote: > On 17:11-20260522, Vitor Soares wrote: > > + touchscreen@41 { > > + compatible = "ilitek,ili2132"; > > + reg = <0x41>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_dsi1_int>, <&pinctrl_i2s_2_bclk_gpio>; > > + /* Verdin GPIO_9_DSI (SODIMM 17) - TOUCH_INT# */ > > + interrupt-parent = <&main_gpio1>; > > + interrupts = <49 IRQ_TYPE_EDGE_RISING>; > > https://lore.kernel.org/r/20260521152550.A928B1F000E9@smtp.kernel.org > https://lore.kernel.org/r/20260522140245.472651F000E9@smtp.kernel.org > Sashiko comment would probably be good to explain - I see the same in > v3. The interrupt pin of the ilitek,ili2132 touch controller is a very short pulse, the net name TOUCH_INT# is on the board side and it is generic, not specific on the touch controller used. Both falling and edge would work fine. The reason for using rising is that for the way the HW is designed the interrupt signal is not that "clean", and triggering on the falling edge produce some spurious interrupt. Those spurious interrupts are handled nicely by the driver, but they pollute the kernel logs for no reason. Nishanth: in general do you want an explicit answer to every comment made my sashiko? Francesco