From: Thomas Gleixner <tglx@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Miroslav Lichvar <mlichvar@redhat.com>,
John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
thomas.weissschuh@linutronix.de,
Arthur Kiyanovski <akiyano@amazon.com>,
Rodolfo Giometti <giometti@enneenne.com>,
Vincent Donnefort <vdonnefort@google.com>,
Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
kvmarm@lists.linux.dev, Oliver Upton <oupton@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Johannes Berg <johannes.berg@intel.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Peter Hilber <peter.hilber@oss.qualcomm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux.dev, linux-wireless@vger.kernel.org,
linux-sound@vger.kernel.org, David Woodhouse <dwmw@amazon.co.uk>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: [patch V2 11/25] timekeeping: Add CLOCK ID to system_device_crosststamp
Date: Fri, 29 May 2026 22:00:32 +0200 [thread overview]
Message-ID: <20260529195557.482153523@kernel.org> (raw)
In-Reply-To: 20260529193435.921555544@kernel.org
From: Thomas Gleixner <tglx@kernel.org>
The normal capture for system/device cross timestamps is CLOCK_REALTIME,
but that's meaningless for AUX clocks.
Add a clock_id field to struct system_device_crosststamp and initialize it
with CLOCK_REALTIME at the two places which prepare for cross
timestamps.
After the related code has been cleaned up, the core code will honor the
clock_id field when calculating the system time from the system counter
snapshot.
No functional change.
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Tested-by: David Woodhouse <dwmw@amazon.co.uk>
Tested-by: Arthur Kiyanovski <akiyano@amazon.com>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
---
drivers/ptp/ptp_chardev.c | 2 +-
include/linux/timekeeping.h | 2 ++
sound/hda/common/controller.c | 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
--- a/drivers/ptp/ptp_chardev.c
+++ b/drivers/ptp/ptp_chardev.c
@@ -317,8 +317,8 @@ typedef int (*ptp_crosststamp_fn)(struct
static long ptp_sys_offset_precise(struct ptp_clock *ptp, void __user *arg,
ptp_crosststamp_fn crosststamp_fn)
{
+ struct system_device_crosststamp xtstamp = { .clock_id = CLOCK_REALTIME };
struct ptp_sys_offset_precise precise_offset;
- struct system_device_crosststamp xtstamp;
struct timespec64 ts;
int err;
--- a/include/linux/timekeeping.h
+++ b/include/linux/timekeeping.h
@@ -315,12 +315,14 @@ struct system_counterval_t {
/**
* struct system_device_crosststamp - system/device cross-timestamp
* (synchronized capture)
+ * @clock_id: System time Clock ID to capture
* @device: Device time
* @sys_counter: Clocksource counter value simultaneous with device time
* @sys_realtime: Realtime simultaneous with device time
* @sys_monoraw: Monotonic raw simultaneous with device time
*/
struct system_device_crosststamp {
+ clockid_t clock_id;
ktime_t device;
struct system_counterval_t sys_counter;
ktime_t sys_realtime;
--- a/sound/hda/common/controller.c
+++ b/sound/hda/common/controller.c
@@ -489,9 +489,9 @@ static int azx_get_time_info(struct snd_
struct snd_pcm_audio_tstamp_config *audio_tstamp_config,
struct snd_pcm_audio_tstamp_report *audio_tstamp_report)
{
+ struct system_device_crosststamp xtstamp = { .clock_id = CLOCK_REALTIME };
struct azx_dev *azx_dev = get_azx_dev(substream);
struct snd_pcm_runtime *runtime = substream->runtime;
- struct system_device_crosststamp xtstamp;
int ret;
u64 nsec;
next prev parent reply other threads:[~2026-05-29 20:00 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 19:59 [patch V2 00/25] timekeeping/ptp: Expand snapshot functionality Thomas Gleixner
2026-05-29 19:59 ` [patch V2 01/25] timekeeping: Provide ktime_get_snapshot_id() Thomas Gleixner
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-05-29 19:59 ` [patch V2 02/25] timekeeping: Use system_time_snapshot::systime/monoraw instead of ::real/raw Thomas Gleixner
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-05-29 19:59 ` [patch V2 03/25] pps: generators: Use ktime_get_real_ts64() instead of ktime_get_snapshot() Thomas Gleixner
2026-05-30 11:04 ` Rodolfo Giometti
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 04/25] pps: Convert to ktime_get_snapshot_id() Thomas Gleixner
2026-05-30 11:08 ` Rodolfo Giometti
2026-06-02 9:31 ` Thomas Gleixner
2026-06-02 10:56 ` David Woodhouse
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 05/25] KVM: arm64: Use ktime_get_snapshot_id() to retrieve CLOCK_BOOTTIME Thomas Gleixner
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 1:55 ` Nathan Chancellor
2026-06-04 9:06 ` Thomas Gleixner
2026-06-04 9:08 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 06/25] KVM: arm64: Use ktime_get_snapshot_id() to snapshot CLOCK_REALTIME Thomas Gleixner
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:08 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 07/25] ptp: ptp_vmclock: Convert to ktime_get_snapshot_id() Thomas Gleixner
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 08/25] timekeeping: Remove system_time_snapshot::real/boot/raw Thomas Gleixner
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 09/25] timekeeping: Add CLOCK_AUX support for ktime_get_snapshot_id() Thomas Gleixner
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 10/25] timekeeping: Add system_counterval_t to struct system_device_crosststamp Thomas Gleixner
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` Thomas Gleixner [this message]
2026-06-02 9:46 ` [tip: timers/ptp] timekeeping: Add CLOCK ID to system_device_crosststamp tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 12/25] wifi: iwlwifi: Adopt PTP cross timestamps to core changes Thomas Gleixner
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 13/25] ice/ptp: Use provided clock ID for history snapshot Thomas Gleixner
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 14/25] igc: " Thomas Gleixner
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 15/25] net/mlx5: " Thomas Gleixner
2026-06-02 9:46 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 16/25] virtio_rtc: " Thomas Gleixner
2026-06-02 9:45 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-02 14:44 ` [patch V2 16/25] " Peter Hilber
2026-06-04 9:07 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-05-29 20:00 ` [patch V2 17/25] timekeeping: Remove ktime_get_snapshot() Thomas Gleixner
2026-06-02 9:45 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 18/25] timekeeping: Prepare for cross timestamps on arbitrary clock IDs Thomas Gleixner
2026-06-02 9:45 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 19/25] ptp: Use system_device_crosststamp::sys_systime Thomas Gleixner
2026-06-02 9:45 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 20/25] wifi: iwlwifi: " Thomas Gleixner
2026-06-02 9:45 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 21/25] ALSA: hda/common: " Thomas Gleixner
2026-06-02 9:45 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-02 17:46 ` [patch V2 21/25] " Takashi Iwai
2026-06-04 9:07 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 22/25] timekeeping: Remove system_device_crosststamp::sys_realtime Thomas Gleixner
2026-06-02 9:45 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 23/25] timekeeping: Add support for AUX clock cross timestamping Thomas Gleixner
2026-06-02 9:45 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 24/25] ptp: Switch to ktime_get_snapshot_id() for pre/post timestamps Thomas Gleixner
2026-06-02 9:45 ` [tip: timers/ptp] " tip-bot2 for Thomas Gleixner
2026-06-04 9:07 ` tip-bot2 for Thomas Gleixner
2026-05-29 20:01 ` [patch V2 25/25] timekeeping: Add clocksource read_snapshot() method and hw_cycles to snapshot Thomas Gleixner
2026-06-02 9:45 ` [tip: timers/ptp] " tip-bot2 for David Woodhouse
2026-06-04 9:07 ` tip-bot2 for David Woodhouse
2026-05-29 20:33 ` [patch V2 00/25] timekeeping/ptp: Expand snapshot functionality Jacob Keller
2026-06-01 10:59 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529195557.482153523@kernel.org \
--to=tglx@kernel.org \
--cc=akiyano@amazon.com \
--cc=anna-maria@linutronix.de \
--cc=anthony.l.nguyen@intel.com \
--cc=dwmw2@infradead.org \
--cc=dwmw@amazon.co.uk \
--cc=frederic@kernel.org \
--cc=giometti@enneenne.com \
--cc=jacob.e.keller@intel.com \
--cc=johannes.berg@intel.com \
--cc=jstultz@google.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maz@kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=mlichvar@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=oupton@kernel.org \
--cc=peter.hilber@oss.qualcomm.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=sboyd@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=tiwai@suse.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vdonnefort@google.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.