From: Eric Biggers <ebiggers@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-sunxi@lists.linux.dev, linux-crypto@vger.kernel.org,
Corentin Labbe <clabbe.montjoie@gmail.com>
Subject: Re: [PATCH] crypto: sun4i-ss - Remove insecure and unused rng_alg
Date: Fri, 29 May 2026 20:54:11 +0000 [thread overview]
Message-ID: <20260529205411.GA901806@google.com> (raw)
In-Reply-To: <20260529195725.5C7B91F00898@smtp.kernel.org>
On Fri, May 29, 2026 at 07:57:24PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
>
> Pre-existing issues:
> - [High] The debugfs directory and files created during probe are never removed on driver unbind, module unload, or probe failure, leading to a resource leak and potential Use-After-Free or page fault.
> - [High] The driver modifies a static global array (`ss_algs`) to store per-device context (`ss`), which breaks if multiple instances of the device are probed.
> - [High] Missing check on `sg_miter_next` return value leads to an infinite loop (DoS) inside a `spin_lock_bh` critical section.
Just par for the course for drivers/crypto/.
- Eric
next prev parent reply other threads:[~2026-05-29 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 19:36 [PATCH] crypto: sun4i-ss - Remove insecure and unused rng_alg Eric Biggers
2026-05-29 19:57 ` sashiko-bot
2026-05-29 20:54 ` Eric Biggers [this message]
2026-06-01 15:08 ` Corentin Labbe
-- strict thread matches above, loose matches on Subject: below --
2026-06-01 9:19 Tianchu Chen
2026-06-01 15:54 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529205411.GA901806@google.com \
--to=ebiggers@kernel.org \
--cc=clabbe.montjoie@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.