From: Rosen Penev <rosenp@gmail.com>
To: linux-ide@vger.kernel.org
Cc: Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <cassel@kernel.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/3] ata: pata_ep93xx: avoid asm on non ARM
Date: Fri, 29 May 2026 17:36:25 -0700 [thread overview]
Message-ID: <20260530003627.42473-2-rosenp@gmail.com> (raw)
In-Reply-To: <20260530003627.42473-1-rosenp@gmail.com>
The raw ARM asm delay loop prevents COMPILE_TEST builds on
non-ARM architectures. Guard it with CONFIG_ARM and provide a
cpu_relax() fallback for compilation on other architectures.
Assisted-by: Opencode:Big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/ata/pata_ep93xx.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c
index b2b9e0058333..f7e87d6af264 100644
--- a/drivers/ata/pata_ep93xx.c
+++ b/drivers/ata/pata_ep93xx.c
@@ -204,6 +204,7 @@ static void ep93xx_pata_enable_pio(void __iomem *base, int pio_mode)
*/
static void ep93xx_pata_delay(unsigned long count)
{
+#ifdef CONFIG_ARM
__asm__ volatile (
"0:\n"
"mov r0, r0\n"
@@ -212,6 +213,10 @@ static void ep93xx_pata_delay(unsigned long count)
: "=r" (count)
: "0" (count)
);
+#else
+ while (count--)
+ cpu_relax();
+#endif
}
static unsigned long ep93xx_pata_wait_for_iordy(void __iomem *base,
--
2.54.0
next prev parent reply other threads:[~2026-05-30 0:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 0:36 [PATCH 0/3] ata: pata_ep93xx: COMPILE_TEST and ARM fixups Rosen Penev
2026-05-30 0:36 ` Rosen Penev [this message]
2026-05-30 0:49 ` [PATCH 1/3] ata: pata_ep93xx: avoid asm on non ARM sashiko-bot
2026-05-30 0:36 ` [PATCH 2/3] ata: pata_ep93xx: use unsigned long for data Rosen Penev
2026-05-30 4:49 ` sashiko-bot
2026-05-30 0:36 ` [PATCH 3/3] ata: pata_ep93xx: add COMPILE_TEST support Rosen Penev
2026-05-30 4:57 ` sashiko-bot
2026-06-01 8:54 ` [PATCH 0/3] ata: pata_ep93xx: COMPILE_TEST and ARM fixups Niklas Cassel
2026-06-01 18:12 ` Rosen Penev
2026-06-01 18:34 ` Niklas Cassel
2026-06-01 18:39 ` Rosen Penev
2026-06-02 11:15 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260530003627.42473-2-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.