Re: [PATCH bpf-next v2 4/5] selftests/bpf: Remove __arg_arena from the codebase

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete removal of `__arg_arena` annotation
--

commit 936642e9509313ae2959c6a3c4255651cca7040f
Author: Emil Tsalapatis <emil@etsalapatis.com>

selftests/bpf: Remove __arg_arena from the codebase

This commit removes the __arg_arena annotation from the codebase because
it has been subsumed by the __arena BTF type tag. The typedefs previously
used to minimize __arena annotations are removed, and the pointer types
are directly annotated when declaring variables instead.

> diff --git a/tools/testing/selftests/bpf/bpf_arena_htab.h b/tools/testing/selftests/bpf/bpf_arena_htab.h
> index acc01a876668e..eb80d67c38708 100644
> --- a/tools/testing/selftests/bpf/bpf_arena_htab.h
> +++ b/tools/testing/selftests/bpf/bpf_arena_htab.h

[ ... ]

> @@ -53,7 +52,7 @@ static int htab_hash(int key)
>  	return key;
>  }
>  
> -__weak int htab_lookup_elem(htab_t *htab __arg_arena, int key)
> +__weak int htab_lookup_elem(struct htab __arena *htab __arg_arena, int key)

[Severity: Low]
Is the __arg_arena annotation incorrectly retained here? The commit
message mentions removing __arg_arena from the codebase, but it seems to
still be present in the signature of htab_lookup_elem().

Additionally, is it possible that an empty macro definition for __arg_arena
still remains in the userspace section of bpf_arena_common.h?

>  {
>  	hashtab_elem_t *l_old;
>  	arena_list_head_t *head;

[ ... ]

> @@ -66,7 +65,7 @@ __weak int htab_lookup_elem(htab_t *htab __arg_arena, int key)
>  	return 0;
>  }
>  
> -__weak int htab_update_elem(htab_t *htab __arg_arena, int key, int value)
> +__weak int htab_update_elem(struct htab __arena *htab __arg_arena, int key, int value)

[Severity: Low]
Was __arg_arena intended to be removed from the signature of
htab_update_elem() here as well?

>  {
>  	hashtab_elem_t *l_new = NULL, *l_old;
>  	arena_list_head_t *head;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260530002259.4505-1-emil@etsalapatis.com?part=4