Re: [PATCH v3 17/27] KVM: Remove KVM_MMIO as config option

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Brittle header dependency introduced in `virt/kvm/coalesced_mmio.h`.
--

commit fd122dad5412c5f1816bc36167f1d3f0cd523036
Author: Steffen Eiden <seiden@linux.ibm.com>

KVM: Remove KVM_MMIO as config option

Defining KVM_MMIO is not flexible enough for multi-KVM systems with
different Kconfig options regarding KVM_MMIO. Therefore, remove KVM_MMIO
from the config space and use the macro HAVE_KVM_MMIO instead.

[ ... ]

> diff --git a/virt/kvm/coalesced_mmio.h b/virt/kvm/coalesced_mmio.h
> index 36f84264ed257..a8430d41945b9 100644
> --- a/virt/kvm/coalesced_mmio.h
> +++ b/virt/kvm/coalesced_mmio.h
> @@ -11,7 +11,7 @@
>   *
>   */
>  
> -#ifdef CONFIG_KVM_MMIO
> +#ifdef HAVE_KVM_MMIO

[Severity: Low]
Does this make the header implicitly dependent on the inclusion order?

Since HAVE_KVM_MMIO is no longer a globally available config macro but is
instead defined in <asm/kvm_host.h>, evaluating it here without explicitly
including <linux/kvm_host.h> relies on the calling C files including it
first.

While this doesn't cause an immediate build failure with the current
includers (kvm_main.c and coalesced_mmio.c), a future includer that does
not include <linux/kvm_host.h> first would silently evaluate the macro
as false, resulting in missing struct declarations.

>  
>  #include <linux/list.h>
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529155050.2902245-1-seiden@linux.ibm.com?part=17