From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FCA93093A6; Sat, 30 May 2026 16:16:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780157802; cv=none; b=rgiOfboZTgO+8ZfjSba935TXPg/3rOq46M2P8zdmx27Ua3M19LCCaIn0PQbC22So9KxjBQhB1KNCV1C3+NVxlL6cNa9AC6NtgVg08tAJZycRWIYqJS+jjnRqE+r/M6bfc/2xB8JUlRCzuXLmATqP8X2Vrdb9N1NVL1mMZebR1hM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780157802; c=relaxed/simple; bh=svqPHMsToOWw4s6gs4DF6Fpe16TV4EDATAXvYRpmUQs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nDSV2JY71LeLdUaw8+WZWA2fziUOy3LmB46y+ZhSjmEQeClUfAps/jH5/alsxLOE0ouErXJhhqO8wAUtEXcT3iuxJfivJkbcQ8kp/7JhMzmKJ31f4jrA7aODkD2iGQ7KxPYGta4HVqJNTb7z28K6zGQ2Hsg9+BGh6p6yoahpIjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=I2yXax4B; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="I2yXax4B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D1E61F00893; Sat, 30 May 2026 16:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780157797; bh=nyKbko4qKEeM5mFUZ6dWFNoWXcEB4EFn92/nxJa42sU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=I2yXax4BjBBx5jKwBlP/1hoG2EGzTkcIH6gWR0m9zEgDZgxeNHI7f2ILhdkRTfSEJ iGY8d6rpgx/9Ty1neR474Xk6L1Y5sboTh54MflQnDLo4FF+xrGrnHEF/cN5oUjC1dp GX3ile5JrUugeiSAlOBROpfZcrCWxv6nrlVSZGBs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Boris Burkov , Goldwyn Rodrigues , David Sterba , Sasha Levin Subject: [PATCH 5.10 004/589] btrfs: tracepoints: get correct superblock from dentry in event btrfs_sync_file() Date: Sat, 30 May 2026 17:58:05 +0200 Message-ID: <20260530160224.693047816@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Goldwyn Rodrigues [ Upstream commit a85b46db143fda5869e7d8df8f258ccef5fa1719 ] If overlay is used on top of btrfs, dentry->d_sb translates to overlay's super block and fsid assignment will lead to a crash. Use file_inode(file)->i_sb to always get btrfs_sb. Reviewed-by: Boris Burkov Signed-off-by: Goldwyn Rodrigues Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- include/trace/events/btrfs.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h index d8aa1d3570243..7e6fcbc6c6c55 100644 --- a/include/trace/events/btrfs.h +++ b/include/trace/events/btrfs.h @@ -697,12 +697,15 @@ TRACE_EVENT(btrfs_sync_file, ), TP_fast_assign( - const struct dentry *dentry = file->f_path.dentry; - const struct inode *inode = d_inode(dentry); + struct dentry *dentry = file_dentry(file); + struct inode *inode = file_inode(file); + struct dentry *parent = dget_parent(dentry); + struct inode *parent_inode = d_inode(parent); - TP_fast_assign_fsid(btrfs_sb(file->f_path.dentry->d_sb)); + dput(parent); + TP_fast_assign_fsid(btrfs_sb(inode->i_sb)); __entry->ino = btrfs_ino(BTRFS_I(inode)); - __entry->parent = btrfs_ino(BTRFS_I(d_inode(dentry->d_parent))); + __entry->parent = btrfs_ino(BTRFS_I(parent_inode)); __entry->datasync = datasync; __entry->root_objectid = BTRFS_I(inode)->root->root_key.objectid; -- 2.53.0