From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A19EA3AB285; Sat, 30 May 2026 18:21:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165295; cv=none; b=LDUbfg7SyMzmoFou1SxK+Xah0hQWAIq/6R8nkiF4WOHmf+Uvv2GFlisAYhot/0B9avY4Cb+eTaAMs0dJIqQ+Ir2VTQq4EBGmdwyJhvNXjUbJB3b0VYTNiNldupB/MFEERnBigbn9acLsJiEzYhFfZLcsKbweOX3i+wXmPn1jXv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165295; c=relaxed/simple; bh=PtdGHaankBqI/NpH4gC/i4ch/ZNQlkYtVll/u1mXnnU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=arpRVpqZYAg9T6rrdEAFUjZjyDGU+cIV8NPZYuZo4ApNVUdOzOzQ1WwMPvGLanl0XDiqzUnJC7UgI43IAumihQXjHA0V0obJeZPjJ4g4qGJ90ZBKX0uJmzX+xrZzv3i4fU58gfS3rAyN5frEGdshTOEAj77EaYhy+BClm4eocaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=MXX0+f7T; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="MXX0+f7T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFEA51F00893; Sat, 30 May 2026 18:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780165293; bh=MZepzH3fWlqNLqJoNWG1A0k+A+SsdqA0z/kORB2pDRg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=MXX0+f7TtwOjSUn4YBk1OXsGNnFnSk7+AudJLfbSTC6vOceWsucLrFnpssx7UFz44 FEpClN7wBdUpscjEMgmgNbTsGhaJyzyTfHrMsQtRRmDo2lk4Bb2w0GUKdGG+UMYba2 CkPyeEyZkvjLsO3luaa7iF7Hh99PTGZdThqeab20= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Melissa Wen , =?UTF-8?q?Ma=C3=ADra=20Canal?= , Sasha Levin Subject: [PATCH 5.10 016/589] drm/vc4: Fix memory leak of BO array in hang state Date: Sat, 30 May 2026 17:58:17 +0200 Message-ID: <20260530160225.008743069@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maíra Canal [ Upstream commit f4dfd6847b3e5d24e336bca6057485116d17aea4 ] The hang state's BO array is allocated separately with kzalloc() in vc4_save_hang_state() but never freed in vc4_free_hang_state(). Add the missing kfree() for the BO array before freeing the hang state struct. Fixes: 214613656b51 ("drm/vc4: Add an interface for capturing the GPU state after a hang.") Reviewed-by: Melissa Wen Link: https://patch.msgid.link/20260330-vc4-misc-fixes-v1-2-92defc940a29@igalia.com Signed-off-by: Maíra Canal Signed-off-by: Sasha Levin --- drivers/gpu/drm/vc4/vc4_gem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c index b641252939d87..788f64154119b 100644 --- a/drivers/gpu/drm/vc4/vc4_gem.c +++ b/drivers/gpu/drm/vc4/vc4_gem.c @@ -60,6 +60,7 @@ vc4_free_hang_state(struct drm_device *dev, struct vc4_hang_state *state) for (i = 0; i < state->user_state.bo_count; i++) drm_gem_object_put(state->bo[i]); + kfree(state->bo); kfree(state); } -- 2.53.0