From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A83C21B191; Sat, 30 May 2026 18:20:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165259; cv=none; b=UBRnEEFZHa3hoMyRbqNnsnJQsOFCHT5IJDlKBFxoPXvwpvwALZ1XleH4Akn9DXSgrdDvnHGwIAh4/HHSkda0VdAE40IQTXs0YRPFRVzGzqm/04kBrVDSDf3lCdgow4oJXmnXJsreXRqibSWU0ZEigSk5W8t4KXGQfEZyHIlxo+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165259; c=relaxed/simple; bh=BYWaPY3pcF9JJuXA8S3xkIBPmVSwGj6WiSm9Eq3K4WU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kg8SCgxlzaGDrP+uxOsopezViV7vPNSdSNinLlF9A8WQ3JG/v4wj6LlfpZ1Sb3kzpxFkFLpTzZTrCgsJKZfLs62hQ6333HRVdiaOrPK256pr3A4OyQDMLKzrIS/37hdSovWA3Uo5U7tTk7YahZ+kHymII0e9yBWsutnCJBUjzIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=B6Q9V2pm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="B6Q9V2pm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEDA41F00893; Sat, 30 May 2026 18:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780165258; bh=jf185f78ZpuMGShDL4L78+RFpyF58Td//ermJvR1tXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=B6Q9V2pmLKOg63kJyv8en3bh1WY9vKt389j2NIETN42OkCvu6wX6L4kLaS2U2V7lY Jp8Vp6XOZ9682XvCgTqtrV549Hk3S88r2DetKkTFH+pz4PzMNu7MObfDzk5LfeVjR7 Nq2qR4m/osxkavpVu/u62OitgemAoUCPsCLz+kHg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , Stanislav Fomichev , Maciej Fijalkowski , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 026/589] xsk: tighten UMEM headroom validation to account for tailroom and min frame Date: Sat, 30 May 2026 17:58:27 +0200 Message-ID: <20260530160225.270182189@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maciej Fijalkowski [ Upstream commit a315e022a72d95ef5f1d4e58e903cb492b0ad931 ] The current headroom validation in xdp_umem_reg() could leave us with insufficient space dedicated to even receive minimum-sized ethernet frame. Furthermore if multi-buffer would come to play then skb_shared_info stored at the end of XSK frame would be corrupted. HW typically works with 128-aligned sizes so let us provide this value as bare minimum. Multi-buffer setting is known later in the configuration process so besides accounting for 128 bytes, let us also take care of tailroom space upfront. Reviewed-by: Björn Töpel Acked-by: Stanislav Fomichev Fixes: 99e3a236dd43 ("xsk: Add missing check on user supplied headroom size") Signed-off-by: Maciej Fijalkowski Link: https://patch.msgid.link/20260402154958.562179-2-maciej.fijalkowski@intel.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/xdp/xdp_umem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c index 42b19feb2b6e5..79df583b6ce06 100644 --- a/net/xdp/xdp_umem.c +++ b/net/xdp/xdp_umem.c @@ -199,7 +199,8 @@ static int xdp_umem_reg(struct xdp_umem *umem, struct xdp_umem_reg *mr) if (!unaligned_chunks && chunks_rem) return -EINVAL; - if (headroom >= chunk_size - XDP_PACKET_HEADROOM) + if (headroom > chunk_size - XDP_PACKET_HEADROOM - + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) - 128) return -EINVAL; umem->size = size; -- 2.53.0