From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94A2417555; Sat, 30 May 2026 18:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165361; cv=none; b=BYR+7nh0wGQ1Xshme+zPcNIJ/z/CAKBQysr6j6ZKaf49/lY+Bv40BtDODjTdUZ0lPerqQRe8cOdWWv7C5GAmz+iOwCe40KWjcu53IX+MMyXkb+mX4eEV9HYBqLMMSEtFPVBVaMU57V++3SU376Kn3Ye1NSm3He5GlCrB4J4jADA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165361; c=relaxed/simple; bh=1x/0ksaWRlqcw55DGpLmNTu/jld2EkcEouGvlYIYzm0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gqbgTkHTrZhn7eGCmLtX/CmqB4sWCW+VqHdWzKcQeOt0Xn7p+plWvFaEXoLOBWQXSAwloGwVF/YuwXSqYqY7n4+rOBbS0VZBwhh2YaeRfqf9SYVTGZ0xPU1TJWqf/iNPlC2Q1eKeO+/LXJSlSH+5jafJDZ1p6iBPcxpD15QML9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GJT99AjQ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GJT99AjQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2AAF1F00893; Sat, 30 May 2026 18:22:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780165360; bh=xdoH07yeun/oOqwJXXEsrcCUGZLZyY6sun8h4T21JfA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GJT99AjQtobLDOduCA5pfoBq5skaB/u7XjirjsAlOZZ0GoDBW06IEeBBeCwjyej0v bhUad0Kn7tqva711XvHdFnU1trfTdmFProkINZq0E8CHri1FMkrGHjfSbz22y4NNBQ c4IYxDhXXYygfmh0b18xAry102RKZCmssSv241iw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable Subject: [PATCH 5.10 055/589] usb: gadget: renesas_usb3: validate endpoint index in standard request handlers Date: Sat, 30 May 2026 17:58:56 +0200 Message-ID: <20260530160226.040135570@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit f880aac8a57ebd92abfa685d45424b2998ac1059 upstream. The GET_STATUS and SET/CLEAR_FEATURE handlers extract the endpoint number from the host-supplied wIndex without any sort of validation. Fix this up by validating the number of endpoints actually match up with the number the device has before attempting to dereference a pointer based on this math. This is just like what was done in commit ee0d382feb44 ("usb: gadget: aspeed_udc: validate endpoint index for ast udc") for the aspeed driver. Fixes: 746bfe63bba3 ("usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller") Cc: stable Assisted-by: gregkh_clanker_t1000 Link: https://patch.msgid.link/2026040647-sincerity-untidy-b104@gregkh Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/renesas_usb3.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -1611,6 +1611,10 @@ static bool usb3_std_req_get_status(stru break; case USB_RECIP_ENDPOINT: num = le16_to_cpu(ctrl->wIndex) & USB_ENDPOINT_NUMBER_MASK; + if (num >= usb3->num_usb3_eps) { + stall = true; + break; + } usb3_ep = usb3_get_ep(usb3, num); if (usb3_ep->halt) status |= 1 << USB_ENDPOINT_HALT; @@ -1723,7 +1727,8 @@ static bool usb3_std_req_feature_endpoin struct renesas_usb3_ep *usb3_ep; struct renesas_usb3_request *usb3_req; - if (le16_to_cpu(ctrl->wValue) != USB_ENDPOINT_HALT) + if ((le16_to_cpu(ctrl->wValue) != USB_ENDPOINT_HALT) || + (num >= usb3->num_usb3_eps)) return true; /* stall */ usb3_ep = usb3_get_ep(usb3, num);