From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DE9517555; Sat, 30 May 2026 18:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165430; cv=none; b=oI9E2BQ4k0hTxi8o5U6W4zv8+AQTr7HEofjnj5RDbnZKpPvOXjVV/L10jkf2CnW3A7BvcZuG4aXNE+0zm+Q82rpWrOcbN1ct+1eU5VbZzjWo/PH/GLXr65auFjR+dv3wQ0zbpcL/X+StNe9OBryhndZJdGH8Bo5Pz036A5v8yUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165430; c=relaxed/simple; bh=kv9GNB0gjFkNNVxp2zQe7N7T5HGZ5Ks6RiyqFn8JyQA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kj8qxRq7dA1GEu6zJ7Gl2cPl6UnIMAmLsUeWrArucow+bUx5/+8Won9KOD7Uzz6E8s6UUv+QVDpRr6MWMEER0zR2V69UlHPp7G8ayfe/1UCgQj+/G73QV4v7rKAYjl9ckapWVgigTHChppF0ksQA9P4468OQmJsg+ZJsCox/HmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IzDog+eS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IzDog+eS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F9011F00893; Sat, 30 May 2026 18:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780165429; bh=8UupNBh3VLnbOM8XorJ7dDg+GVytuT5n8ZCltcUiixI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IzDog+eSHjNQ0RuXp/gEqIjiVFJjVWEYr54d6RuXT88Z2lARBlR1+DHIV4SWDpGWR gy2s0PGYZcOBAgec/ytDZnbl3IEq4/87GlPXDtT3ZB7IJPCWWCJnKRXVrIBoIgfRuA bATWbbic/97de2Ph59kCwccxrTMYMU5w5+gYu5tw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+639ebc6ec75e96674741@syzkaller.appspotmail.com, Ruslan Valiyev , Hans Verkuil Subject: [PATCH 5.10 076/589] media: vidtv: fix nfeeds state corruption on start_streaming failure Date: Sat, 30 May 2026 17:59:17 +0200 Message-ID: <20260530160226.601905068@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ruslan Valiyev commit a0e5a598fe9a4612b852406b51153b881592aede upstream. syzbot reported a memory leak in vidtv_psi_service_desc_init [1]. When vidtv_start_streaming() fails inside vidtv_start_feed(), the nfeeds counter is left incremented even though no feed was actually started. This corrupts the driver state: subsequent start_feed calls see nfeeds > 1 and skip starting the mux, while stop_feed calls eventually try to stop a non-existent stream. This state corruption can also lead to memory leaks, since the mux and channel resources may be partially allocated during a failed start_streaming but never cleaned up, as the stop path finds dvb->streaming == false and returns early. Fix by decrementing nfeeds back when start_streaming fails, keeping the counter in sync with the actual number of active feeds. [1] BUG: memory leak unreferenced object 0xffff888145b50820 (size 32): comm "syz.0.17", pid 6068, jiffies 4294944486 backtrace (crc 90a0c7d4): vidtv_psi_service_desc_init+0x74/0x1b0 drivers/media/test-drivers/vidtv/vidtv_psi.c:288 vidtv_channel_s302m_init+0xb1/0x2a0 drivers/media/test-drivers/vidtv/vidtv_channel.c:83 vidtv_channels_init+0x1b/0x40 drivers/media/test-drivers/vidtv/vidtv_channel.c:524 vidtv_mux_init+0x516/0xbe0 drivers/media/test-drivers/vidtv/vidtv_mux.c:518 vidtv_start_streaming drivers/media/test-drivers/vidtv/vidtv_bridge.c:194 [inline] vidtv_start_feed+0x33e/0x4d0 drivers/media/test-drivers/vidtv/vidtv_bridge.c:239 Fixes: f90cf6079bf67 ("media: vidtv: add a bridge driver") Cc: stable@vger.kernel.org Reported-by: syzbot+639ebc6ec75e96674741@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=639ebc6ec75e96674741 Signed-off-by: Ruslan Valiyev Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/test-drivers/vidtv/vidtv_bridge.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/media/test-drivers/vidtv/vidtv_bridge.c +++ b/drivers/media/test-drivers/vidtv/vidtv_bridge.c @@ -235,8 +235,10 @@ static int vidtv_start_feed(struct dvb_d if (dvb->nfeeds == 1) { ret = vidtv_start_streaming(dvb); - if (ret < 0) + if (ret < 0) { + dvb->nfeeds--; rc = ret; + } } mutex_unlock(&dvb->feed_lock);