From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D65912773DE; Sat, 30 May 2026 18:27:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165624; cv=none; b=L84cFN1nJuurKr5L5+pkxP2dTd78Knm2YcNCNqr6b8VI/7pg7Je/TBds1U6ztXlcnElvam3A3Eyf1SGQh9lB38pn1kitsp5q7b+iXCrrCallYl43m2T9awVrWs/51u1Ej0nuyRPfj+PKCELwNeF3F5RW86So9IFZz9JVk4lhbh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165624; c=relaxed/simple; bh=vTmW0p+96mQRcY504RWoBfmljQh6yaKH+nRCM4DqYYU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i6q8DzW+kksncVwF6rOxbvaG87+XolaJo7YGd4GrXimJi4coF8Vf5QZVYIRJ3yC9DPR4pHnHpYCa3teurtn0nKuYwSP9kk+0KutfZbdi3j2/4J2B/OBJh1YvVF0cDSwzfrlUteF3F1eCp8Za0qAvFgv9n/1sRY0EWLNX2ghPD/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tfI9XdH2; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tfI9XdH2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AFC61F00893; Sat, 30 May 2026 18:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780165623; bh=hIRkk5PRtZBgHvv45/uKUMqmsYGl0BbacYWF9Ue85IY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tfI9XdH2IKXWnjpl/UNWvcZDVz9s4YbhDo9ePPp+Ha3lqvaRJIvMMMbOVG5My3ot+ fUovVMNHOVjy1wTS8kR4adaD8s75Kx9KL8suhnnZeT+SoSFhRu0PEqGOs3TtLLKZW2 4eTG6gzvk8chT7EarcOEYh8kVu5I4LahKZ+Sp2lI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andrey Konovalov , Berk Cem Goksel , Takashi Iwai Subject: [PATCH 5.10 132/589] ALSA: caiaq: take a reference on the USB device in create_card() Date: Sat, 30 May 2026 18:00:13 +0200 Message-ID: <20260530160228.246637524@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Berk Cem Goksel commit 80bb50e2d459213cccff3111d5ef98ed4238c0d5 upstream. The caiaq driver stores a pointer to the parent USB device in cdev->chip.dev but never takes a reference on it. The card's private_free callback, snd_usb_caiaq_card_free(), can run asynchronously via snd_card_free_when_closed() after the USB device has already been disconnected and freed, so any access to cdev->chip.dev in that path dereferences a freed usb_device. On top of the refcounting issue, the current card_free implementation calls usb_reset_device(cdev->chip.dev). A reset in a free callback is inappropriate: the device is going away, the call takes the device lock in a teardown context, and the reset races with the disconnect path that the callback is already cleaning up after. Take a reference on the USB device in create_card() with usb_get_dev(), drop it with usb_put_dev() in the free callback, and remove the usb_reset_device() call. Fixes: b04dcbb7f7b1 ("ALSA: caiaq: Use snd_card_free_when_closed() at disconnection") Cc: stable@vger.kernel.org Cc: Andrey Konovalov Signed-off-by: Berk Cem Goksel Link: https://patch.msgid.link/20260413034941.1131465-3-berkcgoksel@gmail.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/caiaq/device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/sound/usb/caiaq/device.c +++ b/sound/usb/caiaq/device.c @@ -398,7 +398,7 @@ static void card_free(struct snd_card *c snd_usb_caiaq_input_free(cdev); #endif snd_usb_caiaq_audio_free(cdev); - usb_reset_device(cdev->chip.dev); + usb_put_dev(cdev->chip.dev); } static int create_card(struct usb_device *usb_dev, @@ -424,7 +424,7 @@ static int create_card(struct usb_device return err; cdev = caiaqdev(card); - cdev->chip.dev = usb_dev; + cdev->chip.dev = usb_get_dev(usb_dev); cdev->chip.card = card; cdev->chip.usb_id = USB_ID(le16_to_cpu(usb_dev->descriptor.idVendor), le16_to_cpu(usb_dev->descriptor.idProduct));