From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7615279DC9; Sat, 30 May 2026 18:29:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165776; cv=none; b=D35F71daPpmSHtF6vWS8ElhkoULkZmMCnvoDY5+w9+evju1dwI9lYi7dHYI8cg60Pc2j566zTOZLj3ov6lkNe4wqSmbG6AxhkfnYRLennXG8MgoZYsLd7vusqRQUWHGXx+upj41qb6kn93LX6VtMW5z9ywHSAaT8medtKmlZ7C0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165776; c=relaxed/simple; bh=ESPVgnmnoZPhaXOUooNnC6pO2liQsIfsJF4OZdwtCDU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fI6ZLPa/etWypOpgAmtWo0czb2oIORe001gv4GN4M/imCg9Exu4FCmEKhTrMNdE6lOayoPzPhyO/IjOfsuRjldDbgBEDnD8hQDSKkvDy7AkDgtA0kbnb02/hcwO2Kbi7zXbhjBmx+OEy6TGsUctcHt+m2Xc+7A/nbzkeJHiZafk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mc1GA+ne; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mc1GA+ne" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 274851F00893; Sat, 30 May 2026 18:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780165775; bh=0DpCrlK++1FTxteZziFpk7bvQfhV6Etn58W8ulBEK8E=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mc1GA+neKjrLz/MtWfUM98LRRFLqFv9bP7IKXAKHki3LVKMXuz4Y4LzhL3PMm97x1 6tXl9H8XfwYIpDQd6WuheXhzXRCxEPilIXWYeTOHcvmaxgJZUKQkrI3NWb1oz9ZDq+ OQ1ws0h7WZYvwYjVuEy7Cpm/Kjh9M8C7p//SjlT8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuhao Jiang , Tyllis Xu Subject: [PATCH 5.10 142/589] ibmasm: fix OOB reads in command_file_write due to missing size checks Date: Sat, 30 May 2026 18:00:23 +0200 Message-ID: <20260530160228.510853743@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tyllis Xu commit 0eb09f737428e482a32a2e31e5e223f2b35a71d3 upstream. The command_file_write() handler allocates a kernel buffer of exactly count bytes and copies user data into it, but does not validate the buffer against the dot command protocol before passing it to get_dot_command_size() and get_dot_command_timeout(). Since both the allocation size (count) and the header fields (command_size, data_size) are independently user-controlled, an attacker can cause get_dot_command_size() to return a value exceeding the allocation, triggering OOB reads in get_dot_command_timeout() and an out-of-bounds memcpy_toio() that leaks kernel heap memory to the service processor. Fix with two guards: reject writes smaller than sizeof(struct dot_command_header) before allocation, then after copying user data reject commands where the buffer is smaller than the total size declared by the header (sizeof(header) + command_size + data_size). This ensures all subsequent header and payload field accesses stay within the buffer. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Yuhao Jiang Cc: stable@vger.kernel.org Signed-off-by: Tyllis Xu Link: https://patch.msgid.link/20260314165355.548119-1-LivelyCarpet87@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/misc/ibmasm/ibmasmfs.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/misc/ibmasm/ibmasmfs.c +++ b/drivers/misc/ibmasm/ibmasmfs.c @@ -303,6 +303,8 @@ static ssize_t command_file_write(struct return -EINVAL; if (count == 0 || count > IBMASM_CMD_MAX_BUFFER_SIZE) return 0; + if (count < sizeof(struct dot_command_header)) + return -EINVAL; if (*offset != 0) return 0; @@ -319,6 +321,11 @@ static ssize_t command_file_write(struct return -EFAULT; } + if (count < get_dot_command_size(cmd->buffer)) { + command_put(cmd); + return -EINVAL; + } + spin_lock_irqsave(&command_data->sp->lock, flags); if (command_data->command) { spin_unlock_irqrestore(&command_data->sp->lock, flags);