From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F41CE279DC9; Sat, 30 May 2026 18:29:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165786; cv=none; b=kWfpNMy2Ig5hTpWv/DW0fwThoPGkUzeEGtfV03AZT3weTSGoA6op85NACn945lci0ynZd7QDM4WfduLmNuks3tQb01QwE1chMcqMidFBTcsa8/VQpiT24kn68SV/8GKAr8ozvhGi5NVqTZwmLogXc6yqIb/GBMZyyxboK72ZAeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165786; c=relaxed/simple; bh=r3fIfky1uukGMgfcjxAuyyW+ZTJjOfFb90RIYCXRYBU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZMggsAVQdEqPsLXwiUhDdr3CV6VjY1AI47g1w6gjHJKSjOVcYC4ARvi7Y50Eaw74T+le9cc4GjerJBke/VgSqOXO5V7kwJ5UcFx0DFcWAViKnal+kCEdYCljhv6wqROmfslXKcf300WUkesamGRtHTwQstLbRy44Ko7wbXSZZIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=17noawzL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="17noawzL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46E001F00893; Sat, 30 May 2026 18:29:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780165785; bh=2zzV9Y8+JC+QYc0uCPGm15nxWo2P+U3WaaSrt79NQOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=17noawzLks3cXsA1v5+9VgibJxPTz1Zj15djKGuVxRt7VrBeDskw6s5D4H9Q/U9g0 0deFVqo0wQMf85jpXun2JTxnh1tZFP1EZ0U7ac+llSPx3j13fnOL3m24rSUGKQ1me2 2Uqpl+tG6X7bSo6fJmWKHSOfoXRaYTDWUPbEOI4M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jacqueline Wong , Jordan Hand , Jarkko Sakkinen Subject: [PATCH 5.10 174/589] tpm: tpm_tis: add error logging for data transfer Date: Sat, 30 May 2026 18:00:55 +0200 Message-ID: <20260530160229.388820723@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jacqueline Wong commit 0471921e2d1043dcc6de5cffb49dd37709521abe upstream. Add logging to more easily determine reason for transmit failure Cc: stable@vger.kernel.org # v6.6+ Fixes: 280db21e153d8 ("tpm_tis: Resend command to recover from data transfer errors") Signed-off-by: Jacqueline Wong Signed-off-by: Jordan Hand Link: https://lore.kernel.org/r/20260415160006.2275325-2-jacqwong@google.com Signed-off-by: Jarkko Sakkinen Signed-off-by: Greg Kroah-Hartman --- drivers/char/tpm/tpm_tis_core.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -410,6 +410,8 @@ static int tpm_tis_send_data(struct tpm_ status = tpm_tis_status(chip); if (!itpm && (status & TPM_STS_DATA_EXPECT) == 0) { rc = -EIO; + dev_err(&chip->dev, "TPM_STS_DATA_EXPECT should be set. sts = 0x%08x\n", + status); goto out_err; } } @@ -427,6 +429,8 @@ static int tpm_tis_send_data(struct tpm_ status = tpm_tis_status(chip); if (!itpm && (status & TPM_STS_DATA_EXPECT) != 0) { rc = -EIO; + dev_err(&chip->dev, "TPM_STS_DATA_EXPECT should be unset. sts = 0x%08x\n", + status); goto out_err; }