From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5901A41A8F; Sat, 30 May 2026 18:32:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165926; cv=none; b=Z9hiIH9fi7hp7TwK3Er12KAoeTJ2sy2oiky6AOx9kTONyfF9CfpktbNxENiyezLYh7wrrXLtJREbxhZlIZX35J9gmZniHxlYv3Sw2PuRI69mtOWoNbaAF+Z+sYsfZM0QYmQ0XoGVHNuSN0CpVRqkFhikw/RAaDgoMUIPg8HWEPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165926; c=relaxed/simple; bh=gGtPT7Hmr09Zbtd87p4Vns5xhi4xtBcupaaMMzsaSbA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pT/DfE9x7AF0OxJ5C1pg3dAAG6tkHIO4cgyApkCxPotPLdyPaTcBkR+ur94XSwe4rGsFA2iKxleZ6RxWHAF/M7InP+qc+5SSCwkBMzYsSW7/6afkP3vCkDPUCO1g2B0o4lekpFgnXjsbjiSUDfEDdK6oTr0MTKmuUb4SgxVCPGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aD1zrAFs; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aD1zrAFs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D8F21F00893; Sat, 30 May 2026 18:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780165924; bh=3/OZFddcJmob+u5/6f1KMnsJowYT8XpPhOqJmmAw7ns=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aD1zrAFs8cRhPmx/g8zlk46IG0kBBBbi1GaI923WE2E3SyYVIkFdHp4b9boUPbiWx t1o4DZUaQ50Xvat1OEEV65kTVBe4plTgV5fQMmUwqZV95svUemgDPoWAGqo13e2cvG plnSgFNV47/qNwkobgH8uUYpbpq4HoAymqaPDOvc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?C=C3=A1ssio=20Gabriel?= , Takashi Iwai Subject: [PATCH 5.10 223/589] ALSA: usb-audio: Fix UAC3 cluster descriptor size check Date: Sat, 30 May 2026 18:01:44 +0200 Message-ID: <20260530160230.842161307@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cássio Gabriel commit 26265dd69da32d88a88d21987853cec899d9e21f upstream. The UAC3 cluster descriptor length check in snd_usb_get_audioformat_uac3()was added to make sure that the buffer is large enough for a struct uac3_cluster_header_descriptor before the returned data is cast and used. However, the check uses sizeof(cluster), where cluster is a pointer, not the size of the descriptor header. This makes the validation depend on the architecture pointer size and does not match the intended object size. Check against sizeof(*cluster) instead. Fixes: fb4e2a6e8f28 ("ALSA: usb-audio: Fix out-of-bounds read in snd_usb_get_audioformat_uac3()") Cc: stable@vger.kernel.org Signed-off-by: Cássio Gabriel Link: https://patch.msgid.link/20260424-alsa-usb-uac3-cluster-size-v1-1-99a5808898a3@gmail.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -994,7 +994,7 @@ snd_usb_get_audioformat_uac3(struct snd_ * and request Cluster Descriptor */ wLength = le16_to_cpu(hc_header.wLength); - if (wLength < sizeof(cluster)) + if (wLength < sizeof(*cluster)) return NULL; cluster = kzalloc(wLength, GFP_KERNEL); if (!cluster)