From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9D8B313E34; Sat, 30 May 2026 18:34:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166079; cv=none; b=AaLaeuUx2XoNzYf7WJrQftc/HpBjJ0vJEHL7R0boxC3/bGjBhhqi6dqbSNwuCYQT2SxUUXs/ZK3HgFfDeFhxp8JGzf0ZGlsOknj67bBf3ZeH5FzSc217FiNY313xOn+WZNWUD225HpcT/8zYoK8mVHl6nEN54KSn/3oEqs35tTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166079; c=relaxed/simple; bh=PTGbxerrUnoPw4r9FgOyesOvZ05sC3/iplSEMQBgqno=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AOthPxJtYKadPmFyFF0f/rS1Gy36/Th/X+jpCz5JGNPSgR+9/JA60lrnXkcCk0CtmIDLwl5p2PagUmjRaYc6+gUSqvoQ148hSLXhuxjsKBVJpUK3LmMpS+fB5Ly9m+Eqt4MMfXLkWLyCp96Ovp3Tdj/lWMtgILOH1HV+LpPLvK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mqw/tl5A; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mqw/tl5A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A6781F00893; Sat, 30 May 2026 18:34:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166078; bh=WoVG7fdgp9HvfA+0k1H6JcVZMVTUoNZysHsArPBfpVQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mqw/tl5Am86TjyOBp9+dnTr3SRbCHmPYmT2Q7eAm2q+myeg8e/uJ1ep8/nh3fWUKu /mCU6WGWs7aphQ3oDQuYCwO9ol3YjRTETjQ0s5CqbD9a6wi4PCcDVbDDbbU+0VJWLp hmd0GSWysX6ZuTYExZpPXVEH4grGMlXTVoqCZO1Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Oliver Neukum , Sean Young , Hans Verkuil Subject: [PATCH 5.10 267/589] media: rc: streamzap: Error handling in probe Date: Sat, 30 May 2026 18:02:28 +0200 Message-ID: <20260530160232.006498371@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Oliver Neukum commit 42844992664f03ef9f930e64f7370fa481e9c267 upstream. If submitting the URB fails, the device will be unusable. Probe() must fail. Fixes: 7a569f524dd36 ("V4L/DVB: IR/streamzap: functional in-kernel decoding") Cc: stable@vger.kernel.org Signed-off-by: Oliver Neukum Signed-off-by: Sean Young Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/rc/streamzap.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) --- a/drivers/media/rc/streamzap.c +++ b/drivers/media/rc/streamzap.c @@ -255,9 +255,8 @@ static void streamzap_callback(struct ur case -ESHUTDOWN: /* * this urb is terminated, clean up. - * sz might already be invalid at this point */ - dev_err(sz->dev, "urb terminated, status: %d\n", urb->status); + dev_dbg(sz->dev, "urb terminated, status: %d\n", urb->status); return; default: break; @@ -398,11 +397,16 @@ static int streamzap_probe(struct usb_in usb_set_intfdata(intf, sz); - if (usb_submit_urb(sz->urb_in, GFP_ATOMIC)) + retval = usb_submit_urb(sz->urb_in, GFP_ATOMIC); + if (retval < 0) { dev_err(sz->dev, "urb submit failed\n"); + goto rc_submit_fail; + } return 0; - +rc_submit_fail: + rc_free_device(sz->rdev); + usb_set_intfdata(intf, NULL); rc_dev_fail: usb_free_urb(sz->urb_in); free_buf_in: