From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B84826738C; Sat, 30 May 2026 18:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166277; cv=none; b=Jm459dzmTHMQpFy3xKtwtOPsfgPvvLXc9q1JfjNKa299ZCIJQkLJzBLAnxTH+sdXsNi7s1Y9qgOIyJPhhZZ1SzaqjnqGjcrHjUTs0OOFg6Oz1j1QU7in8+if98w9KgR6UWS4t6l8BtPDuC1cv8xx+mwLDZjtmshPZESYbjpPXvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166277; c=relaxed/simple; bh=tC6+sSBYds9dYOBd43w31d9cEGiPG5ofUMVZNejgpMM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TIvqUu4j2JKT/0gcG1UfI6DNDUTomCeivVIxxbrZOgx594qzl/v5XceCPxkbf8FbvO4RZtjfypdzdIdTE/iCh/uiLwUp6rsjGFek1fWG2eMht55AR27Yc0crx16x12QQMdWuT4vFdpThl3URNSAGUdjqi+1CkxQPAkhR3X3ToHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=O/KM94OD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="O/KM94OD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D7991F00893; Sat, 30 May 2026 18:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166276; bh=gnxRrTPhFpNpJ0gYH8856Nsy61josrwGFk70MkNkLUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=O/KM94ODfDIKjDmRaWSISIPkUZtuH+Z2KVvT4NFQ7vaUhL0Cy7vPG/WdpyLoFFZiG 61ej6AxQwI1J5XdIuP0PgD1Vx+lUAAhjnxL6rVHBMExSPAmN7OczPdTXMjiNVKT2n3 pNsmupgsO1JxHtNNuPwOLq2e1WgBx+nxbBdPcEYs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Christian=20K=C3=B6nig?= , "John B. Moore" , Alex Deucher Subject: [PATCH 5.10 277/589] drm/amdgpu/sdma4: replace BUG_ON with WARN_ON in fence emission Date: Sat, 30 May 2026 18:02:38 +0200 Message-ID: <20260530160232.247689245@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: John B. Moore commit 78d2e624fa073c14970aa097adcf3ea31c157a66 upstream. sdma_v4_0_ring_emit_fence() contains two BUG_ON(addr & 0x3) assertions that verify fence writeback addresses are dword-aligned. These assertions can be reached from unprivileged userspace via crafted DRM_IOCTL_AMDGPU_CS submissions, causing a fatal kernel panic in a scheduler worker thread. Replace both BUG_ON() calls with WARN_ON() to log the condition without crashing the kernel. A misaligned fence address at this point indicates a driver bug, but crashing the kernel is never the correct response when the assertion is reachable from userspace. The CS IOCTL path is the correct place to filter invalid submissions; the ring emission callback is too late to do anything about it. Fixes: 2130f89ced2c ("drm/amdgpu: add SDMA v4.0 implementation (v2)") Reviewed-by: Christian König Signed-off-by: John B. Moore Signed-off-by: Alex Deucher (cherry picked from commit b90250bd933afd1ba94d86d6b13821997b22b18e) Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c @@ -925,7 +925,7 @@ static void sdma_v4_0_ring_emit_fence(st /* write the fence */ amdgpu_ring_write(ring, SDMA_PKT_HEADER_OP(SDMA_OP_FENCE)); /* zero in first two bits */ - BUG_ON(addr & 0x3); + WARN_ON(addr & 0x3); amdgpu_ring_write(ring, lower_32_bits(addr)); amdgpu_ring_write(ring, upper_32_bits(addr)); amdgpu_ring_write(ring, lower_32_bits(seq)); @@ -935,7 +935,7 @@ static void sdma_v4_0_ring_emit_fence(st addr += 4; amdgpu_ring_write(ring, SDMA_PKT_HEADER_OP(SDMA_OP_FENCE)); /* zero in first two bits */ - BUG_ON(addr & 0x3); + WARN_ON(addr & 0x3); amdgpu_ring_write(ring, lower_32_bits(addr)); amdgpu_ring_write(ring, upper_32_bits(addr)); amdgpu_ring_write(ring, upper_32_bits(seq));