From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8961732F770; Sat, 30 May 2026 18:37:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166259; cv=none; b=kPllexhEPD91YIUWXRMJjqvf1tx+NGNWqDg+0BOWBGfCkZ4TgSG5Qsb8uj91H6mofAqaWXnDOVMmgtS3fftH83RmzhjuCPlVCYpvxjnEGOtPYoPDTP/M3xI0ip+AEP6GqVHOTvg9zfA+7xULoRh3fCTiWIPfMF016b6gcK1AT9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166259; c=relaxed/simple; bh=QGOK0wmmoiHBHwwThOJebiTZZRGMarVLKTyCVB0qV3g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ng+9fXb0EGIXg8ikhZUNK4s5CvqRsUmM8IlOjL6IWTRohw5r9XrUNuMnFXwD+kmwHu1imXDsM6qmQFhW+NPQHp+cicHsWz79mlib0g0LIGFgV5HRCIvlWiVqfqwN7SxOWjEs7lNC2Uhsm/FFP3VEx7mMjwWM88sKQf3/uf2yxK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FT9kkDUZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FT9kkDUZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFB451F00893; Sat, 30 May 2026 18:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166258; bh=Bv5DHMh7JRoOInxbvHcZ6xmi5FmfbIYwzPQI2uwN0OU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FT9kkDUZk7i1nwZmfCKHFlIiRKDJ3aeZ4XWxXALs+2G5sdfQ64rz8fpK+BlrrS8o9 kFss+FstviKXJXB/sRRZErT3bxZTROB6XHbpAvbUmOMcfq0lqu0Vrl3VbAeaBZxrZU T1FuMTY+NWOU3T1ufD4bzQzBdu5P7gz7e+807MkM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Yuan Tan , Yifan Wu , Juefei Pu , Xin Liu , Luxing Yin , Jiexun Wang , Ren Wei , Sven Eckelmann Subject: [PATCH 5.10 282/589] batman-adv: reject new tp_meter sessions during teardown Date: Sat, 30 May 2026 18:02:43 +0200 Message-ID: <20260530160232.365826967@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiexun Wang commit 3243543592425beec83d453793e9d27caa0d8e66 upstream. Prevent tp_meter from starting new sender or receiver sessions after mesh_state has left BATADV_MESH_ACTIVE. Fixes: 33a3bb4a3345 ("batman-adv: throughput meter implementation") Cc: stable@kernel.org Reported-by: Yuan Tan Reported-by: Yifan Wu Reported-by: Juefei Pu Reported-by: Xin Liu Co-developed-by: Luxing Yin Signed-off-by: Luxing Yin Signed-off-by: Jiexun Wang Signed-off-by: Ren Wei Signed-off-by: Sven Eckelmann Signed-off-by: Greg Kroah-Hartman --- net/batman-adv/tp_meter.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) --- a/net/batman-adv/tp_meter.c +++ b/net/batman-adv/tp_meter.c @@ -952,6 +952,13 @@ void batadv_tp_start(struct batadv_priv /* look for an already existing test towards this node */ spin_lock_bh(&bat_priv->tp_list_lock); + if (atomic_read(&bat_priv->mesh_state) != BATADV_MESH_ACTIVE) { + spin_unlock_bh(&bat_priv->tp_list_lock); + batadv_tp_batctl_error_notify(BATADV_TP_REASON_DST_UNREACHABLE, + dst, bat_priv, session_cookie); + return; + } + tp_vars = batadv_tp_list_find(bat_priv, dst); if (tp_vars) { spin_unlock_bh(&bat_priv->tp_list_lock); @@ -1336,9 +1343,12 @@ static struct batadv_tp_vars * batadv_tp_init_recv(struct batadv_priv *bat_priv, const struct batadv_icmp_tp_packet *icmp) { - struct batadv_tp_vars *tp_vars; + struct batadv_tp_vars *tp_vars = NULL; spin_lock_bh(&bat_priv->tp_list_lock); + if (atomic_read(&bat_priv->mesh_state) != BATADV_MESH_ACTIVE) + goto out_unlock; + tp_vars = batadv_tp_list_find_session(bat_priv, icmp->orig, icmp->session); if (tp_vars) @@ -1472,6 +1482,9 @@ void batadv_tp_meter_recv(struct batadv_ { struct batadv_icmp_tp_packet *icmp; + if (atomic_read(&bat_priv->mesh_state) != BATADV_MESH_ACTIVE) + goto out; + icmp = (struct batadv_icmp_tp_packet *)skb->data; switch (icmp->subtype) { @@ -1486,6 +1499,8 @@ void batadv_tp_meter_recv(struct batadv_ "Received unknown TP Metric packet type %u\n", icmp->subtype); } + +out: consume_skb(skb); }