From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE1B2349CCF; Sat, 30 May 2026 18:35:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166149; cv=none; b=TiXluPAMyLcLLy1deN0n8G6sYY2JbPg213TI4/Zt5VGY07/BE8BMfF8LjoNRtk043XFpArzz9gJDDrsuKaTeY8jJZt7gdCmCLMAnax/Rtzw9mfKv+oEmNWQMLdCyZSQTHQUwcg/BKd5a5O5cu/AAgDbw5kf3cfTN0TvG/aBCVWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166149; c=relaxed/simple; bh=oe+EVpXyqDKyzWoSMXSh+BJD1klNlejBehDfwDhVfrs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GsgKPJ++JD85UHUBQha/gSlEK2SOkivUc9qdymYtG0LiDl+jrRyZco1qU+RhohIc6rphyHTC41g2jZJjbP+5MRc71MAKAYxh6BQe52oVEIDNCW2POgVkqo3Pv3K6lXr+dq7r61qOvnp7lRwshWcSNoZQeXewrVuP3lTIXvE8s1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FL5RJ+V1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FL5RJ+V1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EF061F00893; Sat, 30 May 2026 18:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166148; bh=cpAVB/Ncf9wx3z4XnFcTMyNkR1zub+Gsbw7lQmg3kPU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FL5RJ+V1iKf4gJ6PRh+WkuqDlboDFaoZFofogKE3Anl8GHPbnAl8dDzZbZyoFfPH0 v9t1QauQsmZfMmAnayByrR1RCrPf8sDO0cqQR5tj3gHRCZsKNdu4UY9TEGW4Q/Ay7A z/ZmPMcU3AUSCVEcPhpYL/pBAJ2uW1fk5pKcxV/g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dudu Lu , Bobby Eshleman , Luigi Leonardi , Stefano Garzarella , "Michael S. Tsirkin" , Paolo Abeni Subject: [PATCH 5.10 289/589] vsock/virtio: fix accept queue count leak on transport mismatch Date: Sat, 30 May 2026 18:02:50 +0200 Message-ID: <20260530160232.535865215@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dudu Lu commit 52bcb57a4e8a0865a76c587c2451906342ae1b2d upstream. virtio_transport_recv_listen() calls sk_acceptq_added() before vsock_assign_transport(). If vsock_assign_transport() fails or selects a different transport, the error path returns without calling sk_acceptq_removed(), permanently incrementing sk_ack_backlog. After approximately backlog+1 such failures, sk_acceptq_is_full() returns true, causing the listener to reject all new connections. Fix by moving sk_acceptq_added() to after the transport validation, matching the pattern used by vmci_transport and hyperv_transport. Fixes: c0cfa2d8a788 ("vsock: add multi-transports support") Signed-off-by: Dudu Lu Reviewed-by: Bobby Eshleman Reviewed-by: Luigi Leonardi Reviewed-by: Stefano Garzarella Acked-by: Michael S. Tsirkin Link: https://patch.msgid.link/20260413131409.19022-1-phx0fer@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Luigi Leonardi Signed-off-by: Greg Kroah-Hartman --- net/vmw_vsock/virtio_transport_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/net/vmw_vsock/virtio_transport_common.c +++ b/net/vmw_vsock/virtio_transport_common.c @@ -1089,8 +1089,6 @@ virtio_transport_recv_listen(struct sock return -ENOMEM; } - sk_acceptq_added(sk); - lock_sock_nested(child, SINGLE_DEPTH_NESTING); child->sk_state = TCP_ESTABLISHED; @@ -1112,6 +1110,7 @@ virtio_transport_recv_listen(struct sock return ret; } + sk_acceptq_added(sk); if (virtio_transport_space_update(child, pkt)) child->sk_write_space(child);