From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D2131A680F; Sat, 30 May 2026 18:35:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166160; cv=none; b=UpVbMa9uyy9UDhIxB1va8TRkcOJcJvNYa/aUddxsuSDw+fK6ifldV4ORStKqVx+5ZIHQ34VBcd5w/emWMk2XM56RapQjGlmzEHbY3xY3gSbJ8XeUKDs2Dx1sYPSVA7o4Z/8ukB3mQaRPuo2cM7cCZouWQf6aX0uutGRqKdP42DE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166160; c=relaxed/simple; bh=fRN+x1qaEjbpQGm0atj9XDmHNhwE+xgFLKQV0gKAZuE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JFa2XIaBI6OWKlSS+akd5Slb+hbxNK4Or2E6Qe2GF8r88y/Rh6+4K9eee24ZHV/1V3OlvVsMz3yAeJMXQtbV0EBGv84a+EnG8x8D2zjR3Ua0tvk2muHKSc1TMHIBzbz1stox6ABL9wF2iao4YB2ecttGvjYt3qK7YfHSr5u6v6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1zel7d1v; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1zel7d1v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61A591F00893; Sat, 30 May 2026 18:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166159; bh=ga/Y89s46SiX6sSNwljbhEq0LIpA15NJurAlPZrYylc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1zel7d1vAaWBULrX+Y0DOPZwk9Y4dqEVZthazTTi8TA2phfDVtn3/7/vFEwEpyK3p hJvClhAPs+Oqb8C7imPUGkJUvrYiyCB/42FsA9QC7OJCcfSusPw9xepFqqEa7egE4H I5r+kRdr/wtCHJPyFxYvwLEDndxQtzR6YmG+iyNg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Christoph=20B=C3=B6hmwalder?= , Christoph Hellwig , Andreas Gruenbacher , Bart Van Assche , Jens Axboe , Sasha Levin Subject: [PATCH 5.10 292/589] drbd: Balance RCU calls in drbd_adm_dump_devices() Date: Sat, 30 May 2026 18:02:53 +0200 Message-ID: <20260530160232.615634090@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bart Van Assche [ Upstream commit 2b31e86387e60b3689339f0f0fbb4d3623d9d494 ] Make drbd_adm_dump_devices() call rcu_read_lock() before rcu_read_unlock() is called. This has been detected by the Clang thread-safety analyzer. Tested-by: Christoph Böhmwalder Reviewed-by: Christoph Hellwig Cc: Andreas Gruenbacher Fixes: a55bbd375d18 ("drbd: Backport the "status" command") Signed-off-by: Bart Van Assche Link: https://patch.msgid.link/20260326214054.284593-1-bvanassche@acm.org Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/drbd/drbd_nl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 54f77b4a0b494..71326e6fb6177 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -3424,8 +3424,10 @@ int drbd_adm_dump_devices(struct sk_buff *skb, struct netlink_callback *cb) if (resource_filter) { retcode = ERR_RES_NOT_KNOWN; resource = drbd_find_resource(nla_data(resource_filter)); - if (!resource) + if (!resource) { + rcu_read_lock(); goto put_result; + } cb->args[0] = (long)resource; } } @@ -3674,8 +3676,10 @@ int drbd_adm_dump_peer_devices(struct sk_buff *skb, struct netlink_callback *cb) if (resource_filter) { retcode = ERR_RES_NOT_KNOWN; resource = drbd_find_resource(nla_data(resource_filter)); - if (!resource) + if (!resource) { + rcu_read_lock(); goto put_result; + } } cb->args[0] = (long)resource; } -- 2.53.0