From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6CF733AD99; Sat, 30 May 2026 18:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166195; cv=none; b=PBJUSlTyizXynqw46GLxRMtkJUrvnr9xnk5jU24mfIHRmGaECtjFtO/rkl0Q5I1xzhDJDCOlJNkRyWAUtfPd6G6sX7nWBqlnUlcxeiNmpCChtwDD1/oNDDvqgwP6QkIW9Y/atshZNNRktz0faePj9NLkib+DHigkYyjdiw+RmeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166195; c=relaxed/simple; bh=cFmrksVrramXpnAvR0smAjbWrjdkVzCiDj14XCGqJSs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FdrVLlTVpJqpLkjP8YQX46KrIF3fYKmaNANlwx/EmeZkkBHAFqOaPrYz+Svcj0pxbnyDzEWRNuMibA9TRIuprDx+aocg9TSv97Zg8LZu3if3VuPJx/BDXadhzwmipdL0865Nwq07JLgfhTpwkN5y6X5dst6muoLLLcvILcF2lyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=B9QWOXha; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="B9QWOXha" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 270E41F00893; Sat, 30 May 2026 18:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166193; bh=3Du4e8XZTQJehibFGotM3VfQLsG8trYeFFx1SQv9yxU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=B9QWOXhaCsqbgUfUWPBNtz3N21MOrQ5cPPkNcx7e+UHipOAV63kc32B1EM5mOCYKN ZmQoTyHihV17Z2aU3UAmVqTVPkyME4YewdfYZWqnXnV9nDESS5Hr/nceLKgok3tHie Tz7iLQMELgL3DFspBYICTuE0hgVqKUcV+tv/yvQI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Duoming Zhou , Ping-Ke Shih , Sasha Levin Subject: [PATCH 5.10 301/589] wifi: rtlwifi: pci: fix possible use-after-free caused by unfinished irq_prepare_bcn_tasklet Date: Sat, 30 May 2026 18:03:02 +0200 Message-ID: <20260530160232.873748764@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Duoming Zhou [ Upstream commit 039cd522dc70151da13329a5e3ae19b1736f468a ] The irq_prepare_bcn_tasklet is initialized in rtl_pci_init() and scheduled when RTL_IMR_BCNINT interrupt is triggered by hardware. But it is never killed in rtl_pci_deinit(). When the rtlwifi card probe fails or is being detached, the ieee80211_hw is deallocated. However, irq_prepare_bcn_tasklet may still be running or pending, leading to use-after-free when the freed ieee80211_hw is accessed in _rtl_pci_prepare_bcn_tasklet(). Similar to irq_tasklet, add tasklet_kill() in rtl_pci_deinit() to ensure that irq_prepare_bcn_tasklet is properly terminated before the ieee80211_hw is released. The issue was identified through static analysis. Fixes: 0c8173385e54 ("rtl8192ce: Add new driver") Signed-off-by: Duoming Zhou Acked-by: Ping-Ke Shih Signed-off-by: Ping-Ke Shih Link: https://patch.msgid.link/20260223045522.48377-1-duoming@zju.edu.cn Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtlwifi/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wireless/realtek/rtlwifi/pci.c index 02821588673e5..3058c8356c292 100644 --- a/drivers/net/wireless/realtek/rtlwifi/pci.c +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c @@ -1675,6 +1675,7 @@ static void rtl_pci_deinit(struct ieee80211_hw *hw) synchronize_irq(rtlpci->pdev->irq); tasklet_kill(&rtlpriv->works.irq_tasklet); + tasklet_kill(&rtlpriv->works.irq_prepare_bcn_tasklet); cancel_work_sync(&rtlpriv->works.lps_change_work); } -- 2.53.0