From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72A0341A8F; Sat, 30 May 2026 18:37:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166225; cv=none; b=PN6DZ0VhgnDaPWkSmJT8nkhPRRtL+2+vEqkLRRu0w+RmzmnBBwLWkbyvxCuHyFhqdIlLHLWkEcXYjpWQpfjKHujP2u90u6ipotWmF4Zs0GTu1fnBN6PTwCU7q0FKaxUejtglzl/7Az4i1HC5FVuVvSR1DMa+FjCRr5IOZlwUZEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166225; c=relaxed/simple; bh=txBQr33jFlMsodGP2jdQXgfkfGheht1VX+g8S3TvnPA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tk3hCJOtt7uenUTzSWJ4sf71o4JAkNakVTjczQZy0wNUXbNv0298DTKAW+4zIMZIS61WSwO0c3BakGCmBaliLqymCo9aQpnNQBILVnYs9MA/qPRYdTgxNUw4HFISWcBhP8QgaNYVvcc8wMZdZ6/o+pjcPB0dkr3av76a9NLS0HU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PRNYAiAj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PRNYAiAj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5EF21F00898; Sat, 30 May 2026 18:37:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166224; bh=RAqeREyqgkvrRNF9nA37av69O+wPo6oZS+0TPttRo7s=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=PRNYAiAjAFXK/VAzEgK5cJ/kF9+AHBNUtXGN03eZzQoV6ch48o6WbbmgnHxf0HQlp 8ujeY+xFHlEjEcTnDRRIKjokn/KMvlYa/g6r7FcRZnFdyefFabGv8f4UfpXUZNybNN TzgbtezgLoqJLgQTGaH+Q+pC3hN2KKi1PWyerIwY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+ecdb8c9878a81eb21e54@syzkaller.appspotmail.com, Mashiro Chen , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 309/589] net: hamradio: 6pack: fix uninit-value in sixpack_receive_buf Date: Sat, 30 May 2026 18:03:10 +0200 Message-ID: <20260530160233.071825146@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mashiro Chen [ Upstream commit bf9a38803b2626b01cc769aaf13485d8650f576f ] sixpack_receive_buf() does not properly skip bytes with TTY error flags. The while loop iterates through the flags buffer but never advances the data pointer (cp), and passes the original count (including error bytes) to sixpack_decode(). This causes sixpack_decode() to process bytes that should have been skipped due to TTY errors. The TTY layer does not guarantee that cp[i] holds a meaningful value when fp[i] is set, so passing those positions to sixpack_decode() results in KMSAN reporting an uninit-value read. Fix this by processing bytes one at a time, advancing cp on each iteration, and only passing valid (non-error) bytes to sixpack_decode(). This matches the pattern used by slip_receive_buf() and mkiss_receive_buf() for the same purpose. Reported-by: syzbot+ecdb8c9878a81eb21e54@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=ecdb8c9878a81eb21e54 Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Mashiro Chen Reviewed-by: Simon Horman Link: https://patch.msgid.link/20260407173101.107352-1-mashiro.chen@mailbox.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/hamradio/6pack.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c index 1964ccbb62c6f..36521f260971a 100644 --- a/drivers/net/hamradio/6pack.c +++ b/drivers/net/hamradio/6pack.c @@ -435,7 +435,6 @@ static void sixpack_receive_buf(struct tty_struct *tty, const unsigned char *cp, char *fp, int count) { struct sixpack *sp; - size_t count1; if (!count) return; @@ -445,16 +444,16 @@ static void sixpack_receive_buf(struct tty_struct *tty, return; /* Read the characters out of the buffer */ - count1 = count; - while (count) { - count--; + while (count--) { if (fp && *fp++) { if (!test_and_set_bit(SIXPF_ERROR, &sp->flags)) sp->dev->stats.rx_errors++; + cp++; continue; } + sixpack_decode(sp, cp, 1); + cp++; } - sixpack_decode(sp, cp, count1); sp_put(sp); tty_unthrottle(tty); -- 2.53.0