From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF84A26738C; Sat, 30 May 2026 18:40:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166415; cv=none; b=CL/YtGzTbs0wBg6ZSsG6jG0cTVly+KYT5U+Ud3SKsCbWV4iq9QX6mTCIgTCF9BbfogorNAMh5HCl63M0pRfz7Ge1WUnMx5lHZ/0t/Oujq9cq8s0O3KykZLh+tXPi61iMuMM8qHq2PNd78Hnwf+2zKFSVqLNPgtEjXhtsBY+6m94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166415; c=relaxed/simple; bh=ANKGH1ZXQB+2hM3tnIyOpZ/YQaOF4Zu+UaXfK2Z/tz8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dfzjUSty1Fb2pBmFGwqSqG+ZsZeaSQ4JKMDlSwdlHH1mdQP0fA5CGgLadmQuqVwfa3vjBK7nCnm85Xd8Sq8jewXmeX8pQLfD64ct90S4yplsEkoWTW/F2GTDz78d1rLMy+0y/3pM+Oj7wOORmBpYFTm6GOZLTAcRiRYy21JiLkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tVLZvbQU; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tVLZvbQU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48D8C1F00893; Sat, 30 May 2026 18:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166414; bh=lhO0C1j0uKkzLhdGZFkW4J6DZQ+h/7YKEdmNzeW1Ud0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tVLZvbQUHuUdzSL04G1Bh8Llvoz+dVm5AXxSO9pHhB9OG0ABam0S6EE11FGLoJaAU c0mPTXaP7uL4TOZZE3uq5fUh39Y5dPAjSEWzCe7IODUeMVLKwC35Hea6hNh5y+MFh5 mvRwwus5Otfv8cvuIqmWfywj8rEHPAj9enwD9jrQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Junrui Luo , Yuhao Jiang , Joseph Qi , Mark Fasheh , Joel Becker , Junxiao Bi , Changwei Ge , Jun Piao , Heming Zhao , Andrew Morton , Sasha Levin Subject: [PATCH 5.10 367/589] ocfs2/dlm: fix off-by-one in dlm_match_regions() region comparison Date: Sat, 30 May 2026 18:04:08 +0200 Message-ID: <20260530160234.478122455@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Junrui Luo [ Upstream commit 01b61e8dda9b0fdb0d4cda43de25f4e390554d7b ] The local-vs-remote region comparison loop uses '<=' instead of '<', causing it to read one entry past the valid range of qr_regions. The other loops in the same function correctly use '<'. Fix the loop condition to use '<' for consistency and correctness. Link: https://lkml.kernel.org/r/SYBPR01MB78813DA26B50EC5E01F00566AF7BA@SYBPR01MB7881.ausprd01.prod.outlook.com Fixes: ea2034416b54 ("ocfs2/dlm: Add message DLM_QUERY_REGION") Signed-off-by: Junrui Luo Reported-by: Yuhao Jiang Reviewed-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Jun Piao Cc: Heming Zhao Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- fs/ocfs2/dlm/dlmdomain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c index 6881961dbde87..5201071c0080d 100644 --- a/fs/ocfs2/dlm/dlmdomain.c +++ b/fs/ocfs2/dlm/dlmdomain.c @@ -1004,7 +1004,7 @@ static int dlm_match_regions(struct dlm_ctxt *dlm, for (i = 0; i < localnr; ++i) { foundit = 0; r = remote; - for (j = 0; j <= qr->qr_numregions; ++j) { + for (j = 0; j < qr->qr_numregions; ++j) { if (!memcmp(l, r, O2HB_MAX_REGION_NAME_LEN)) { foundit = 1; break; -- 2.53.0