From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12E3D25B08A; Sat, 30 May 2026 18:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166452; cv=none; b=GhUnAYAElbRSSjI530GP5AkWb/osP64fKKrQAXZMHY4RA5YAyHJavD7crYKUoynM1wO+f0ja1SxgykzHaLxf5E+bzG241En85sW7yRzZPlVVoXssKwNO7uJimhriPBw94zyifT5JHMpOc5YVH+HaEgg5j+Obh6CaVebktqFSevc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166452; c=relaxed/simple; bh=QVFDL/bd7kGqS8jBbp8nZJGTVmt1AjHhBmRq2Ge7GUo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cwmuy8H5lXgHOp0rBvds220spJqVnLzljK3RfwI3qCHxhTRHTz0Qs7Cm7/MP5JX/t6lHzdqCmfQxeaJ1wyJjYJf7or0H048r/CX4hM7eB9ZtOPSqwubt0dw+dgao2Hr0kCt/UuoHYgireRbo9YX0wm+XGsE0Ftt6xyOmbeUPPgY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=X830d/Yu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="X830d/Yu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54CA91F00893; Sat, 30 May 2026 18:40:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166451; bh=a7vuucy9sE8b9S2XR5WFTr3+gf6VtsoZs5J/rJUbQE4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=X830d/YuZZZA4Z26hPHDung1CVWuh8t08h04aJqhEisd31OkkTVQ99ozUA5XM37oB JCAoRWHn78Cq4DAfQqi2nw/TmgE6g9dZwMCb7LLPXY/MvfChhnWioRbHqi4L+9Z+/8 Ugmbp/LveteKcdR7p+g/abwAN/uY2RroSct4eZKY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chen Ni , Linus Walleij , Miquel Raynal , Sasha Levin Subject: [PATCH 5.10 377/589] mtd: physmap_of_gemini: Fix disabled pinctrl state check Date: Sat, 30 May 2026 18:04:18 +0200 Message-ID: <20260530160234.718589075@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chen Ni [ Upstream commit b7c0982184b0661f5b1b805f3a56f1bd3757b63e ] The condition for checking the disabled pinctrl state incorrectly checks gf->enabled_state instead of gf->disabled_state. This causes misleading error messages and could lead to incorrect behavior when only one of the pinctrl states is defined. Fix the condition to properly check gf->disabled_state. Fixes: 9d3b5086f6d4 ("mtd: physmap_of_gemini: Handle pin control") Signed-off-by: Chen Ni Reviewed-by: Linus Walleij Signed-off-by: Miquel Raynal Signed-off-by: Sasha Levin --- drivers/mtd/maps/physmap-gemini.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/maps/physmap-gemini.c b/drivers/mtd/maps/physmap-gemini.c index d4a46e159d38f..8d5b791dd08d4 100644 --- a/drivers/mtd/maps/physmap-gemini.c +++ b/drivers/mtd/maps/physmap-gemini.c @@ -181,7 +181,7 @@ int of_flash_probe_gemini(struct platform_device *pdev, dev_err(dev, "no enabled pin control state\n"); gf->disabled_state = pinctrl_lookup_state(gf->p, "disabled"); - if (IS_ERR(gf->enabled_state)) { + if (IS_ERR(gf->disabled_state)) { dev_err(dev, "no disabled pin control state\n"); } else { ret = pinctrl_select_state(gf->p, gf->disabled_state); -- 2.53.0