From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92D3B344DB9; Sat, 30 May 2026 18:43:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166618; cv=none; b=AlcDBQnp6UZZieB9F3W7iNX3eSSHMeGriyO3EAlZhr/zayNwyJWRrHQv2peQJciGq/wOQ6TxrQJYOMy20xrzPJZHcAZ9ywEpCcPqdmJRbwP7pdv3eBkU6OV/55BC0nJQ6KoqA0bdR67lhacR1opcYOpeyNoM22SeAnddz6jghtk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166618; c=relaxed/simple; bh=vlvlUb3xk1qceuyV9hUtiGxfWhk5vtyXF3JDqbxpo+g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a46YVR5k5O3/0oUzVPwYSmLYyMd0cc2R+2VVcSWOS+/2YWz/ohiVEQzNss5NuvIU1nOvtgdLDu6QBaPfElb6E4iEyE3643IaMV7h/aA8d/MXyQRVZmCDleqwuibOXnFqD0Suv16BqFlKhndq2/73baG0NCd+jEaTIVK27Kuyf/A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TrcWaJh2; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TrcWaJh2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC4751F00893; Sat, 30 May 2026 18:43:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166617; bh=LWQfYAPj87ZmUe7/DDKa8Pkt23rXym3RvdPrXPrFJtE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=TrcWaJh2DHUXxxuqQID5t8yGRKzNMTzoKSs9potDYPbPq8LRlyyJWiMsi7Dxm3VJr ToOBw/BNLJRgEOp9PbvAOqqfijjmOy4cKLiymixttEG62bHzmyb9Mox8oU7ohixuVv I6WadDaD1XN8Lk8xWusmC9mQhFYt+tD+zBEKpAaM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Vladimir Oltean , Kurt Kanzenbach , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 419/589] net/sched: taprio: continue with other TXQs if one dequeue() failed Date: Sat, 30 May 2026 18:05:00 +0200 Message-ID: <20260530160235.755614136@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Vladimir Oltean [ Upstream commit 1638bbbe4ececa615b273497d347d59ad71060a2 ] This changes the handling of an unlikely condition to not stop dequeuing if taprio failed to dequeue the peeked skb in taprio_dequeue(). I've no idea when this can happen, but the only side effect seems to be that the atomic_sub_return() call right above will have consumed some budget. This isn't a big deal, since either that made us remain without any budget (and therefore, we'd exit on the next peeked skb anyway), or we could send some packets from other TXQs. I'm making this change because in a future patch I'll be refactoring the dequeue procedure to simplify it, and this corner case will have to go away. Signed-off-by: Vladimir Oltean Reviewed-by: Kurt Kanzenbach Signed-off-by: David S. Miller Stable-dep-of: 105425b1969c ("net/sched: taprio: fix use-after-free in advance_sched() on schedule switch") Signed-off-by: Sasha Levin --- net/sched/sch_taprio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index 62251ae4f4407..8fe4dea86ad98 100644 --- a/net/sched/sch_taprio.c +++ b/net/sched/sch_taprio.c @@ -618,7 +618,7 @@ static struct sk_buff *taprio_dequeue(struct Qdisc *sch) skb = child->ops->dequeue(child); if (unlikely(!skb)) - goto done; + continue; skb_found: qdisc_bstats_update(sch, skb); -- 2.53.0