From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7494F238D52; Sat, 30 May 2026 18:46:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166768; cv=none; b=FEJgBc7tC18o2muSt/QjtGazWNigW7LvYEmAGfxKT9Q520pl/R/NL6pLKf2TEtmPySKF5aDY15th0APUBsW2Y7hOYvyuJnqsfgI2FeHiw3vmEqqg8GUFJkE+LNhdkTDLeUFIbsMor/HCsiE4zVrWjpqlmwfyEJPadwUztpUILbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166768; c=relaxed/simple; bh=mqBhXEIqDTeW8d69FTh4kDzUVZ2LVSK1DHct5CRKhOc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iDGU/Kq3m1YiJIO7xXUAuHVEVciCltXWmh2siw8Q00ODuj1L9o3aHQ8AEaN+2ZLb2qT6KCW29DU7zvGcsebAPeeh3SXx2re19GVlu9RdOeDg6YSq8TkTHPfJoMFNgyErvZP/ZJJHNm2cejJZcgaBfpJbAt0LLSc2D5Upv2NBuEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CKvTg9Qt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CKvTg9Qt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95ACF1F00898; Sat, 30 May 2026 18:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166767; bh=SkTvnonTr69K138JbaawG6b1tIt+0kAcV8gtNtqs3jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CKvTg9Qtna2NygM3seh1/Um+Q3WNd0VLT6TslanrULZfNrSyUHKOL13QW85nD6iXT aWyqDs/TchLtqAVNBcWhheOVa7e6VH+kQuImSa0+JiFHzMtxBMDgU2oYQh1vjtaLii kOAhszwa/q9I9GZt4XNadF/hWVfl1V9iAuVTx2J4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Qu Wenruo , Mark Harmstone , David Sterba , Sasha Levin Subject: [PATCH 5.10 464/589] btrfs: fix double-decrement of bytes_may_use in submit_one_async_extent() Date: Sat, 30 May 2026 18:05:45 +0200 Message-ID: <20260530160236.862566526@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mark Harmstone [ Upstream commit 82323b1a7088b7a5c3e528a5d634bff447fa286f ] submit_one_async_extent() calls btrfs_reserve_extent(), which decrements bytes_may_use. If the call btrfs_create_io_em() fails, we jump to out_free_reserve, which calls extent_clear_unlock_delalloc(). Because we're specifying EXTENT_DO_ACCOUNTING, i.e. EXTENT_CLEAR_META_RESV | EXTENT_CLEAR_DATA_RESV, this decreases bytes_may_use again. This can lead to problems later on, as an initial write can fail only for the writeback to silently ENOSPC. Fix this by replacing EXTENT_DO_ACCOUNTING with EXTENT_CLEAR_META_RESV. This parallels a4fe134fc1d8eb ("btrfs: fix a double release on reserved extents in cow_one_range()"), which is the same fix in cow_one_range(). Fixes: 151a41bc46df ("Btrfs: fix what bits we clear when erroring out from delalloc") Reviewed-by: Qu Wenruo Signed-off-by: Mark Harmstone Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 6d2d799a0ed25..3631d05746073 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -918,7 +918,7 @@ static noinline void submit_compressed_extents(struct async_chunk *async_chunk) async_extent->ram_size - 1, NULL, EXTENT_LOCKED | EXTENT_DELALLOC | EXTENT_DELALLOC_NEW | - EXTENT_DEFRAG | EXTENT_DO_ACCOUNTING, + EXTENT_DEFRAG | EXTENT_CLEAR_META_RESV, PAGE_UNLOCK | PAGE_START_WRITEBACK | PAGE_END_WRITEBACK | PAGE_SET_ERROR); free_async_extent_pages(async_extent); -- 2.53.0