From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 175E62E7398; Sat, 30 May 2026 18:50:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780167025; cv=none; b=VpphgACCIhjU/j7ODXX+kzqlg5YanELu7oaiTDTo0YoqVMIeEIL6xHD/xMP5C7morfHDY+78LhW9FmyVZltRRgFkB/D2KU9s3gz4S3v2Uu1jW/E2ujKoZ3Rj146DmCmExYrrljVK/2tOxSoHN/Ps2efKCavL2OU/knAP/FdTzWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780167025; c=relaxed/simple; bh=clpeoREoidau1ZxPu8DsXvPCE+NVF2TYkkAQCxe1rps=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OMizOrsj1LizIoy4wnojYB1JYc0+Ha44EuoHyY554XAourTWw+NN4vaqcib0nHmTf86kM9SJRPwa1XiO5ULp+XNaSsnYXYM1SMgusPCe3E1V5f/G2sdMVI6/dO/5VG/RvOlEBka43hTAoNPXtr+AW7AK42kxe5GE8yjFiMqB/1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dnlkBEWQ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dnlkBEWQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DDDF1F00893; Sat, 30 May 2026 18:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780167024; bh=qcDXkLt1LjK9p1JeZ0iwPWkp6pGvhH9A2KjNym5IQ7E=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dnlkBEWQjVdkGHvjgc0XN/3S7t9/iIlSUz1Tbv9WusKC/shhDQSCcwCgKkfS4rsai FYW4KrwuzEWEgOkeafVT905hSES5dUDVl9unBv/B7qLxDoXLV9jcddGWZ6swdU1Tw1 hOb9WfLCU6DWMsUsUhok5mvmW/4MvSj1kjOcSfcI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Raphael Zimmer , Ilya Dryomov Subject: [PATCH 5.10 512/589] libceph: Fix potential out-of-bounds access in osdmap_decode() Date: Sat, 30 May 2026 18:06:33 +0200 Message-ID: <20260530160238.089614500@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Raphael Zimmer commit 35d0ed82d03e5ee77ea4f31f20e29562a7721649 upstream. When decoding osd_state and osd_weight from an incoming osdmap in osdmap_decode(), both are decoded for each osd, i.e., map->max_osd times. The ceph_decode_need() check only accounts for sizeof(*map->osd_weight) once. This can potentially result in an out-of-bounds memory access if the incoming message is corrupted such that the max_osd value exceeds the actual content of the osdmap message. This patch fixes the issue by changing the corresponding part in the ceph_decode_need() check to account for map->max_osd*sizeof(*map->osd_weight). Cc: stable@vger.kernel.org Fixes: dcbc919a5dc8 ("libceph: switch osdmap decoding to use ceph_decode_entity_addr") Signed-off-by: Raphael Zimmer Reviewed-by: Ilya Dryomov Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- net/ceph/osdmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/ceph/osdmap.c +++ b/net/ceph/osdmap.c @@ -1688,7 +1688,7 @@ static int osdmap_decode(void **p, void ceph_decode_need(p, end, 3*sizeof(u32) + map->max_osd*(struct_v >= 5 ? sizeof(u32) : sizeof(u8)) + - sizeof(*map->osd_weight), e_inval); + map->max_osd*sizeof(*map->osd_weight), e_inval); if (ceph_decode_32(p) != map->max_osd) goto e_inval;