From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F3A21A9F90; Sat, 30 May 2026 18:48:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166932; cv=none; b=CgYkl+CV3WDDOW4nCfVZ/Cxwa1rzi2LoacKl7mreJkUhv0nANi9JYKZHqMRqdaphrese1ZpcLcdXYRC0EsBqhzfgmQ9PFIPGwG2ZIBxqo3BTeciQ5HuCqiWaz7YjpmGAZe8T8kB3UcQIDp2ShOfM1ae9uxcY40iWlqqefL/MipM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166932; c=relaxed/simple; bh=MfpFwaU5zT/jV5SPP1fOQZSMfwBcDoKqhWP3Wlhqfo4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aTltF1I149RaQQ9hgGw47QH+ElvKWpX02E93BqJZveBYSiT3G3nYuuBKNw0zU/qIxUagxVSrmthUpQgPi1lZ889qcAIT5CPHMMb7Q2FTy1bJh0vVe/a8dMm6gNGleHqqpRckRZDkFe0ZpbrPigAKTXm7lIzZDnZwGtB5TSBPJ1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=D0nvikqy; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="D0nvikqy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B90061F00893; Sat, 30 May 2026 18:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166931; bh=600rPr3yhuv0o/KUndM+Wm0B5zQen+9lAu11qYxAhUE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=D0nvikqy0vEdlLxmb52E2vcxAW0G0oxnPa1/I4hEKYE7U7wY4ffXGsLzmXpOdsZDM eI2yCvO+ftJZcRI3aoxIr4IDNw2auetMNV3pZG5NsinNHQTDeeTLufcv5/e+bVm5ev bMM/Op4j6nUXLBlfNV+LFThk8JE1gh0fPwF1U+wM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Raphael Zimmer , Ilya Dryomov Subject: [PATCH 5.10 515/589] libceph: handle rbtree insertion error in decode_choose_args() Date: Sat, 30 May 2026 18:06:36 +0200 Message-ID: <20260530160238.166550473@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Raphael Zimmer commit d289478cfc0bcf81c7914200d6abdcb78bd04ded upstream. A message of type CEPH_MSG_OSD_MAP contains an OSD map that itself contains a CRUSH map. The received CRUSH map may optionally contain choose_args that get decoded in decode_choose_args(). In this function, num_choose_arg_maps is read from the message, and a corresponding number of crush_choose_arg_maps gets decoded afterwards. Each crush_choose_arg_map has a choose_args_index, which serves as the key when inserting it into the choose_args rbtree of the decoded crush_map. If a (potentially corrupted) message contains two crush_choose_arg_maps with the same index, the assertion in insert_choose_arg_map() triggers a kernel BUG when trying to insert the second crush_choose_arg_map. This patch fixes the issue by switching to the non-asserting rbtree insertion function and rejecting the message if the insertion fails. [ idryomov: changelog ] Cc: stable@vger.kernel.org Signed-off-by: Raphael Zimmer Reviewed-by: Ilya Dryomov Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- net/ceph/osdmap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/net/ceph/osdmap.c +++ b/net/ceph/osdmap.c @@ -379,7 +379,10 @@ static int decode_choose_args(void **p, goto e_inval; } - insert_choose_arg_map(&c->choose_args, arg_map); + if (!__insert_choose_arg_map(&c->choose_args, arg_map)) { + ret = -EEXIST; + goto fail; + } } return 0;