From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E84D137750; Sat, 30 May 2026 18:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166973; cv=none; b=daAQBQJaxsQrMT+B67pK50sLjgy9bin2B4+UpZdNY2rZJPA9C7wNGzSVaHwzJMMJAKhjaOiNMi9Jg5vPjM7z6/6WKYvsirRx9oQxfUdNm1BgwqTmDZ6HGG//A8q6jeAMH2EMCzpmpWRKo2h3pbxDnX/M3HcXqXTP7nnG0NKoshA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780166973; c=relaxed/simple; bh=/qkMHi1i12j/VnxbRWp0i49k6BwGujx+5N9eApPaMIc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ceWmYxbS75w0Sl7TKTtNSRrU7Vfb8ODqCxaP6R5n6sBP9Xf7Cnyamm4zBFYMztC4quHPeFU3hNCNIrbY0O14NKuPwtmoAv7YZHHygIdvI7kHLumY4L7Yp8QvWz+TSjaWp2FzyXSnkmw7NX+R9Y7WeOBn8r94YCiHWZuDywWtj3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VTRVfwAF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VTRVfwAF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 704C91F00893; Sat, 30 May 2026 18:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780166972; bh=f7mWcQf9NebD+REBUkxJE2jDPgubZFx0tgylEYk33jk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VTRVfwAFAUL9OqU3bWFi9rdFlCYCPWhYuK3WNqaSw0anjdL4wI3nc0aYufMXoYyWo piQPF3DF2Bu7KANeoJqcB/MER2f0uqDopaNZp/RhYXK/9KN7cJtRYoK+TsoANdk6AS /AabltA4PS7VJ/f2OZNAMrZirZvF9jmIN3sVybTo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Howells , Asim Viladi Oglu Manizada , Steve French , Salvatore Bonaccorso Subject: [PATCH 5.10 526/589] smb: client: reject userspace cifs.spnego descriptions Date: Sat, 30 May 2026 18:06:47 +0200 Message-ID: <20260530160238.502197146@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Asim Viladi Oglu Manizada commit 3da1fdf4efbc490041eb4f836bf596201203f8f2 upstream. cifs.spnego key descriptions contain authority-bearing fields such as pid, uid, creduid, and upcall_target that cifs.upcall treats as kernel-originating inputs. However, userspace can also create keys of this type through request_key(2) or add_key(2), allowing those fields to be supplied without CIFS origin. Only accept cifs.spnego descriptions while CIFS is using its private spnego_cred to request the key. Fixes: f1d662a7d5e5 ("[CIFS] Add upcall files for cifs to use spnego/kerberos") Assisted-by: avom-custom-harness:gpt-5.5-qwen3.6-mod-mix Reviewed-by: David Howells Signed-off-by: Asim Viladi Oglu Manizada Signed-off-by: Steve French [Salvatore Bonaccorso: Apply changes to fs/cifs/cifs_spnego.c instead of fs/smb/client/cifs_spnego.c before 38c8a9a52082 ("smb: move client and server files to common directory fs/smb") in v6.4-rc1 and backported to v6.1.36] Signed-off-by: Salvatore Bonaccorso Signed-off-by: Greg Kroah-Hartman --- fs/cifs/cifs_spnego.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) --- a/fs/cifs/cifs_spnego.c +++ b/fs/cifs/cifs_spnego.c @@ -20,6 +20,7 @@ */ #include +#include #include #include #include @@ -58,12 +59,27 @@ cifs_spnego_key_destroy(struct key *key) kfree(key->payload.data[0]); } +static int +cifs_spnego_key_vet_description(const char *description) +{ + /* + * cifs.spnego descriptions are authority-bearing inputs to cifs.upcall. + * They are only valid when produced by CIFS while using the private + * spnego_cred installed below. Do not let userspace create this type + * of key through request_key(2)/add_key(2), since the helper treats + * pid/uid/creduid/upcall_target as kernel-originating fields. + */ + if (current_cred() != spnego_cred) + return -EPERM; + return 0; +} /* * keytype for CIFS spnego keys */ struct key_type cifs_spnego_key_type = { .name = "cifs.spnego", + .vet_description = cifs_spnego_key_vet_description, .instantiate = cifs_spnego_key_instantiate, .destroy = cifs_spnego_key_destroy, .describe = user_describe,