From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51C681D63E4; Sat, 30 May 2026 18:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780167007; cv=none; b=uX5kmJAcTDzZ0d3FQxqT0rpbiKFUNec3OkoiyUa2XXMx6HE0+lxIXAKE+ckQZ7Zhg+PigSCznqVedttP+ffxy0n+b9nhMfkvb9jDogqGA+qi4/jwUhFzUSBJahTDObW6RPQtvUNNjyO9FCkIkC5tBvHTTXNNyI5if2K54eXkTKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780167007; c=relaxed/simple; bh=ixRj3TShjBaW9WvWgaK7fhkc/JjEI+JFbwbMxPa7pAw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kCsLauMCbX8RYnUT8qgmDJZg0YjxDMgkFLEyAnFv8ILeoJNNw64nxfuOQRJM8dVUjv8QR3Nh0CHz+efVzhg9jwu1UZxb+oEv2jGNDlfSTVv/yjY1wZr84+DxQXBSayTcXEim7ZnMNW0nqINofB2PsFYkl17oCJ+T27XShGLq8Zk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mIxPIH/Z; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mIxPIH/Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87A9F1F00893; Sat, 30 May 2026 18:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780167006; bh=2vslqwT4U23REHm2s7c1N4CCPrE+hpwMRPY4whcq92o=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mIxPIH/ZqT4cYl0ZRKinnrx96VygX7c2tpaZ3rzGAxdoZRamuUlsRGJCVUoKMRyJn kVSqJ2euUgP6id2QSnXkmu8XXmdmhsZNfjVa4hkcjYRIr4yxvBmIWKdWHCVa+TkaMm y3AOnv0yReGyOFjg1Co5GOZAiewyUpe+7w8wDHHQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Yuan Tan , Yifan Wu , Juefei Pu , Xin Liu , Zhengchuan Liang , Ren Wei , Pablo Neira Ayuso Subject: [PATCH 5.10 535/589] netfilter: ip6t_hbh: reject oversized option lists Date: Sat, 30 May 2026 18:06:56 +0200 Message-ID: <20260530160238.757949090@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhengchuan Liang commit 4322dcde6b4173c2d8e8e6118ed290794263bcc8 upstream. struct ip6t_opts stores at most IP6T_OPTS_OPTSNR option descriptors, but hbh_mt6_check() does not reject larger optsnr values supplied from userspace. Validate optsnr in the rule setup path so only match data that fits the fixed-size opts array can be installed. This follows the existing xtables pattern of rejecting invalid user-provided counts in checkentry() and keeps the packet matching path unchanged. `struct ip6t_opts` has a fixed `opts[IP6T_OPTS_OPTSNR]` array, where `IP6T_OPTS_OPTSNR` is 16, then off-by-one array access is possible: [ 137.924693][ T8692] UBSAN: array-index-out-of-bounds in ../net/ipv6/netfilter/ip6t_hbh.c:110:29 [ 137.926167][ T8692] index 16 is out of range for type '__u16 [16]' Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@kernel.org Reported-by: Yuan Tan Reported-by: Yifan Wu Reported-by: Juefei Pu Reported-by: Xin Liu Signed-off-by: Zhengchuan Liang Signed-off-by: Ren Wei Signed-off-by: Pablo Neira Ayuso Signed-off-by: Greg Kroah-Hartman --- net/ipv6/netfilter/ip6t_hbh.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/net/ipv6/netfilter/ip6t_hbh.c +++ b/net/ipv6/netfilter/ip6t_hbh.c @@ -168,6 +168,10 @@ static int hbh_mt6_check(const struct xt pr_debug("unknown flags %X\n", optsinfo->invflags); return -EINVAL; } + if (optsinfo->optsnr > IP6T_OPTS_OPTSNR) { + pr_debug("too many supported opts specified\n"); + return -EINVAL; + } if (optsinfo->flags & IP6T_OPTS_NSTRICT) { pr_debug("Not strict - not implemented");