From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48B8123C4F2; Sat, 30 May 2026 18:52:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780167148; cv=none; b=osYvL7Iqg8/cyNSu10xQyIcdLDsr8IXcWGwASCkrIHCW3KuonmfALVXy0qGVa56F04PTOOxpH9ojaQQoDP1Jidwj/mOxPAvPoNUHfFSTA4Qzg+ZesY7MUa3iK6dGwXaOJlelY5XODORlsgmZtGQYZUqbweW5oJlg33BcnsYkje8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780167148; c=relaxed/simple; bh=Gks3K5ptxLUnju7e9LkpwEHmghO2+aNAqWgWhvMfbII=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XIgckLNFaLcVaBqo9tiqn6DicYc//OakghtIit/rS+d5cB+hhEKFeh/C94DIkjyaf9RWgcI/CdLAs5FkeKxROVhnVF3SHrP/n95BT4T1NGEKLB+52Rg4Q2g5LvFsBZtuj/4O17MC5VZ8Ilo/a21+cr6gfsldrl+k9VB54Uo/X24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LE1kRFdd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LE1kRFdd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DA8B1F00893; Sat, 30 May 2026 18:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780167147; bh=ryvCJ8ej21G2SL7HizmSqHza1vZxfJPY+EuoHWhDsV8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LE1kRFddFYatC/dIgsLXkKmdYXReixGAWr5u6Ah1N4zpfQu+s50n2C42fErIiP2Gi j+x3KqGxfFr/pbHf77Xw/jJraXp4qhZ4UZ/BtDB+WzSqidbW/G0wRUixz7F3iDIY4g /KjujaVuWDDz1jvntADwjrgkgEgOVK6ZxnZH7LVI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, John Walker , Johannes Berg Subject: [PATCH 5.10 542/589] wifi: cfg80211: advance loop vars in cfg80211_merge_profile() Date: Sat, 30 May 2026 18:07:03 +0200 Message-ID: <20260530160238.925359839@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: John Walker commit 7666dbb1bacc4ba522b96740cba7283d243d16e1 upstream. cfg80211_merge_profile() reassembles a Multi-BSSID non-transmitted BSS profile that has been split across multiple consecutive MBSSID elements. Its while-loop calls cfg80211_get_profile_continuation(ie, ielen, mbssid_elem, sub_elem) but never advances mbssid_elem or sub_elem inside the body. Each iteration therefore searches for a continuation that follows the same fixed pair; the helper returns the same next_mbssid; and the same next_sub bytes are memcpy()'d into merged_ie at a growing offset until the buffer fills. Advance both mbssid_elem and sub_elem to the just-consumed continuation so the next call to cfg80211_get_profile_continuation() searches for a further continuation beyond it (or returns NULL when none exists). A specially-crafted malicious beacon can take advantage of this bug to cause the kernel to spend an excessive amount of time in cfg80211_merge_profile (up to as much as 2ms per beacon received), which could theoretically be abused in some way. Cc: stable@vger.kernel.org Fixes: fe806e4992c9 ("cfg80211: support profile split between elements") Signed-off-by: John Walker Link: https://patch.msgid.link/20260507230720.64783-1-johnwalker0@gmail.com Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- net/wireless/scan.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/wireless/scan.c +++ b/net/wireless/scan.c @@ -2176,6 +2176,9 @@ size_t cfg80211_merge_profile(const u8 * memcpy(merged_ie + copied_len, next_sub->data, next_sub->datalen); copied_len += next_sub->datalen; + + mbssid_elem = next_mbssid; + sub_elem = next_sub; } return copied_len;