From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 504B12857FA; Sat, 30 May 2026 18:52:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780167153; cv=none; b=FOszsIECGKOOdUsJscBeeslUA0gLw2/yrMDyjpP86DfLv01aMoLi/ZF32Ze1y2yE61bMW+W8o4fJf7X+jkte/wD1eyAD/7fV7CjRVvdvX9rodK4hMZt9UdrBULU35kIc53+9LdzpBKDWUQhXWPPdspC9qN/V7IvEgVuSlWmsEIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780167153; c=relaxed/simple; bh=ulVuhOJbnQJQOSf04clh6B0l6iCZ6Cb6h4fTxzyF+Bc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YZVncFJdp2amhWCkOef8flnf+cdPdkrSsSs2qvYcKztQLOVS5ccDoMIsdlYMuyo93YFlXY1DxcJQcfWtWnxwV3WNMYB3FddsMudnIfwXtnPqaVq/yG1htXovqYG7/lispwFdeK6uwhhxoReh4MJkNLtZfe5SrXMw6ddrDeMhBeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JJTi0rXo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JJTi0rXo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7B0D1F00893; Sat, 30 May 2026 18:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780167150; bh=SucX90gHg5Xd4Gw3/fJaipG2c/ui+EUQPc+agbyUvmU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=JJTi0rXogXXca1lmk1YZAdTzIw5Agc+UZ3FHr1RUEFaus0v21U+XlxK2F6FoNBifV mWlbSs/u53yRq+0PY+Qc7VDZUwt2WKUZ23PJZnKKrG1/8z2MTvelvC8A2pl0RtZT7U eCI3b8WIH0fiuvdPvj/YwJ0KD8S6kdM44QS+WdhA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tom Zanussi , Mathieu Desnoyers , Rosen Penev , Sashiko , "Masami Hiramatsu (Google)" , Steven Rostedt Subject: [PATCH 5.10 543/589] tracing: Do not call map->ops->elt_free() if elt_alloc() fails Date: Sat, 30 May 2026 18:07:04 +0200 Message-ID: <20260530160238.948728314@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Masami Hiramatsu (Google) commit 8f0f5c4fb9df0e19a341e0c6ed8dc4fda9124f03 upstream. In paths where tracing_map_elt_alloc() failed to allocate objects, the map->ops->elt_alloc() call was never successful. In this case, map->ops->elt_free() should not be called. Link: https://sashiko.dev/#/patchset/20260520223101.34710-1-rosenp%40gmail.com Cc: stable@vger.kernel.org Cc: Tom Zanussi Cc: Mathieu Desnoyers Cc: Rosen Penev Reported-by: Sashiko Fixes: 2734b629525a ("tracing: Add per-element variable support to tracing_map") Link: https://patch.msgid.link/177933895460.108746.5396070821443932634.stgit@devnote2 Signed-off-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt Signed-off-by: Greg Kroah-Hartman --- kernel/trace/tracing_map.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) --- a/kernel/trace/tracing_map.c +++ b/kernel/trace/tracing_map.c @@ -386,13 +386,11 @@ static void tracing_map_elt_init_fields( } } -static void tracing_map_elt_free(struct tracing_map_elt *elt) +static void __tracing_map_elt_free(struct tracing_map_elt *elt) { if (!elt) return; - if (elt->map->ops && elt->map->ops->elt_free) - elt->map->ops->elt_free(elt); kfree(elt->fields); kfree(elt->vars); kfree(elt->var_set); @@ -400,6 +398,17 @@ static void tracing_map_elt_free(struct kfree(elt); } +static void tracing_map_elt_free(struct tracing_map_elt *elt) +{ + if (!elt) + return; + + /* Only objects initialized with alloc_elt() should be passed to free_elt().*/ + if (elt->map->ops && elt->map->ops->elt_free) + elt->map->ops->elt_free(elt); + __tracing_map_elt_free(elt); +} + static struct tracing_map_elt *tracing_map_elt_alloc(struct tracing_map *map) { struct tracing_map_elt *elt; @@ -444,7 +453,7 @@ static struct tracing_map_elt *tracing_m } return elt; free: - tracing_map_elt_free(elt); + __tracing_map_elt_free(elt); return ERR_PTR(err); }