From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 899152628D; Sat, 30 May 2026 17:56:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780163772; cv=none; b=nRh1Z8yW6qduNbbTlNlId733XBsMKlvo2TUH9Tz40hxMDovu8Fcsnwxbxq4Fhjl8wUi/6P3ji17kYMireuVx69TY2m2Cfy4Ah9Kit+1zcVMoCCC1q3FjNCvZl+VwKJ1ivaGEdb23w6PymSdo786+r4qnpR6FrJXHYdqXEfSBPxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780163772; c=relaxed/simple; bh=VUP6dstj+1ZOcy1O4FWJCZ1j4AVIMmnhP4uAgojSzjw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S8Qan+YU117udIgEKOgozdr86baJ0Sq+9aCORVH+5xV0DhPdjSUKDlZd6sseXIOMV0OVt6bfmB4wVqGiVqv32QjeiDY6l7heIJ8mF4CQCI6GXSCMI8eMGWIz+WXOtqya41QzoBDL7YzxT4k660C7BKWIml2yfTk1rVscDqE1hyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=z2u/8OEM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="z2u/8OEM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDEC61F00893; Sat, 30 May 2026 17:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780163771; bh=WdV0JEUf1hxYqeLUqOJkQBwziFinlG3NWlR/EQaXvA8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=z2u/8OEMYYO105bVPKkEEEEX/QGbD8NVjf4qt6qJQYchvK61Ip9Euvhi6eM1f4Zqw sxem164P+/XT2DaJfH6mxAP9R1Y7xZKc7KFwisYkj1QNdox34NLfsCNnayDmPc9CaH WJoz4rGatktObMPO/RSfRJVtQC6jRMnwcfF9ylwQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Oliver Neukum , Sean Young , Hans Verkuil Subject: [PATCH 5.15 356/776] media: rc: streamzap: Error handling in probe Date: Sat, 30 May 2026 18:01:10 +0200 Message-ID: <20260530160249.783219883@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160240.228940103@linuxfoundation.org> References: <20260530160240.228940103@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Oliver Neukum commit 42844992664f03ef9f930e64f7370fa481e9c267 upstream. If submitting the URB fails, the device will be unusable. Probe() must fail. Fixes: 7a569f524dd36 ("V4L/DVB: IR/streamzap: functional in-kernel decoding") Cc: stable@vger.kernel.org Signed-off-by: Oliver Neukum Signed-off-by: Sean Young Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/rc/streamzap.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) --- a/drivers/media/rc/streamzap.c +++ b/drivers/media/rc/streamzap.c @@ -255,9 +255,8 @@ static void streamzap_callback(struct ur case -ESHUTDOWN: /* * this urb is terminated, clean up. - * sz might already be invalid at this point */ - dev_err(sz->dev, "urb terminated, status: %d\n", urb->status); + dev_dbg(sz->dev, "urb terminated, status: %d\n", urb->status); return; default: break; @@ -396,11 +395,16 @@ static int streamzap_probe(struct usb_in usb_set_intfdata(intf, sz); - if (usb_submit_urb(sz->urb_in, GFP_ATOMIC)) + retval = usb_submit_urb(sz->urb_in, GFP_ATOMIC); + if (retval < 0) { dev_err(sz->dev, "urb submit failed\n"); + goto rc_submit_fail; + } return 0; - +rc_submit_fail: + rc_free_device(sz->rdev); + usb_set_intfdata(intf, NULL); rc_dev_fail: usb_free_urb(sz->urb_in); free_buf_in: