From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFDDB320CAD; Sat, 30 May 2026 17:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780163860; cv=none; b=m5BIWtMmVS0rI9cVfKic7td2hy+AHHPlDWYBygLJM4098suJkiEEIaMd3ejIxEal2yte7HovlhAtinvE6y8sV78Kd3+eh8yg1UcEDEvjd9Iz5XGbBQEF5WNYVt1Z6ukNeaGhrOr7ZthbPfL+m3eusslg5UREKLUDV/RrPldXYUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780163860; c=relaxed/simple; bh=SJQarxh4drPFTBbc5NH1PAQ2rO0F8r4icKxaMAx+vpI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BmhsWcVfKPz3y22sUMLDmGLYYPklHQacuM7rmpX2E+RrQKNPcXQyQDH12AmynTWH7p1nnkJmntS0zbzqq+a+TN6l0z/B6tBCEDU+YmnhYqM1vFEPIkP4y+CLdVGx6sug9TQ36yWhDamXKGdFgZTIaEbI+SMt0vlPR+igCUzd3SM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RgJfGPTn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RgJfGPTn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B75621F00893; Sat, 30 May 2026 17:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780163858; bh=JCbGM0lw5Dln3ahbHhXb9NrPF+BHYLsKuy+ixRtNmQs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=RgJfGPTno8DUpL38kbgfxMBxV69OaLMN/Y1KoiHgIPJdWrQr15/g1fuztmXCKYuq3 uzDmQVhJWGlNjJ4L4Xkb813JrQnGnNNHz8aPvceueF1BnInXM3mRnLmvgcDI9yIAvA yFY1M2edr7nC96BN3A6GeTM0ghTwhPxUrUT+r7VU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, SDL , Benjamin Cheng , Ruijing Dong , Alex Deucher Subject: [PATCH 5.15 383/776] drm/amdgpu/vcn3: Avoid overflow on msg bound check Date: Sat, 30 May 2026 18:01:37 +0200 Message-ID: <20260530160250.412583664@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160240.228940103@linuxfoundation.org> References: <20260530160240.228940103@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Benjamin Cheng commit e6e9faba8100628990cccd13f0f044a648c303cf upstream. As pointed out by SDL, the previous condition may be vulnerable to overflow. Fixes: b193019860d6 ("drm/amdgpu/vcn3: Prevent OOB reads when parsing dec msg") Cc: SDL Signed-off-by: Benjamin Cheng Reviewed-by: Ruijing Dong Signed-off-by: Alex Deucher (cherry picked from commit db00257ac9e4a51eb2515aaea161a019f7125e10) Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c @@ -1924,6 +1924,7 @@ static int vcn_v3_0_dec_msg(struct amdgp for (i = 0, msg = &msg[6]; i < num_buffers; ++i, msg += 4) { uint32_t offset, size, *create; + uint64_t buf_end; if (msg[0] != RDECODE_MESSAGE_CREATE) continue; @@ -1931,7 +1932,8 @@ static int vcn_v3_0_dec_msg(struct amdgp offset = msg[1]; size = msg[2]; - if (size < 4 || offset + size > end - addr) { + if (size < 4 || check_add_overflow(offset, size, &buf_end) || + buf_end > end - addr) { DRM_ERROR("VCN message buffer exceeds BO bounds!\n"); r = -EINVAL; goto out;