From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 207D333FE15; Sat, 30 May 2026 16:59:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780160400; cv=none; b=ExyW60c46DC0vZpcfQ0mGrDgjGO1ZmnyToQFF0MQoDfSMzYNTiKbWoCI/yI02OleBKxGbTog4c9hOH6/y0AdFyHz7jhIrio3ADfY+qwfdoDT2sFBwZtSgral+vT966nAh3p/6IA3ll0CWctftBzWiRt5cKHLUmtA01rmmGR8nzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780160400; c=relaxed/simple; bh=1DmvsFRMyma3lL1Q/1k5ZRqaLCARJfpiMGFA4DvX7Ps=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MbUwzI8s4szVeWhUT7dtA4OMMrrf85Uc5W1f8K1jSXiTFcMfbObCmQKrYBEUPN7esGDShqrw2txUJhAMhToME0k+U3VboWhhVUTOHvGhtXLbkm/grzgcGb5+zebuIeczAWMx7CC3QWgXczsKehTGpuWUux3fqGApkehY+vrp42Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ksYKl/eq; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ksYKl/eq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65A851F00893; Sat, 30 May 2026 16:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780160399; bh=brmN9E88OmZ7DHjmCy7wXnmffMnDieF21WrMEti3TWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ksYKl/eqdPNYzkbz9PM5l40xXe+E0DIT5FMM+Xma7iIK1dUYZJQS0tupxaqLp3Lvh 9KGgW8fmVWkpK9YOF9Bor9jRpnDtT0HJ0oswmKnE53+EzlHoD/K9x6oXuMXoZkAQ8+ XIHVVaVLxtVutGAOHqaWvZBqbxUZoTx2OMu1VOA0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, kernel test robot , Dan Carpenter , Hongling Zeng , Helge Deller Subject: [PATCH 6.1 327/969] parisc: Fix IRQ leak in LASI driver Date: Sat, 30 May 2026 17:57:31 +0200 Message-ID: <20260530160309.420672554@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160300.485627683@linuxfoundation.org> References: <20260530160300.485627683@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hongling Zeng commit 37b0dc5e279f35036fb638d1e187197b6c05a76d upstream. When request_irq() succeeds but gsc_common_setup() fails later, the IRQ is never released. Fix this by adding proper error handling with goto labels to ensure resources are released in LIFO order. Detected by Smatch: drivers/parisc/lasi.c:216 lasi_init_chip() warn: 'lasi->gsc_irq.irq' from request_irq() not released on lines: 207. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202604180957.4QdAIxP6-lkp@intel.com/ Signed-off-by: Hongling Zeng Cc: stable@vger.kernel.org Signed-off-by: Helge Deller Signed-off-by: Greg Kroah-Hartman --- drivers/parisc/lasi.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) --- a/drivers/parisc/lasi.c +++ b/drivers/parisc/lasi.c @@ -196,8 +196,7 @@ static int __init lasi_init_chip(struct ret = request_irq(lasi->gsc_irq.irq, gsc_asic_intr, 0, "lasi", lasi); if (ret < 0) { - kfree(lasi); - return ret; + goto err_free; } /* enable IRQ's for devices below LASI */ @@ -206,8 +205,7 @@ static int __init lasi_init_chip(struct /* Done init'ing, register this driver */ ret = gsc_common_setup(dev, lasi); if (ret) { - kfree(lasi); - return ret; + goto err_irq; } gsc_fixup_irqs(dev, lasi, lasi_choose_irq); @@ -220,6 +218,12 @@ static int __init lasi_init_chip(struct chassis_power_off = lasi_power_off; return ret; + +err_irq: + free_irq(lasi->gsc_irq.irq, lasi); +err_free: + kfree(lasi); + return ret; } static struct parisc_device_id lasi_tbl[] __initdata = {