From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1C94395AEA; Sat, 30 May 2026 17:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780160853; cv=none; b=Jat6glM/2urMr1RQjInfczmoUjitWbE7sJwYxYiVt36L4zLFvW3CBcjvFPsUTYq/w8Fc5k+2cJm+XgoyZmq2jIrJN0MLok8DxuBYJPQKRIFdUXrwnlq2wlsIja8t/RSev0dq0E8CGzboFt2F+gbAkPJNgqVUEQk4Ymr0wjqDMok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780160853; c=relaxed/simple; bh=gPmN6UvfSFOp3iKKcNxckCYPf+mJd3Sy95Fxf/J9oSw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zk5YIlbivmZl4dQNa72qqxBlfYwouQzFV6PReSj3v0XzKLIKKVttgIlE0NzB0qariglYC3V1Im/E+I+PO7Rm+YxULr2SZvedfFFNT/BnDJxYO0lcs8VrH6Iw7ASSB/utwfkA7ZWXy8fmMkNOUtkTWu25Q4WM15Z5CiVPfvyeg04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bIy9PPPL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bIy9PPPL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1761A1F00893; Sat, 30 May 2026 17:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780160852; bh=0SEFAKpalO0quzPNebKzu+UEZq0FSbJF+IfP16/tYuQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bIy9PPPLCdu1VCs5SAOcqFsNgP+/AaKY5TalK0Yu9HHkS9Xzv00tUm5+tJDXOQYHN wjdn0KQ1E4YZUBX5Mmqgs0IiKe4/P3mtdsjroa48Fi7AdFIljSnEGXdX+dHHSgJ3T0 tbboF2hlYG9KRMxC9C8RX7Ejj4M9Za6FF4N/EUKA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cole Leavitt , Kees Cook , Sasha Levin Subject: [PATCH 6.1 436/969] pstore/ram: fix resource leak when ioremap() fails Date: Sat, 30 May 2026 17:59:20 +0200 Message-ID: <20260530160312.306850206@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160300.485627683@linuxfoundation.org> References: <20260530160300.485627683@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cole Leavitt [ Upstream commit 2ddb69f686ef7a621645e97fc7329c50edf5d0e5 ] In persistent_ram_iomap(), ioremap() or ioremap_wc() may return NULL on failure. Currently, if this happens, the function returns NULL without releasing the memory region acquired by request_mem_region(). This leads to a resource leak where the memory region remains reserved but unusable. Additionally, the caller persistent_ram_buffer_map() handles NULL correctly by returning -ENOMEM, but without this check, a NULL return combined with request_mem_region() succeeding leaves resources in an inconsistent state. This is the ioremap() counterpart to commit 05363abc7625 ("pstore: ram_core: fix incorrect success return when vmap() fails") which fixed a similar issue in the vmap() path. Fixes: 404a6043385d ("staging: android: persistent_ram: handle reserving and mapping memory") Signed-off-by: Cole Leavitt Link: https://patch.msgid.link/20260225235406.11790-1-cole@unwrap.rs Signed-off-by: Kees Cook Signed-off-by: Sasha Levin --- fs/pstore/ram_core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c index 0e58eb7ffac84..ed86e173f8cfc 100644 --- a/fs/pstore/ram_core.c +++ b/fs/pstore/ram_core.c @@ -489,6 +489,10 @@ static void *persistent_ram_iomap(phys_addr_t start, size_t size, else va = ioremap_wc(start, size); + /* We must release the mem region if ioremap fails. */ + if (!va) + release_mem_region(start, size); + /* * Since request_mem_region() and ioremap() are byte-granularity * there is no need handle anything special like we do when the -- 2.53.0