From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8BF334EF07; Sat, 30 May 2026 17:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780161239; cv=none; b=bnYMekUSMAUOo2yu1sZB0ptmS23DDn5Q6yIys37fStKw0ZMKWTBOgv0aRhYh0rqhmHwhQDWRGd9rWTZUkC8kHxMZv7QzU+Wi7N+88FDHkHAPVN+KPcC+MkIgFGGTxt3cXz+wiWGrjShLMeGnRykNFQzTFTDaIJ5//pivAW2jpdQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780161239; c=relaxed/simple; bh=omRfopVejZgPNDU8dvQ0gQ2PFIx6YxwNZqQ0vvyKpYs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lqpC0+a90/inQRcDTCqGQYBg92qT94FD5OpsrXLMQqgzG0GJBmqutdS+jASiibmCvASNSwkn6siS89yfT4oaM0ci4KF91k09/Mgme62eLZz7TvteC9szYuc5or/VLF6/7/g4ci4VMQvmZB5fGlPwhvFYdQ6Jt4fCDn/lSvaIick= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=J7gaKypw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="J7gaKypw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 307EE1F00893; Sat, 30 May 2026 17:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780161237; bh=ncY9R+Dfi2TK1c4BvYmhUrG75uYvkTGF3BWPLFeKHfw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=J7gaKypw52IQ2CIdZXM6pBbGZhfnJpTOAfCi1pWTAEat1VCArYEMdZLtw1OzXRZXK MTGfdzk5bHg0MfROAzQN4kUMXkOjEPEbQyJYjaAj4nQrvDoATWQRX6v99l5IMIxW47 r4V8g8TEk/HY4g61dDVQMZgzs2fAndYfxkkz0JRQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, John Hawley , Andrea Righi , Marcos Paulo de Souza , Matthieu Baerts , Fernando Fernandez Mancera , Pedro Falcato , "=?UTF-8?q?Ricardo=20B . =20Marli=C3=A8re?=" , Steven Rostedt , Sasha Levin Subject: [PATCH 6.1 564/969] ktest: Avoid undef warning when WARNINGS_FILE is unset Date: Sat, 30 May 2026 18:01:28 +0200 Message-ID: <20260530160315.963395607@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160300.485627683@linuxfoundation.org> References: <20260530160300.485627683@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ricardo B. Marlière [ Upstream commit 057854f8a595160656fe77ed7bf0d2403724b915 ] check_buildlog() probes $warnings_file with -f even when WARNINGS_FILE is not configured. Perl warns about the uninitialized value and adds noise to the test log, which can hide the output we actually care about. Check that WARNINGS_FILE is defined before testing whether the file exists. Cc: John Hawley Cc: Andrea Righi Cc: Marcos Paulo de Souza Cc: Matthieu Baerts Cc: Fernando Fernandez Mancera Cc: Pedro Falcato Link: https://patch.msgid.link/20260307-ktest-fixes-v1-1-565d412f4925@suse.com Fixes: 4283b169abfb ("ktest: Add make_warnings_file and process full warnings") Signed-off-by: Ricardo B. Marlière Signed-off-by: Steven Rostedt Signed-off-by: Sasha Levin --- tools/testing/ktest/ktest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index b1bd8be3cf666..d752c4bd0d8b3 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -2465,7 +2465,7 @@ sub check_buildlog { my $save_no_reboot = $no_reboot; $no_reboot = 1; - if (-f $warnings_file) { + if (defined($warnings_file) && -f $warnings_file) { open(IN, $warnings_file) or dodie "Error opening $warnings_file"; -- 2.53.0