From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C395F341AB8; Sat, 30 May 2026 17:32:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780162342; cv=none; b=G9F3HV2FzDTSQPHrcSaf34wwL0jSGFj0JJ0RKxk8ruHYi5qwOar/GsW5L4UCArlPz3X0Dan7XA3FmBVm4o4fuZI2i2dRf8JF89Wl8BgN60M9s5SMva85FuTT/GBJY2nC/xoczC5uUeDsyBTR/QbbOSHf7vpbIXy4phSjPGsn3+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780162342; c=relaxed/simple; bh=VIQ003I6a1tY19bLMcQsAIE99rTV75QPr3B0rUeA/vQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VzPfVj+gu/+ueSY0Wvd0fKhAGJ87f+TWb/FltmPtPzZFuXolmCcCt9pXpKutRG9Mc5eBBaQ1bQizeQI6C26eXt/EqX88fK5ERRFAt8rF0d+TTBLz2tsNDxA6u8rsqHsuU1BOv9mEwqC5V8cHvXwIDjiyPlqXjYhnamraxE946TU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Tc4QBjp5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Tc4QBjp5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A69F1F00893; Sat, 30 May 2026 17:32:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780162341; bh=vST3PBE5z8Y/BzE2hZDo+igBt4bDOFvHBIc0iuDcIKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Tc4QBjp5gu8yqLV7y7BMFc2R+md/wpmDEtxBF2zLULRb1zmgCmoQvjzbpLqd69ck1 N870IpSU3Koz5+7sSU/jJ5WlzJ7ZseV2nKcIKLWJiASDecIRriZklSgiguzH/jVou4 682iBVVYYuTA+FP1ioMdmvKbbBnPVEW36AM4GfOM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Abdurrahman Hussain , Guenter Roeck Subject: [PATCH 6.1 892/969] hwmon: (pmbus/adm1266) include PEC byte in pmbus_block_xfer read buffer Date: Sat, 30 May 2026 18:06:56 +0200 Message-ID: <20260530160325.335356876@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160300.485627683@linuxfoundation.org> References: <20260530160300.485627683@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Abdurrahman Hussain commit 487566cb1ccdf3756fdd7bf8d875e612ff3169bb upstream. adm1266_pmbus_block_xfer() sets up the read transaction with .buf = data->read_buf, .len = ADM1266_PMBUS_BLOCK_MAX + 2, but read_buf in struct adm1266_data is declared as u8 read_buf[ADM1266_PMBUS_BLOCK_MAX + 1]; For a max-length block response (length byte = 255 + up to 1 PEC byte), the i2c controller is told to write 257 bytes into a 256-byte buffer, putting one byte past the end of read_buf. The same response also makes the subsequent PEC compare if (crc != msgs[1].buf[msgs[1].buf[0] + 1]) read a byte beyond the array. Bump the read_buf declaration to ADM1266_PMBUS_BLOCK_MAX + 2 so the buffer can hold the length byte, up to 255 payload bytes, and the PEC byte the i2c_msg length already accounts for. Fixes: 407dc802a9c0 ("hwmon: (pmbus/adm1266) Add Block process call") Cc: stable@vger.kernel.org Signed-off-by: Abdurrahman Hussain Link: https://lore.kernel.org/r/20260515-adm1266-fixes-v1-4-1c1ea1349cfe@nexthop.ai Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/pmbus/adm1266.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/hwmon/pmbus/adm1266.c +++ b/drivers/hwmon/pmbus/adm1266.c @@ -61,7 +61,7 @@ struct adm1266_data { u8 *dev_mem; struct mutex buf_mutex; u8 write_buf[ADM1266_PMBUS_BLOCK_MAX + 1] ____cacheline_aligned; - u8 read_buf[ADM1266_PMBUS_BLOCK_MAX + 1] ____cacheline_aligned; + u8 read_buf[ADM1266_PMBUS_BLOCK_MAX + 2] ____cacheline_aligned; }; static const struct nvmem_cell_info adm1266_nvmem_cells[] = {