From: Patrick Robb <patrickrobb1997@gmail.com>
To: abailey@iol.unh.edu
Cc: dev@dpdk.org, dmarx@iol.unh.edu, luca.vizzarro@arm.com,
probb@iol.unh.edu, Patrick Robb <patrickrobb1997@gmail.com>
Subject: Re: [v2] dts: add support for no link topology
Date: Sat, 30 May 2026 16:37:57 -0400 [thread overview]
Message-ID: <20260530203757.22139-1-patrickrobb1997@gmail.com> (raw)
In-Reply-To: <20260224163200.39360-1-abailey@iol.unh.edu>
from pathlib import Path, PurePath
from typing import ClassVar, Final
+from api.capabilities import LinkTopology
from framework.config.test_run import (
DPDKBuildConfiguration,
DPDKBuildOptionsConfiguration,
@@ -263,7 +264,8 @@ def _build_dpdk(self) -> None:
ctx = get_ctx()
# If the SUT is an ice driver device, make sure to build with 16B descriptors.
if (
- ctx.topology.sut_port_ingress
+ ctx.topology.type is not LinkTopology.NO_LINK
+ and not ctx.topology.sut_port_ingress
and ctx.topology.sut_port_ingress.config.os_driver == "ice"
):
I don't understand the change above. Surely we do want to set the custom meson args for ICE DUTs when there is a sut_port_ingress, not when there isn't a sut_port_ingress, right?
Also, does the topology type affect whether we want to use these custom args, if the SUT driver is ice? I guess in a weird case we could have an ethdev test using an ice DUT which does not need a TG?
Reviewed-by: Patrick Robb <patrickrobb1997@gmail.com>
next prev parent reply other threads:[~2026-05-30 20:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 19:25 [PATCH v1] dts: add support for no link topology Andrew Bailey
2026-02-24 16:32 ` [PATCH v2] " Andrew Bailey
2026-03-09 15:26 ` Andrew Bailey
2026-03-09 15:48 ` Andrew Bailey
2026-03-09 16:16 ` Patrick Robb
2026-04-10 14:36 ` Andrew Bailey
2026-05-30 20:37 ` Patrick Robb [this message]
2026-06-01 17:16 ` [v2] " Andrew Bailey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260530203757.22139-1-patrickrobb1997@gmail.com \
--to=patrickrobb1997@gmail.com \
--cc=abailey@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=luca.vizzarro@arm.com \
--cc=probb@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.