From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Kane Chen" <kane_chen@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"Alistair Francis" <alistair@alistair23.me>,
"Ninad Palsule" <ninad@linux.ibm.com>,
"Jason Wang" <jasowang@redhat.com>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>
Subject: [PATCH v1 21/24] hw/pci-host/aspeed_pcie: Convert to DEFINE_TYPES() with inlined TypeInfo
Date: Mon, 1 Jun 2026 02:50:32 +0000 [thread overview]
Message-ID: <20260601024959.2347639-22-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20260601024959.2347639-1-jamin_lin@aspeedtech.com>
Replace the legacy type_register_static()/type_init() registration
pattern with the modern DEFINE_TYPES() macro.
Inline 6 standalone TypeInfo variables (aspeed_pcie_phy_info, aspeed_2700_pcie_phy_info
aspeed_pcie_root_port_info, aspeed_pcie_rc_info, aspeed_pcie_cfg_info and
aspeed_2700_pcie_cfg_info directly into the 'aspeed_pcie_types[]'
array, removing the need for separate declarations.
No functional change.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/pci-host/aspeed_pcie.c | 94 +++++++++++++++++----------------------
1 file changed, 41 insertions(+), 53 deletions(-)
diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c
index 186e5aeea2..b46eb74234 100644
--- a/hw/pci-host/aspeed_pcie.c
+++ b/hw/pci-host/aspeed_pcie.c
@@ -83,13 +83,6 @@ static void aspeed_pcie_root_port_class_init(ObjectClass *klass,
rpc->ssid = 0x1150;
}
-static const TypeInfo aspeed_pcie_root_port_info = {
- .name = TYPE_ASPEED_PCIE_ROOT_PORT,
- .parent = TYPE_PCIE_ROOT_PORT,
- .instance_size = sizeof(AspeedPCIERootPortState),
- .class_init = aspeed_pcie_root_port_class_init,
-};
-
/*
* PCIe Root Complex (RC)
*/
@@ -305,14 +298,6 @@ static void aspeed_pcie_rc_class_init(ObjectClass *klass, const void *data)
msi_nonbroken = true;
}
-static const TypeInfo aspeed_pcie_rc_info = {
- .name = TYPE_ASPEED_PCIE_RC,
- .parent = TYPE_PCIE_HOST_BRIDGE,
- .instance_size = sizeof(AspeedPCIERcState),
- .instance_init = aspeed_pcie_rc_instance_init,
- .class_init = aspeed_pcie_rc_class_init,
-};
-
/*
* PCIe Config
*
@@ -679,15 +664,6 @@ static void aspeed_pcie_cfg_class_init(ObjectClass *klass, const void *data)
apc->rc_rp_addr = PCI_DEVFN(8, 0);
}
-static const TypeInfo aspeed_pcie_cfg_info = {
- .name = TYPE_ASPEED_PCIE_CFG,
- .parent = TYPE_SYS_BUS_DEVICE,
- .instance_init = aspeed_pcie_cfg_instance_init,
- .instance_size = sizeof(AspeedPCIECfgState),
- .class_init = aspeed_pcie_cfg_class_init,
- .class_size = sizeof(AspeedPCIECfgClass),
-};
-
static void aspeed_2700_pcie_cfg_write(void *opaque, hwaddr addr,
uint64_t data, unsigned int size)
{
@@ -798,12 +774,6 @@ static void aspeed_2700_pcie_cfg_class_init(ObjectClass *klass,
apc->rc_rp_addr = PCI_DEVFN(0, 0);
}
-static const TypeInfo aspeed_2700_pcie_cfg_info = {
- .name = TYPE_ASPEED_2700_PCIE_CFG,
- .parent = TYPE_ASPEED_PCIE_CFG,
- .class_init = aspeed_2700_pcie_cfg_class_init,
-};
-
/*
* PCIe PHY
*
@@ -926,14 +896,6 @@ static void aspeed_pcie_phy_class_init(ObjectClass *klass, const void *data)
apc->nr_regs = 0x100 >> 2;
}
-static const TypeInfo aspeed_pcie_phy_info = {
- .name = TYPE_ASPEED_PCIE_PHY,
- .parent = TYPE_SYS_BUS_DEVICE,
- .instance_size = sizeof(AspeedPCIEPhyState),
- .class_init = aspeed_pcie_phy_class_init,
- .class_size = sizeof(AspeedPCIEPhyClass),
-};
-
static void aspeed_2700_pcie_phy_reset_hold(Object *obj, ResetType type)
{
AspeedPCIEPhyState *s = ASPEED_PCIE_PHY(obj);
@@ -961,21 +923,47 @@ static void aspeed_2700_pcie_phy_class_init(ObjectClass *klass,
apc->nr_regs = 0x800 >> 2;
}
-static const TypeInfo aspeed_2700_pcie_phy_info = {
- .name = TYPE_ASPEED_2700_PCIE_PHY,
- .parent = TYPE_ASPEED_PCIE_PHY,
- .class_init = aspeed_2700_pcie_phy_class_init,
-};
+static const TypeInfo aspeed_pcie_types[] = {
+ {
+ .name = TYPE_ASPEED_PCIE_RC,
+ .parent = TYPE_PCIE_HOST_BRIDGE,
+ .instance_size = sizeof(AspeedPCIERcState),
+ .instance_init = aspeed_pcie_rc_instance_init,
+ .class_init = aspeed_pcie_rc_class_init,
+ },
+ {
+ .name = TYPE_ASPEED_PCIE_ROOT_PORT,
+ .parent = TYPE_PCIE_ROOT_PORT,
+ .instance_size = sizeof(AspeedPCIERootPortState),
+ .class_init = aspeed_pcie_root_port_class_init,
+ },
+ {
+ .name = TYPE_ASPEED_PCIE_CFG,
+ .parent = TYPE_SYS_BUS_DEVICE,
+ .instance_init = aspeed_pcie_cfg_instance_init,
+ .instance_size = sizeof(AspeedPCIECfgState),
+ .class_init = aspeed_pcie_cfg_class_init,
+ .class_size = sizeof(AspeedPCIECfgClass),
+ },
+ {
+ .name = TYPE_ASPEED_PCIE_PHY,
+ .parent = TYPE_SYS_BUS_DEVICE,
+ .instance_size = sizeof(AspeedPCIEPhyState),
+ .class_init = aspeed_pcie_phy_class_init,
+ .class_size = sizeof(AspeedPCIEPhyClass),
+ },
+ {
+ .name = TYPE_ASPEED_2700_PCIE_PHY,
+ .parent = TYPE_ASPEED_PCIE_PHY,
+ .class_init = aspeed_2700_pcie_phy_class_init,
+ },
+ {
+ .name = TYPE_ASPEED_2700_PCIE_CFG,
+ .parent = TYPE_ASPEED_PCIE_CFG,
+ .class_init = aspeed_2700_pcie_cfg_class_init,
+ }
-static void aspeed_pcie_register_types(void)
-{
- type_register_static(&aspeed_pcie_rc_info);
- type_register_static(&aspeed_pcie_root_port_info);
- type_register_static(&aspeed_pcie_cfg_info);
- type_register_static(&aspeed_2700_pcie_cfg_info);
- type_register_static(&aspeed_pcie_phy_info);
- type_register_static(&aspeed_2700_pcie_phy_info);
-}
+};
-type_init(aspeed_pcie_register_types);
+DEFINE_TYPES(aspeed_pcie_types)
--
2.43.0
next prev parent reply other threads:[~2026-06-01 2:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 2:50 [PATCH v1 00/24] hw/aspeed: Convert all Aspeed devices to DEFINE_TYPES() with inlined TypeInfo Jamin Lin
2026-06-01 2:50 ` [PATCH v1 01/24] hw/misc/aspeed_hace: Convert " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 02/24] hw/misc/aspeed_lpc: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 03/24] hw/misc/aspeed_ltpi: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 04/24] hw/misc/aspeed_pwm: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 05/24] hw/misc/aspeed_sbc: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 06/24] hw/misc/aspeed_scu: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 07/24] hw/misc/aspeed_sdmc: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 08/24] hw/misc:aspeed_sli: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 09/24] hw/misc/aspeed_xdma: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 10/24] hw/adc/aspeed_adc: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 11/24] hw/arm/aspeed_ast1700: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 12/24] hw/gpio/aspeed_gpio: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 13/24] hw/gpio/aspeed_sgpio: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 14/24] hw/intc/aspeed_intc: convert " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 15/24] hw/intc/aspeed_vic: Convert " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 16/24] hw/rtc/aspeed_rtc: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 17/24] hw/watchdog/wdt_aspeed: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 18/24] hw/nvram/aspeed_otp: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 19/24] hw/timer/aspeed_timer: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 20/24] hw/fsi/aspeed_apb2opb: " Jamin Lin
2026-06-01 2:50 ` Jamin Lin [this message]
2026-06-01 2:50 ` [PATCH v1 22/24] hw/i2c/aspeed_i2c: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 23/24] hw/net/ftgmac100: " Jamin Lin
2026-06-01 2:50 ` [PATCH v1 24/24] hw/ssi/aspeed_smc: " Jamin Lin
2026-06-01 8:49 ` [PATCH v1 00/24] hw/aspeed: Convert all Aspeed devices " Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601024959.2347639-22-jamin_lin@aspeedtech.com \
--to=jamin_lin@aspeedtech.com \
--cc=alistair@alistair23.me \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=leetroy@gmail.com \
--cc=ninad@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.